Ignore whitespace before and after git tags

未關閉

#645 建立於 2026年1月8日 0 則留言 0 個 reaction 已指派 0 人在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度: 3/5
預估耗時: 1-2 天
新手友好度: 45/100

Issue 類型: 缺陷
描述清晰度: 基本清楚
活躍度: 停滯
技術堆疊: git, python
領域: cli, tooling

研究方向

從 pwclient 的 git-am 進入點開始，使用 issue 中所示的兩側帶有空白的 Reviewed-by 標籤重現回報的修補程式。判斷標籤解析屬於 patchwork 還是 pwclient，接著驗證 git-am 會保留該標籤，並確認不帶周圍空白的標籤仍能正常運作。

由索引模型根據 Issue 內容生成。

描述

NOTE: Experienced on old 2.2.0, maybe it has been fixed. Also I'm not sure if it is patchwork or pwclient issue.

Space before git tags (e.g. Reviewed-by: Li Wang <liwang@redhat.com>) causes pwclient git-am to ignore them.

See:
https://lore.kernel.org/ltp/CAEemH2dU6XP+Er75eERgo+p7TyMgEjMJY7tjAGA15NOKFrZM+A@mail.gmail.com/
https://patchwork.ozlabs.org/project/ltp/patch/20251010113014.309433-1-pvorel@suse.cz/#3595268

$ cat ~/.pwclientrc
[ozlabs]
url = https://patchwork.ozlabs.org/xmlrpc/
username: ...
password: ...

$ pwclient git-am 2148087 -p ozlabs
Applying patch #2148087 using "git am"
Description: tst_cmd.h: Convert the rest of comments to kerneldoc
Applying: tst_cmd.h: Convert the rest of comments to kerneldoc

$ git log -1
commit 980c30ad8042de6694be88866a0d668aa8748bc9 (HEAD -> xxx)
Author: Petr Vorel <pvorel@suse.cz>
Date:   Fri Oct 10 13:30:14 2025 +0200

    tst_cmd.h: Convert the rest of comments to kerneldoc
    
    Move docs from the private function implementations (functions with
    trailing underscore) to functions used into functions used in the new
    API.
    
    This avoids to document private functions.
    
    Signed-off-by: Petr Vorel <pvorel@suse.cz>
    Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

=> There is no Reviewed-by: Li Wang <liwang@redhat.com>.