Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Labeled methods should always be recorded, even if they match trivial-method filters

未關閉
#323 0 則留言 1 個 reaction 已指派 2 人 在 GitHub 檢視

@kgilpin 已經在處理了。

開始於 2026年4月1日。

  • #324 來自 @copilot-swe-agent —— 未關閉

評估

這個 Issue 還沒有評估資料。

描述

Summary

Methods annotated with @Labels(...) from appmap-annotation are not recorded when the agent considers them "trivial" (e.g. simple getter/setter patterns like getFirstName() that just return a field). The agent's trivial-method filter takes precedence over the explicit label annotation.

Expected behavior

If a developer explicitly labels a method with @Labels(...), that method should always be recorded in the AppMap trace, regardless of whether it would otherwise be filtered out as trivial. The label annotation is a deliberate opt-in signal that the method is meaningful for analysis.

Observed behavior

Given a class like:

@Labels("secret")
public String getFirstName() {
    return this.firstName;
}

The method does not appear in the recorded AppMap events or classMap. In contrast, a method with identical logic but a non-getter name is recorded:

@Labels("secret")
public String firstName() {
    return this.firstName;
}

This was confirmed by comparing the recorded events across multiple test runs. Methods like getPet (which has a loop and conditional logic) are recorded normally — the filter appears to target methods based on complexity/pattern, not just the get prefix.

Workaround

Wrap the getter in a non-getter-named method and label that instead:

@Labels("secret")
public String firstName() {
    return this.firstName;
}

public String getFirstName() {
    return firstName();
}

This works but is awkward — it forces users to create redundant wrapper methods just to satisfy the agent's filter.

Environment

  • appmap-agent 1.30.0
  • appmap-annotation 1.28.0
  • Java 23 (OpenJDK)
  • Spring Boot 2.4.5
主要語言
Java
星號
88
分支
17
平均合併
2 天 2 小時
30 天內合併 PR
1

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

getappmap/appmap-java 的其他 Issue

查看 getappmap/appmap-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。