Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

[FR] Relax encapsulation for Firebase Messaging exception and Messages payload to enable testability

未關閉
#695 9 則留言 11 個 reaction 已指派 1 人 在 GitHub 檢視

@lahirumaramba 已經在處理了。

開始於 2025年4月8日。

評估

這個 Issue 還沒有評估資料。

描述

api: messaging type: feature request

Currently, unit testing for integration with Firebase Messaging is very challenging. The encapsulation imposed by the final and visibility of the method makes it untestable. On top of this, there is no emulator for Firebase messaging which could help with testing integration with a more production-like environment.

  1. I want to emulate exceptions on FCM Messaging like UNREGISTERED, INVALID_ARGUMENT when calling com.google.firebase.messaging.FirebaseMessaging#send(com.google.firebase.messaging.Message) to test my error handling implementation e.g deleting invalid token
  • com.google.firebase.messaging.FirebaseMessagingException is final thus mocking with popular libraries like Mockito is more difficult. We need to enable extra feature flags in Mockito to allow for mocking the class
  • It's impossible to create an instance of an exception with FCM Messaging exception as factory methods and constructors are package protected com.google.firebase.messaging.FirebaseMessagingException#withMessagingErrorCode
  1. I want to unit test if a message with a given payalod was sent to FCM
    Currently FCM payload represented with com.google.firebase.messaging.Message is not accessible to third parties via getters.
  • Assuming I want to test if a proper payload was sent via com.google.firebase.messaging.FirebaseMessaging#send(com.google.firebase.messaging.Message) to FCM I would like to mock com.google.firebase.messaging.FirebaseMessaging and validate that com.google.firebase.messaging.FirebaseMessaging#send(com.google.firebase.messaging.Message) method was invoked with given data and token

In this case, developers used @VisibleForTesting for their purposes for testing while they totally forgot about developers who use their library and can not access the payload of the message. On top of this, there is no provided reasonable toString to make any assertions based on this.

Describe the solution you'd like
Exceptions testing

  • Option 1
    Relax encapsulation for com.google.firebase.messaging.FirebaseMessagingException by deleting "final" on class and make errorCode protected
  • Option 2
    Make factory method public com.google.firebase.messaging.FirebaseMessagingException#withMessagingErrorCode

Messages testing

  • Option 1
    Make getter public for com.google.firebase.messaging.Message#Message to allow accessing payload of FCM message
  • Option 2
    Provide reasonable toString to allow asserting on the toString method

Describe alternatives you've considered

  • Provide emulator for FCM which allows emulating different scenarios including errors
  • Provide dedicated implementations for testing purposes, open for all users

Additional context
Too aggressive encapsulation in my opinion is harmful. Developers should balance encapsulation and testability, taking into account the users of their libraries not only their own goals to protect their code with all means available in Java which are not perfect

主要語言
Java
星號
620
分支
305
平均合併
4 天 9 小時
30 天內合併 PR
4

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

firebase/firebase-admin-java 的其他 Issue

查看 firebase/firebase-admin-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。