[IO::Handle] Destroying a borrowed DATA handle closes the stream
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start by reading IO::Handle::DESTROY and the overlapping RuntimeIO ownership work in #1649 and PR #1938; coordinate before changing handle cleanup. Add the focused regression for destroying a wrapper around a borrowed package DATA handle, first validating it with system Perl. Done means the borrowed handle remains readable, owned descriptors and explicit close still clean up, and the regression plus CPAN::Repository 0.010 suite pass on both backends.
由索引模型根據 Issue 內容生成。
描述
Summary
PerlOnJava closes a package's borrowed DATA handle when a temporary FileHandle wrapper is destroyed. File::MMagic uses this pattern for its built-in magic table. After the first archive type check, the package DATA stream is closed; subsequent checks load no magic entries and return application/octet-stream. Archive::Any has no handler for that type, so Dist::Data then calls extract on an undefined archive object.
This caused CPAN::Repository 0.010 to fail in CPAN random run 20261111-090841-71684, test t/10-simple.t.
Reproducer
With File::MMagic 1.30 and two gzip archives, run both checks in the same process:
use File::MMagic;
for my $path (@ARGV) {
print File::MMagic->new()->checktype_filename($path), "\n";
}
Use the CPAN::Repository 0.010 fixtures My-Sample-Distribution-0.003.tar.gz and My-Other-Sample-0.001.tar.gz as the two arguments.
Expected on system Perl:
application/x-gzip
application/x-gzip
Actual on PerlOnJava JVM and interpreter:
application/x-gzip
application/octet-stream
The archived t/10-simple.t failure then reports:
No handler available for type 'application/octet-stream'
Can't call method "extract" on an undefined value
Root cause evidence
File::MMagic::new borrows *File::MMagic::DATA{IO} and blesses that handle as a FileHandle. PerlOnJava's IO::Handle::DESTROY unconditionally closes a handle with a defined fileno, without distinguishing a borrowed package handle from a handle owned by that wrapper. Instrumentation shows that after the temporary detector is released, the DATA handle is closed (tell returns -1 and eof is true); the next detector loads no magic entries. Keeping a detector object alive across both calls avoids the failure.
Validation and environment
- CPAN::Repository 0.010: PerlOnJava JVM and interpreter both fail
t/10-simple.twith this error. - System Perl 5.34.1: all four upstream test files pass, 16 tests total.
File::MMagic1.30 andMIME::Types2.30 were installed in an isolated temporary library because the host Perl lacked them. - PerlOnJava source:
308a379fc6778e5db851d10c260656e82ce03944; OpenJDK 24.0.2, macOS 26.7.1 arm64. - The target distribution and the relevant archive dependencies are pure Perl; this is not an XS build or environment-prerequisite failure.
Acceptance criteria
- Add a focused project-owned regression showing that destroying a wrapper for a borrowed package
DATAhandle leaves that handle readable, validated first with system Perl. - Preserve cleanup for genuinely owned file descriptors and explicit
closebehavior. - Pass the focused regression on JVM and interpreter, and pass the CPAN::Repository 0.010 upstream suite on both backends.
Coordination and related issues
The active #1649 ownership work and PR #1938 cover broad IO resource ownership and modify RuntimeIO; coordinate before editing overlapping handle cleanup paths. #1244 records a different compile-time-loading failure that also affected a DATA handle. #2024/#2035 addressed ambiguous close warnings, not this ownership bug.
- 主要語言
- Perl
- 星號
- 67
- 分支
- 8
- 平均合併
- 5 小時 12 分鐘
- 30 天內合併 PR
- 131
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
fglock/PerlOnJava 的其他 Issue
-
area:cpan-port bug
難度 2/5 1-3 小時 新手友好度 70/100
fglock/PerlOnJava#2153 ·
維護者通常 1 天內回覆
-
area:cpan-port area:parser bug
難度 2/5 1-3 小時 新手友好度 68/100
fglock/PerlOnJava#2137 ·
維護者通常 1 天內回覆
-
area:backend area:cpan-port area:runtime bug
難度 2/5 1-3 小時 新手友好度 76/100
fglock/PerlOnJava#2071 ·
維護者通常 1 天內回覆
-
area:runtime documentation enhancement
難度 2/5 1-3 小時 新手友好度 72/100
fglock/PerlOnJava#1579 ·
維護者通常 1 天內回覆
-
area:cpan-port bug
難度 3/5 1-2 天 新手友好度 62/100
fglock/PerlOnJava#2157 ·
維護者通常 1 天內回覆
查看 fglock/PerlOnJava 的全部 Issue
相似的 Issue
-
Dev-output directory preparation accepts file-valued lib/include paths and fails on dangling links未關閉team-cli
難度 2/5 1-3 小時 新手友好度 70/100
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 66/100
-
難度 1/5 1 小時以內 新手友好度 93/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 73/100
inverse-inc/packetfence#9728 ·
維護者通常 1 天內回覆
-
fix(char-create): show the real reason a character is refused可能已有人在做 @baphomello 於 1 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 84/100
維護者通常 1 天內回覆