Port Image::ExifTool 13.55 to pass the full upstream suite

已關閉
#1,659 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
25/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
java, perl

研究方向

Start by reading the repository’s ExifTool test runner and reproduce the 13.55 suite against system Perl, then both PerlOnJava backends; the payload names Image/ExifTool/WriteExif.pl lines 1157 and 1161 and 16 incomplete test programs. Reduce the goto and transliteration failures to minimal cases, determine which errors are cascades, and add regression coverage for each root cause. Done means all 113 programs pass on all three runtimes with complete TAP plans, and the final source passes nice -n 19 make.

由索引模型根據 Issue 內容生成。

描述

area:backend area:cpan-port area:parser bug

Goal

Port and validate upstream Image::ExifTool 13.55 so its complete test suite passes on PerlOnJava. This is a new follow-up to #93, which was closed after the full suite passed on ExifTool 13.50. The broader release qualification is tracked in #1646; this issue owns the concrete ExifTool porting and verification work.

Current evidence

CPAN random tester run 20261006-085241-91243 selected File::RandomAccess from Image-ExifTool-13.55. The module-name row refers to a dependency; the failing target test block is Image::ExifTool 13.55.

  • PerlOnJava ran all 113 test programs, with 16 programs aborting and 0/458 executed assertions reported as failed. The aborted files have incomplete TAP plans: t/CanonRaw.t, t/Casio.t, t/DNG.t, t/FujiFilm.t, t/MIE.t, t/Olympus.t, t/Panasonic.t, t/Pentax.t, t/PhaseOne.t, t/PostScript.t, t/Sanyo.t, t/Sigma.t, t/Sony.t, t/Unknown.t, t/Writer.t, and t/XMP.t.
  • Repeated diagnostics include Use of "goto" to jump into a construct is no longer permitted in Image/ExifTool/WriteExif.pl at lines 1157 and 1161. These occur during loading/writing code and cause many incomplete test plans.
  • Another diagnostic is Invalid range "\x{A4}-\x{82}" in transliteration operator while loading ExifTool data, followed by missing Sony tag tables. Determine whether this has the same root cause as the aborted loads or needs a separate fix.
  • The system-Perl oracle did not reach Image::ExifTool's test suite: optional Compress::Raw::Lzma failed to build because lzma.h was unavailable. This is a prerequisite/setup gap, not a system-Perl test result.
  • Environment recorded by the archived run: macOS/Homebrew Perl 5.42.2 and OpenJDK 24.0.2. The PerlOnJava commit and separate JVM/interpreter results were not recorded in that log.

Work plan

  1. Establish a valid upstream baseline. Set up Image::ExifTool 13.55 and its test prerequisites in an isolated local library/environment. Resolve the optional Compress::Raw::Lzma build prerequisite (including the required LZMA headers) or establish from upstream test configuration that it can be omitted without changing test behavior. Run the unchanged full suite with system Perl and retain the complete output. Record exact versions and test counts.
  2. Reproduce on both PerlOnJava backends. Run the same unchanged 13.55 suite with the JVM backend and interpreter backend, using the repository's ExifTool test runner and bounded per-test timeouts. Capture full logs, test identities, diagnostics, and environment details. Compare results against the system-Perl baseline.
  3. Reduce failures by root cause. Start with the goto failures in WriteExif.pl 1157/1161 and the invalid transliteration range. Reduce each earliest failure to a minimal Perl program or a minimal unchanged upstream test case. Determine whether the Sony table-load errors and remaining incomplete plans are downstream cascades. Separate unrelated failures rather than masking them with skips.
  4. Implement the required compatibility work. Fix the responsible parser/compiler/runtime or bundled provider behavior while preserving standard Perl semantics. If a narrow ExifTool-specific adaptation is necessary, keep it minimal and document why upstream behavior requires it. Do not patch or delete upstream tests.
  5. Add permanent regression coverage. Validate each new project-owned regression test with system Perl first. Preserve evidence that it fails on the unfixed PerlOnJava parent, then require success on both backends; include direct compiler/runtime coverage where that layer owns the defect.
  6. Run focused and full validation. Re-run each reduced reproducer, the affected upstream tests, and all 113 Image::ExifTool test programs on system Perl, JVM, and interpreter. Confirm there are no errors, timeouts, or skipped tests, and that TAP plans complete. Record the exact 13.55 results and update #1646 with the qualification outcome.
  7. Integrate only after the immutable test gate passes. Run the required repository nice -n 19 make gate on the final source state, then the ExifTool suite against that built artifact. Keep the issue open until the full in-scope suite passes and the regression tests are committed.

Acceptance criteria

  • Image::ExifTool 13.55's complete upstream suite passes under system Perl, PerlOnJava JVM, and PerlOnJava interpreter, with all test plans complete and no unexplained skips or timeouts.
  • The WriteExif.pl control-flow and transliteration/table-load failures have documented root causes and permanent project regression tests.
  • The final PerlOnJava source passes nice -n 19 make, and the full suite result is recorded in this issue and reflected in #1646.

Related issues

  • Prior ExifTool support and 13.50 suite result: #93.
  • Overall CPAN release qualification: #1646.
主要語言
Perl
星號
65
分支
8
平均合併
6 小時 33 分鐘
30 天內合併 PR
178

環境準備

  • 提供 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

fglock/PerlOnJava 的其他 Issue

查看 fglock/PerlOnJava 的全部 Issue

相似的 Issue

更多 Perl Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。