Browser: keep drag input with its page and refuse lost-channel settlement

未關閉
  • 哪裡不對？
#482 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
javascript, rust
領域
backend, testing

研究方向

Start with capsules/browser/browser/browser-input-surface.js:335-460, then trace the ownership capture at browser.js:1609 and the ordering barrier at browser.js:1670; compare the channel handling with browser-remote-display.js:1384 and the caller at browser.js:1735-1741. Add regression cases at the real callback boundaries for the listed ownership and disconnect/reconnect transitions. Done means those cases refuse or retire unsafe input, and the installed Mac journey passes on the signed candidate.

由索引模型根據 Issue 內容生成。

描述

User impact

An active mouse drag can continue on a replacement Browser page. A related ordering check can report success after the input channel disconnects, allowing a later Runtime input to proceed without proof that the earlier selection arrived.

Found in the latest local 0.8.0 train input changes during #93's audit. Proposed priority: P1 for page ownership, P2 for the lost-channel ordering case; triage before freezing the Browser candidate under #87.

Exact candidate and evidence

Candidate 460b1888d344f52cebd1c25866be88ff4085f035, tree 17aeaf23c640e2dec8f653fd16f3771f95a55b9c. It is local and unpublished. Two reviewers independently repeated deterministic in-memory fixtures against its actual JavaScript. These are source-level reproductions, not installed media proof.

Active drag changes owner

capsules/browser/browser/browser-input-surface.js:335-460 stores pointer and drag state without the originating page/generation. A queued animation-frame move and direct release use the page current when the callback runs. browser.js:1609 captures ownership at that later invocation.

Fixture: pointerdown at x=100 on old page; queue pointermove x=120; replace current page before the animation frame; flush frame; pointerup x=140.

Both runs produced:

[
  {"page":"old","type":"mouse","x":100,"y":100,"buttons":1},
  {"page":"replacement","type":"mouse","x":120,"y":100,"buttons":1},
  {"page":"replacement","type":"mouse","x":140,"y":100,"buttons":0}
]

Expected: later input stays bound to the original gesture owner or is retired. It cannot become a new page's gesture.

Disconnect is treated as completed drain

browser.js:1670 waits on buffer amount and elapsed time without binding the channel identity/open state. The real display getter returns zero when the channel is removed (browser-remote-display.js:1384, close at :281). The caller continues after its page check (browser.js:1735-1741); channel reconnect can occur without changing page identity.

Fixture: bufferedAmount=64; disconnect after 20 ms and return buffer=0. The helper resolved with the channel closed:

{"settled":true,"channelOpen":false,"elapsedMs":175}

The separate reviewer observed 180 ms. Elapsed time is incidental; successful settlement on a closed channel is the finding.

Acceptance

  • Capture gesture page/session/generation at pointerdown; retire queued callbacks when ownership ends.
  • Release the old gesture through its own valid owner, or terminate it without sending to a replacement.
  • Cover page replacement, close, navigation, blur, pointer capture loss and a fresh gesture after retirement.
  • Bind the input ordering barrier to the actual channel/generation and distinguish confirmed drain from disconnect/unknown delivery.
  • Cover pending bytes then disconnect/reconnect with the same page ID; later input must receive a clear refusal/recovery outcome.
  • Add regression cases using the real source callback boundaries, then run the installed Mac selection/paste/close/reconnect journey on the signed candidate.

Existing input/order tests and the overall 1,819-test behaviour suite pass; these transitions are absent from that evidence. Coordinate with draft PR #421 (deferred wheel/touch ownership), #439 (adapter uncertainty) and #87. This issue owns the new mouse-drag and datachannel-barrier slice; it does not duplicate those broader tasks. The exact no-file reproduction commands are retained in the audit's local evidence packet and can become the regression fixtures.

主要語言
Rust
星號
6
分支
2
平均合併
1 天 3 小時
30 天內合併 PR
42

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

elastos/elastos-runtime 的其他 Issue

查看 elastos/elastos-runtime 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。