A join on namesake secondary attributes raises the stale-`~lineage` error on a freshly declared schema
維護者通常 4 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 82/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- mysql, python
研究方向
Start with the None branch in condition.py:271-284, then compare lineage handling in table.py:247-276, lineage.py:366-367, and schemas.py:321. Run the provided reproduction on a fresh schema to confirm native secondary and computed attributes incorrectly trigger the stale-lineage error. Add or update focused tests for joins on namesakes, including .proj() cases; the issue is done when these joins report the appropriate non-homologous error without suggesting rebuild_lineage().
由索引模型根據 Issue 內容生成。
描述
Summary
On a schema declared entirely by the current release, a join on two tables that each declare a secondary attribute with the same name raises the stale-lineage error:
Cannot join on attribute `input_hash`: lineage missing on one side (None vs None). This usually indicates a stale `~lineage` entry from an older DataJoint version or an incomplete declare. Run `schema.rebuild_lineage()` ...
Nothing is stale. ~lineage holds a row for every primary-key and foreign-key attribute. A native secondary attribute has no lineage by design, so its lineage is None on both sides. schema.rebuild_lineage() writes the same rows, and the error persists. Computed attributes of two projections raise the same error. The message tells users to repair a healthy schema, with a repair that cannot change the outcome.
The None branch in assert_join_compatibility (condition.py:271-284, added in #1467 for #1454) treats any None lineage as a missing ~lineage row. But None is also the lineage of every native secondary attribute and every computed attribute: Table._populate_lineage (table.py:247-276) and rebuild_schema_lineage (lineage.py:366-367) write rows only for primary-key and foreign-key attributes. The check at decoration (schemas.py:321) already makes this distinction, since it treats None as a missing row only for primary-key attributes.
Reproduction
DataJoint 2.3.5.dev8 (master, a00b89f5), MySQL 8.0.46, Python 3.11, on a new schema:
import datajoint as dj
schema = dj.Schema("scratch_lineage_secondary")
@schema
class Image(dj.Manual):
definition = """
image_id : int32
"""
@schema
class Segmentation(dj.Manual):
definition = """
-> Image
---
input_hash : varchar(64)
cell_count : int32
"""
@schema
class Profile(dj.Manual):
definition = """
-> Image
---
input_hash : varchar(64)
mean_area : float32
"""
print("~lineage:", schema.connection.query("SELECT * FROM `scratch_lineage_secondary`.`~lineage` ORDER BY 1").fetchall())
print("input_hash lineage:", Segmentation.heading["input_hash"].lineage, Profile.heading["input_hash"].lineage)
for attempt in ("fresh schema", "after rebuild_lineage()"):
try:
Segmentation * Profile
except dj.DataJointError as e:
print(f"{attempt}: {e}")
schema.rebuild_lineage()
try:
Segmentation.proj(n="cell_count + 1") * Profile.proj(n="mean_area * 2")
except dj.DataJointError as e:
print(f"computed attributes: {e}")
Output:
~lineage: (('image', 'image_id', 'scratch_lineage_secondary.image.image_id'), ('profile', 'image_id', 'scratch_lineage_secondary.image.image_id'), ('segmentation', 'image_id', 'scratch_lineage_secondary.image.image_id'))
input_hash lineage: None None
fresh schema: Cannot join on attribute `input_hash`: lineage missing on one side (None vs None). This usually indicates a stale `~lineage` entry from an older DataJoint version or an incomplete declare. Run `schema.rebuild_lineage()` to recompute lineage from current FK definitions. If the lineages are genuinely different, use `.proj()` to rename one of the attributes.
after rebuild_lineage(): Cannot join on attribute `input_hash`: lineage missing on one side (None vs None). This usually indicates a stale `~lineage` entry from an older DataJoint version or an incomplete declare. Run `schema.rebuild_lineage()` to recompute lineage from current FK definitions. If the lineages are genuinely different, use `.proj()` to rename one of the attributes.
computed attributes: Cannot join on attribute `n`: lineage missing on one side (None vs None). This usually indicates a stale `~lineage` entry from an older DataJoint version or an incomplete declare. Run `schema.rebuild_lineage()` to recompute lineage from current FK definitions. If the lineages are genuinely different, use `.proj()` to rename one of the attributes.
Dropping and re-declaring tables, deleting and recomputing rows, and alter() on attribute types all leave ~lineage intact; none of them is needed to reach this error.
Expected behavior
- On a schema declared by this version, a join never raises the stale-lineage error and never suggests
rebuild_lineage(). - A join on namesakes that are not homologous, such as native secondary attributes of two tables or computed attributes of two projections, is refused with an error that names the attribute, says it is not inherited through a foreign key, and suggests
.proj()to rename or exclude it on one side.
Either of two changes would give this:
- Record lineage for native secondary attributes at declaration and in
rebuild_schema_lineage, asschema.table.attribute, as for native primary-key attributes. A table attribute's lineage is thenNoneonly when its row is missing, the stale-lineage message is accurate whenever it appears, and this case gets the existing "different lineages" error. - Keep native secondary attributes without lineage, and raise the stale-lineage message only for attributes that must have a row (a table's primary-key and foreign-key attributes). Every other
Nonegets the non-homologous error.
- 主要語言
- Python
- 星號
- 197
- 分支
- 101
- 平均合併
- 3 天 8 小時
- 30 天內合併 PR
- 28
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
datajoint/datajoint-python 的其他 Issue
-
len() of an expression with an empty primary key generates invalid SQL可能已有人在做 @dimitri-yatsenko 於 5 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 70/100
datajoint/datajoint-python#1581 ·
維護者通常 4 天內回覆
-
dj.Diagram theme: make the font configurable可能已有人在做 @dimitri-yatsenko 於 5 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
datajoint/datajoint-python#1539 · 3 則留言 ·
維護者通常 4 天內回覆
-
enhancement
難度 4/5 3-5 天 新手友好度 55/100
datajoint/datajoint-python#1644 · 1 則留言 ·
維護者通常 4 天內回覆
-
bug
難度 4/5 1-2 天 新手友好度 68/100
datajoint/datajoint-python#1641 ·
維護者通常 4 天內回覆
-
PostgreSQL: renaming an attribute of a dj.U restriction quotes it with backticks可能已有人在做 @mayuriphad 於 5 天前認領。 未關閉bug
難度 3/5 1-2 天 新手友好度 75/100
datajoint/datajoint-python#1638 ·
維護者通常 4 天內回覆
查看 datajoint/datajoint-python 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆
-
namespace operations
難度 1/5 1 小時以內 新手友好度 72/100
EclipseFdn/open-vsx.org#14623 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
developmentseed/titiler-cmr#261 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
andrewyng/openworker#774 ·
維護者通常 1 天內回覆
-
aggfunc未關閉
難度 2/5 1-3 小時 新手友好度 68/100
worldbank/blackmarblepy#160 ·