[coverage] Conformance findings: CLOUDFETCH-019
還沒有人認領這個 Issue。
評估
研究方向
先從 tests/ 下 coverage PR diff 中失敗的測試 test_invalid_client_side_cloudfetch_knob_value_does_not_fail_session_open 開始,然後追蹤 Python 驅動程式對 Thrift CloudFetch 選項的處理。重現非正值和過大的值,並驗證查詢能成功返回至少一列、無效設定不會出現在 OpenSession 中,以及 CloudFetch 仍會下載資料。
由索引模型根據 Issue 內容生成。
描述
Summary
Surfaced by the multi-language coverage fan-out while conformance-testing these SPEC-IDs against databricks/databricks-sql-python. Each finding is committed as an expected-failure (xfail) test in the coverage PR — the test asserts the CORRECT (post-fix) behavior and stays red until THIS driver (databricks/databricks-sql-python) is fixed, then flips green as a tripwire.
Findings
- CLOUDFETCH-019 [thrift]: Thrift backend forwards a non-positive
max_download_threadsunvalidated to ThreadPoolExecutor(max_workers=0), so the first CloudFetch-sized query raisesValueError: max_workers must be greater than 0instead of warning and degrading to the driver default of 10- failing test:
test_invalid_client_side_cloudfetch_knob_value_does_not_fail_session_open(see the coverage PR diff undertests/)
- failing test:
- CLOUDFETCH-019: Thrift backend forwards a non-positive
max_download_threadsunvalidated to ThreadPoolExecutor(max_workers=0), so the first CloudFetch-sized query raisesValueError: max_workers must be greater than 0instead of warning and degrading to the default of 10 — a cosmetic client-side tuning typo breaks querying outright
Reproduce & Expected
CLOUDFETCH-019 — A bad value for a client-side CloudFetch tuning knob must degrade to the driver default, never fail the connection.
Reproduce:
- Same knob as CLOUDFETCH-018 (this driver's client-side CloudFetch knob), set
to a value that is not a positive integer — e.g.
adbc.databricks.cloudfetch.max_chunks_in_memory = "not-a-number". Use "0" or
"-1" where the driver's option surface is typed and cannot carry a
non-numeric string. - The same knob set far above any plausible ceiling — e.g. "100000" (the
reference kernel clamps at 256).
Expected (per the shared spec):
- completes without an exception
- result has at least 1 row(s)
- completes without an exception
- result has at least 1 row(s)
- [thrift]
OpenSessionrequestconfiguration.cloudfetch_max_chunks_in_memoryis absent - [sea]
CreateSessionrequestsession_confs.cloudfetch_max_chunks_in_memoryis absent - full assertion contract:
result:
- label: not_a_positive_integer
no_exception: true
- label: not_a_positive_integer
row_count_min: 1
- label: above_maximum
no_exception: true
- label: above_maximum
row_count_min: 1
protocol:
thrift:
- label: not_a_positive_integer
request_field:
method: OpenSession
path: configuration.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
sea:
- label: not_a_positive_integer
request_field:
operation: CreateSession
path: session_confs.cloudfetch_max_chunks_in_memory
present: false
- label: not_a_positive_integer
cloud_downloads_min: 1
Context
- The behavior was first fixed in a DIFFERENT driver — reference PR: https://github.com/databricks/databricks-odbc/pull/231 — which seeded the shared language-neutral spec. This issue tracks the same conformance gap in databricks/databricks-sql-python; the reference PR is for cross-referencing the intended behavior, NOT a change to this repo.
- Coverage PR carrying the reproducing xfail test(s): https://github.com/databricks/databricks-driver-test/pull/1242
- 主要語言
- Python
- 星號
- 233
- 分支
- 152
- 平均合併
- 21 小時 5 分鐘
- 30 天內合併 PR
- 10
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
databricks/databricks-sql-python 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 76/100
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 72/100
-
難度 2/5 1-3 小時 新手友好度 84/100
查看 databricks/databricks-sql-python 的全部 Issue
相似的 Issue
-
bug confirmed issue
難度 2/5 1-3 小時 新手友好度 75/100
open-webui/open-webui#30750 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 75/100
-
enhancement
難度 2/5 1-3 小時 新手友好度 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
-
good first issue
難度 1/5 1 小時以內 新手友好度 90/100