Share the GPU smoke test between OptimalControl and OptimalControlScalarized
維護者通常 1 天內回覆
@ocots 已經在處理了。
開始於 2026年11月10日。
評估
這個 Issue 還沒有評估資料。
描述
Context
Follow-up of #441, to be done once its phase C (shared OptimalControl / OptimalControlScalarized runners in test/common/optimalcontrol_tests.jl) is merged.
The two GPU smoke files differ only by the backend and the configuration group:
test/suite/GPU/test_smoke_optimalcontrol.jl(GPU_CONFIGS.OptimalControl, entry functiontest_smoke_optimalcontrol)test/suite/GPU/test_smoke_scalarized.jl(GPU_CONFIGS.OptimalControlScalarized, entry functiontest_smoke_scalarized)
Everything else is identical: the CUDA_FUNCTIONAL branch with the visible skip (TST6), the solve with SMOKE_GRID and SMOKE_MAX_ITER, and the finite-objective check.
Goal
Factor the GPU smoke test into one shared implementation parameterized by the backend, as #441 does for test_problem, test_smoke and test_convergence, without changing the behavior on a CPU runner or on a GPU runner.
Proposed approach
- In
test/common/optimalcontrol_tests.jl, or in a newtest/common/gpu_tests.jlif the module must not loadMain.TestCapabilitiesin CPU environments, addtest_smoke_gpu(backend). The configurations come fromgetfield(Main.TestConfigs.GPU_CONFIGS, Main.TestStatus.modeling(backend)). - Keep the two test files, each as a thin wrapper with its own module and entry function (
TST1), so that the report names (test_smoke_optimalcontrol <label>,test_smoke_scalarized <label>) do not change. - Keep
TST6: no earlyreturnin a@testset,Test.@test_skipwithout a functional device, andtest_contract.jlstill fails loudly on akktoroccidatarunner without a device. - Check that
tools/ci/scope.py(Repository.includers) still finds the includers of the new shared file;GPUis an opt-in environment, so it never enters the automatic scope. Add a case totools/ci/test/test_scope.pyif a new file is created. - Update
test/README.md("GPU tests") if the layout changes.
Out of scope
- The GPU configurations and the solvers (
GPU_CONFIGSintest/common/configs.jl). - Running the GPU tests in CI: they need the
run ci kkt-runnerorrun ci occidata-runnerlabel, and a runner with a device.
Checks
- On a CPU machine:
Pkg.test(; test_args=["GPU"])reports the same tests asBroken(skipped) as before. - On a GPU runner: the same solves run and the same lines appear in the report.
- 主要語言
- Julia
- 星號
- 13
- 分支
- 1
- 平均合併
- 3 小時 36 分鐘
- 30 天內合併 PR
- 57
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
control-toolbox/OptimalControlProblems.jl 的其他 Issue
-
Rationalize JuMP and comparison test suites: separate generic transcription unit tests from per-problem modeling checks可能已有人在做 @ocots 於 2 天前認領。 未關閉
control-toolbox/OptimalControlProblems.jl#441 · 2 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
[Cron/Doc] ModelingToolkit convergence cron, trajectories, and documentation (#308)可能已有人在做 @ocots 於 2 天前認領。 未關閉documentation feature
control-toolbox/OptimalControlProblems.jl#439 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
cron-convergence
難度 4/5 3-5 天 新手友好度 32/100
control-toolbox/OptimalControlProblems.jl#436 · 3 則留言 ·
維護者通常 1 天內回覆
-
cron-failure
難度 4/5 3-5 天 新手友好度 35/100
control-toolbox/OptimalControlProblems.jl#435 · 5 則留言 ·
維護者通常 1 天內回覆
-
[Dev] Expose the duals of the JuMP path, boundary and box constraints, aligned with signs.md可能已有人在做 @ocots 於 2 天前認領。 未關閉
control-toolbox/OptimalControlProblems.jl#430 · 已指派 1 人 ·
維護者通常 1 天內回覆
查看 control-toolbox/OptimalControlProblems.jl 的全部 Issue
相似的 Issue
-
documentation priority: high
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 90/100
epiforecasts/BVDOutbreakSize#1260 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
TuringLang/Turing.jl#2917 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 88/100
-
Validate UserDemand return_factor可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 2 天內回覆