Untested branches in telemetry, backend errors, and CLI error paths
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 72/100
研究方向
Start by locating the existing tests for the interfaces in threadmill/backends/base.py and threadmill/backends/redis.py, then inspect threadmill/management/commands/threadmill.py and its command tests. Add coverage for both worker_telemetry paths, the Redis error raises, the invalid-backend and unsupported-queue errors, and KeyboardInterrupt shutdown. Done means these listed branches are exercised and the relevant coverage remains complete.
由索引模型根據 Issue 內容生成。
描述
Deferred from the task-prefetching review (crew run). All four items predate that branch and the branch does not touch them. The review reported them instead of adding tests.
ThreadmillTaskBackend.worker_telemetryhas no test, although every other interface method has one. [threadmill/backends/base.py]RedisTaskBackend.worker_telemetryhas no test for the pub/sub streaming loop and the invalid-payload skip. [threadmill/backends/redis.py]RedisTaskBackendhas no test for theValueErrorof a missingREDIS_URLor for theTaskResultDoesNotExistraise inget_result. [threadmill/backends/redis.py]WorkerCommandhas no test for the invalid-backend and unsupported-queueCommandErrorbranches or for theKeyboardInterruptshutdown path. [threadmill/management/commands/threadmill.py]
The patch of the branch has 100% line and branch coverage. These items are the remaining coverage gaps in the files that the branch touches.
- 主要語言
- Python
- 星號
- 21
- 分支
- 2
- 平均合併
- 12 小時 39 分鐘
- 30 天內合併 PR
- 27
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
相似的 Issue
-
難度 1/5 1 小時以內 新手友好度 80/100
521xueweihan/HelloGitHub#4063 ·
-
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 62/100
Vanilla-OS/apx-gui#112 ·
-
Devstral and Voxtral: section 5 fails in us-east-1 with 400 "Model does not support audio modality"未關閉
難度 2/5 1-3 小時 新手友好度 76/100
aws-samples/sample-per-model-bedrock#409 ·
維護者通常 1 天內回覆
-
DuckDB 2.0 breaks to_pyarrow_batches可能已有人在做 @DG47 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
ibis-project/ibis#12196 ·
維護者通常 1 天內回覆