Flaky test: concurrent CLI redownload times out waiting for the progress log to go away

已關閉
  • 哪裡不對？
#1,120 1 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

維護者通常 1 天內回覆

@EhabY 已經在處理了。

開始於 2026年9月18日。

評估

這個 Issue 還沒有評估資料。

描述

tech-debt

test/unit/core/cliManager.concurrent.test.ts fails intermittently on CI. It passed on attempt 1 of run 35406584668 and failed on attempt 2 of the same commit, in Unit Test (Linux, Electron 37).

FAIL test/unit/core/cliManager.concurrent.test.ts > CliManager Concurrent Downloads > redownloads when version mismatch is detected concurrently
AssertionError: promise resolved "undefined" instead of rejecting
- Expected: Error { "message": "rejected promise" }
+ Received: undefined
 ❯ test/unit/core/cliManager.concurrent.test.ts:102:56

Line 102 is the progress-log half of expectLockFilesRemoved:

await vi.waitFor(async () => {
  await expect(fs.access(binaryPath + ".lock")).rejects.toThrow();
  await expect(fs.access(binaryPath + ".progress.log")).rejects.toThrow();
});

fs.access resolved, so <binary>.progress.log was still on disk when the poll gave up. The test starts three fetchBinary calls, two of which detect the version mismatch and redownload, and Promise.all resolves before every peer has finished releasing its progress log. vi.waitFor defaults to a 1s timeout at a 50ms interval, which a loaded runner can outlast.

#1043 added that polling for this same flake, so the window helps but is not always enough.

Worth considering:

  • Give vi.waitFor an explicit timeout, which is the cheap fix but still time-based.
  • Make the cleanup observable and await it, rather than polling the filesystem.
  • Decide whether the progress log belongs in the assertion at all after a concurrent redownload, since the lock is the part the contract depends on.
主要語言
TypeScript
星號
133
分支
49
平均合併
1 天 7 小時
30 天內合併 PR
26

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

coder/vscode-coder 的其他 Issue

查看 coder/vscode-coder 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。