perf: reduce per-row and per-access overhead in entity and model casting
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 35/100
- Issue 類型
- 重構
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- php
- 領域
- backend, performance
研究方向
Start with DataCaster::castAs() for the cast-type parsing, DataConverter::reconstruct() for the duplicate syncOriginal() call after injectRawData(), and Entity::__get(), __set() and toArray() for the getter/setter lookup. Run the benchmark or the DataCaster, DataConverter and Entity tests before and after each of the three commits. Done means the listed tests pass, including the documented behavior change for entities that override injectRawData(), and the proposal's timing targets hold.
由索引模型根據 Issue 內容生成。
描述
Problem
Loading rows through a model with casts, especially as entities, repeats the same work on every row and every field:
DataCaster::castAs()parses the type string on every cast. For each value it runsstr_starts_with, amatch, apreg_match(),explode/array_map(trim)and atrim, all to turn something like'?int'or'json-array'into a handler key and params. The handler itself often costs less than the parsing.DataConverter::reconstruct()callssyncOriginal()twice for each entity. It callsinjectRawData(), which already callssyncOriginal(), and then callssyncOriginal()again. When attributes hold arrays or objects, each sync normalizes them and runsjson_encode().Entity::__get()and__set()rebuild the getter or setter name on every access. They runstr_replace/ucwords, then make twomethod_exists()calls.toArray()repeats this for every key.
Measurements
PHP 8.3 on macOS, OPcache on, production mode, warm. The test entity has 10 columns, 6 casts (int, ?int, bool, json-array, float, int-bool) and the default $dates.
| Case | Time |
|---|---|
1000 rows → arrays (fromDataSource) |
3.2 ms |
1000 rows → entities (reconstruct) |
6.3 ms |
| 1000 rows → entity with no casts | 2.0 ms |
| Step | Cost |
|---|---|
castAs() for an int field |
0.33 µs |
IntegerCast::get() called directly |
0.07 µs |
syncOriginal() with an array attribute |
1.2 µs per call |
Getter-name build + 2× method_exists() |
~0.1–0.2 µs per access |
__get() on a plain field |
0.46–0.58 µs |
toArray() with 10 keys |
7.6–11 µs |
Proposal
1. Cache parsed cast types (DataCaster)
Add a private static cache keyed by the type string. It stores only the parsed result: base type, params and the nullable flag.
- Handlers are not cached. Each instance still looks up the handler in its own
$castHandlers, so instances with different custom handlers keep working. - The non-strict
'nullable'param is still added after the cache lookup. - An unknown type still throws on every call.
- Why static: each entity has its own
DataCaster, so a per-instance cache would rarely get a hit. The parse depends only on the string, so the cache is safe across Worker Mode requests. It also can't grow without limit, because type strings come from code, not from input.
2. Sync originals once (DataConverter::reconstruct())
Remove the second syncOriginal() call. injectRawData() already syncs.
3. Per-class getter/setter map (Entity)
On the first access, build a map of each entity class's get*, _get*, set* and _set* methods using ReflectionClass::getMethods(), with lowercase keys. Lookups then replace the two method_exists() calls.
- Bounded memory: the map depends on the class, not on input. Keys passed to
fill()from request data can't make it grow. - Same lookup rules: lowercase keys match PHP's case-insensitive method names. Reflection includes private methods, so results match
method_exists()exactly.
Estimated gains
Fixes 1 and 2 bring 1000 entities from about 6.3 ms to about 3.6 ms, roughly 40% faster. Array results drop from about 3.2 ms to about 1.7 ms. Fix 3 removes about 25–35% of the cost of each __get()/__set() call, which matters most in toArray() and in views that read many properties.
These are estimates from micro-benchmarks, not from the final code.
Behavior changes (4.8)
Only fix 2 changes behavior. If an app entity overrides injectRawData() without calling syncOriginal(), reconstruct() no longer syncs for it. Such an entity will report every field as changed after a find(), and save() will write all columns. That override is already broken for any other caller of injectRawData(). This will be listed in the v4.8.0 changelog under "Behavior Changes", with a note in upgrade_480.rst saying overrides must call syncOriginal().
Fixes 1 and 3 change no behavior.
Not changing
- Lazy
DataCastercreation in theEntityconstructor (~5%). Subclasses can read the protected$dataCasterproperty directly and would getnull. - The non-strict
is_subclass_of()checks and thetoArray()filter closure. Each costs under 2%.
Plan
One PR with three commits, one per fix. Fix 2 also includes the changelog and upgrade-guide entries.
Tests
DataCasterTest:- Two instances with the same type string but different custom handlers each call their own handler.
- Non-strict
?typestill addsnullable, and strict mode doesn't. - An unknown type throws on every call.
DataConverterTest:- A reconstructed entity reports
hasChanged() === false. - An entity that overrides
injectRawData()without syncing now reports changes. This test documents the behavior change.
- A reconstructed entity reports
EntityTest:- Getter lookup ignores case.
_getXwins overgetX.- Inherited getters are found.
- A private getter behaves as it does today.
- Maps are kept separate for each class.
Related
- #10615, #10616, #10617
- 主要語言
- PHP
- 星號
- 6k
- 分支
- 2k
- 平均合併
- 1 天 22 小時
- 30 天內合併 PR
- 59
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
codeigniter4/CodeIgniter4 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
codeigniter4/CodeIgniter4#10616 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 62/100
codeigniter4/CodeIgniter4#10617 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 25/100
codeigniter4/CodeIgniter4#10615 · 1 則留言 ·
維護者通常 1 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 48/100
codeigniter4/CodeIgniter4#10589 · 3 則留言 ·
維護者通常 1 天內回覆
-
dev
難度 5/5 一週以上 新手友好度 25/100
codeigniter4/CodeIgniter4#10427 · 5 則留言 ·
維護者通常 1 天內回覆
查看 codeigniter4/CodeIgniter4 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 2 天內回覆
-
backend bug
難度 2/5 1-3 小時 新手友好度 76/100
-
bug
難度 1/5 1 小時以內 新手友好度 85/100
-
難度 2/5 1-3 小時 新手友好度 63/100
smarty-php/smarty#1215 ·