ActiveStorage: Using upload_preset with folder creates invalid image links
@const-cloudinary 已經在處理了。
開始於 2020年8月31日。
評估
這個 Issue 還沒有評估資料。
描述
Describe the bug in a sentence or two.
I use different upload presets in my app which default to a different folder each (e.g. "production").
storage.yml:
cloudinary:
service: Cloudinary
upload_preset: <%= ENV['CLOUDINARY_UPLOAD_PRESET'] %>
What the SDK cannot know is that the upload preset is configured to upload files into a specified folder. Therefore, when it generates links to the uploaded images, they miss the folder part and result in dead links.
Issue Type
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[X] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Other (Specify)
Steps to reproduce
- Configure an upload preset using an upload folder (e.g. "test") in the Cloudinary administration interface.
- Configure Rails' storage.yml to use
upload_preset: testwith the configured cloudinary service (see above). - Upload a file attachment via Rails and ActiveStorage, then use url_for() to generate a link to that image.
- Observe: the link misses the "test"-folder part.
Operating System
[ ] Linux
[ ] Windows
[ ] OSX
[X] All
Environment and Libraries
Cloudinary Ruby SDK version - 1.13.2
Ruby Version - 2.6.6
Rails Version - 5.2.4.1
ActiveStorage - 5.2.4.1
Suggestion
We could use the Cloudinary API to fetch the configured upload folder for the specified upload preset. I'm not sure that's a good idea - we might end up calling the API every time someone uses an upload_prefix.
We may also introduce another storage.yml option "preset_folder" to be used together with upload_preset only.
I need this fixed quite urgently so I'm absolutely willing to submit a PR. Any hints from the maintainers would be totally helpful!
- 主要語言
- Ruby
- 星號
- 420
- 分支
- 282
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
cloudinary/cloudinary_gem 的其他 Issue
-
難度 4/5 3-5 天 新手友好度 55/100
cloudinary/cloudinary_gem#597 · 1 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 52/100
cloudinary/cloudinary_gem#591 · 3 則留言 ·
-
難度 3/5 1-2 天 新手友好度 45/100
cloudinary/cloudinary_gem#582 · 1 則留言 ·
-
404's when fetching .eml files (from Action Mailbox)可能重新可做 @rnamba-cloudinary 於 400 天前認領，目前沒有進行中的 PR。 未關閉
難度 4/5 3-5 天 新手友好度 30/100
cloudinary/cloudinary_gem#581 · 1 則留言 ·
-
BlobKey, MirrorService and Sidekiq 8 are incompatible可能重新可做 @const-cloudinary 於 541 天前認領，目前沒有進行中的 PR。 未關閉
cloudinary/cloudinary_gem#573 · 3 則留言 · 已指派 1 人 ·
查看 cloudinary/cloudinary_gem 的全部 Issue
相似的 Issue
-
bug
難度 1/5 1 小時以內 新手友好度 88/100
yegor256/mailanes#361 · 1 則留言 ·
維護者通常 1 天內回覆
-
Property accounts have no notes field可能已有人在做 @arnaurodondev 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 82/100
we-promise/sure#5057 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆
-
area: ci benchmark build developer-experience difficulty: easy dx enhancement github-actions good first issue hacktoberfest help wanted performance quality rank: 8 kyu ruby tech: ruby
難度 1/5 1 小時以內 新手友好度 82/100
flisk-sh/flisk-labs#22 ·
-
1.severity: security
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆