New Relic agent is installed but never attached to the JVM (v5.0.4 and later)
維護者通常 1 天內回覆
評估
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 停滯
- 領域
- build-system, cloud
研究方向
Start with the New Relic framework code in new_relic.go and the 9.x entries in manifest.yml, which show the bare agent jar with a .zip name. The fix that matters is upstream in buildpacks-ci, where the watcher downloads the wrong artifact, and an open pull request (#714) already exists for this. Done means an integration test that checks newrelic.jar and the license key in the running JVM's arguments, and passes for New Relic 9.x.
由索引模型根據 Issue 內容生成。
描述
With a newrelic service binding, staging succeeds and the log says the agent is installed, but the running JVM has no New Relic -javaagent and no license key. The only hint is a warning during finalize:
WARNING Failed to finalize framework New Relic Agent: failed to locate newrelic.jar: newrelic.jar not found in /tmp/contents.../deps/0/new_relic_agent
Datadog and SkyWalking bound to the same app are present in the JVM arguments, New Relic is not.
How it was found: while writing an integration test that binds several agents at once (New Relic, Datadog, SkyWalking) and checks the running JVM's arguments instead of only the staging log. This is part of an upcoming improvement of the integration tests, so that every framework is verified in the running JVM. So far 17 of the 23 frameworks that attach an agent (-javaagent or -agentpath) have been checked this way: 16 pass and New Relic is the only one that fails. The other 6 are not checked: AppDynamics, Checkmarx, Introscope and Riverbed are skipped because they need vendor credentials, and Seeker and Java Memory Assistant have no test.
Cause: new_relic.go expects newrelic/newrelic.jar inside the unpacked dependency, as in the vendor distribution newrelic-java-<version>.zip (used up to 8.15.0). The 9.x dependencies in manifest.yml (9.2.0 to 9.5.0, first shipped in v5.0.4) are the bare agent jar with a .zip name. libbuildpack unpacks .zip dependencies, so the jar is exploded and no newrelic.jar remains.
The pipeline produced this: the newrelic watcher in buildpacks-ci downloads newrelic-agent-<version>.jar (cloudfoundry/buildpacks-ci#633), while the binary-builder recipe names the artifact newrelic-java-<version>.zip (cloudfoundry/binary-builder#111). The recipe never opens the file, so the .zip extension comes from its expected file name, not from the content.
Fix: make the watcher download newrelic-java-<version>.zip. The distribution exists for 9.2.0, 9.4.0 and 9.5.0 and contains newrelic/newrelic.jar (the same 41,319,404 bytes as the published bare jar for 9.5.0). I plan to open that PR in buildpacks-ci, plus an integration test here that asserts newrelic.jar and the license key in the running JVM's arguments. The corrected artifact is published when the pipeline next builds a New Relic version; I have not checked whether 9.5.0 can be rebuilt on demand.
Why it went unnoticed: the integration test only asserts New Relic Agent in the staging log, which is printed before the failing step. A failed Finalize is only a warning, while Supply failures are fatal. Making Finalize failures fatal is a separate behaviour change worth discussing.
v4: the Ruby buildpack used a bare jar (download_jar) and added -javaagent directly, so this worked.
- 主要語言
- Go
- 星號
- 455
- 分支
- 2.5k
- 平均合併
- 22 小時 9 分鐘
- 30 天內合併 PR
- 69
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
cloudfoundry/java-buildpack 的其他 Issue
-
難度 5/5 一週以上 新手友好度 12/100
cloudfoundry/java-buildpack#1549 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 25/100
cloudfoundry/java-buildpack#1521 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 10/100
cloudfoundry/java-buildpack#1469 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 55/100
cloudfoundry/java-buildpack#1377 · 5 則留言 ·
維護者通常 1 天內回覆
-
難度 3/5 1-2 天 新手友好度 52/100
cloudfoundry/java-buildpack#1364 ·
維護者通常 1 天內回覆
查看 cloudfoundry/java-buildpack 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 84/100
github/github-mcp-server#3865 ·
維護者通常 2 天內回覆
-
kind/features
難度 2/5 1-3 小時 新手友好度 75/100
TencentBlueKing/bk-nodemgr#4017 ·
維護者通常 1 天內回覆
-
ssa: wait errors drop the kstatus message, so health check failures don't say why可能已有人在做 @schdief 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
equinor/radix-operator#2066 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 67/100
microsoft/terraform-provider-msgraph#188 · 1 個 reaction ·
維護者通常 1 天內回覆