Mosaic reconnect loses its error when OAuth navigation fails

未關閉
#10,118 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
1-2 天
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
react, typescript

研究方向

Start by reading the connected-account reconnect flow in projectConnectedAccounts, usePendingAction, and the controller mapping mentioned in the issue; inspect the existing tests near PR #10086 for the relevant setup. Add regression coverage for error transfer across account recreation and reauthorization, redirect hold, and retry behavior. Done when both reproduced navigation-failure paths show the error and retry remains available.

由索引模型根據 Issue 內容生成。

描述

Connected-account reconnect loses its error when navigation fails.

Reproduced both paths in Chromium against the latest-main-rebased PR #10086 branch.

  1. Seed a disconnected Google external account with an unverified google_one_tap verification and external_account_missing_refresh_token, then click Manage Google and Reconnect.
  2. Alternatively, seed a verified Google account and render the section with additionalOAuthScopes={{ google: ['calendar'] }}, then click Manage Google and Reconnect.
  3. Make clerk.navigate reject with Error("Navigation failed").

Expected the row or replacement Connect action to show "Something went wrong. Please try again." Both paths permit another connection but render no error. An unconditional findByText assertion fails for both cases. Connect does show the error.

The successful Frontend API response makes the account unverified without a verification error. projectConnectedAccounts hides such accounts and offers a Connect action instead. usePendingAction records the failure under the original account ID. The controller maps reconnectError to account rows with that ID, but the row has disappeared. Recreation also replaces the account with a new ID.

Keep this source fix separate from PR #10086, which only restructures tests. Cover error transfer across account recreation and reauthorization, redirect hold, and retry behavior with regression tests.

主要語言
TypeScript
星號
1.8k
分支
484
平均合併
1 天 7 小時
30 天內合併 PR
350

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

clerk/javascript 的其他 Issue

查看 clerk/javascript 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。