Let a script hold a device claim while it runs simctl install or simctl launch itself

已關閉
  • 哪裡不對？
#3,263 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@thymikee 已經在處理了。

開始於 2026年10月16日。

  • #3738 來自 @thymikee —— 未關閉

評估

難度
5/5
預估耗時
一週以上
新手友好度
38/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
ios, typescript
領域
cli, mobile-dev

研究方向

Start by reading the CLI implementations of install, boot and shutdown to understand how they take and release transient-exclusive claims, then compare that with the open/close session lifecycle. Decide which of the three proposed approaches best fits the stated requirement; done means a script can hold a claim while its simulator mutation runs, and the claim is released when that work ends without the unwanted session side effects.

由索引模型根據 Issue 內容生成。

描述

enhancement in-progress ready-for-agent

Seen in 0.21.15, macOS, iOS simulators.

Problem

Our dev scripts install and relaunch a dev client on an iOS simulator with xcrun simctl install and xcrun simctl launch --terminate-running-process. Before each call, they read the claim file in ~/.agent-device/device-claims/ and refuse when another session holds the device.

Between that check and the simctl call, an agent-device client (an e2e run, or an IDE device panel) can take the claim. The install or relaunch then interrupts that session. The window is short, but a check that only our scripts honor cannot close it. The claim must come from agent-device.

What exists in 0.21.15, and why it does not fit

  • device status|release only inspects or releases claims. No command takes one.
  • install, boot and shutdown take a transient-exclusive claim, but only for their own work. agent-device cannot run our simctl command under that claim.
  • open --session S --platform ios --udid U with no app holds a session claim until close --session S. As a reservation, it has these side effects:
    • it starts a daemon in the state dir;
    • keepHot can start xcodebuild build-for-testing for the runner in the background;
    • on a simulator that is not booted, it boots it and runs open -a Simulator;
    • if the script crashes before close, the claim stays held while the daemon lives.
  • takeover needs a remote lease, so it does not apply to a local simulator.

Proposal (any one is enough)

  1. agent-device exec --platform ios --udid U -- <command...>: take a transient-exclusive claim, run the child, and release the claim when the child exits. The claim owner is the exec process, so a crash of the child or of agent-device frees the claim.
  2. agent-device device claim --udid U and device release --udid U --session S: take a claim whose owner is the calling process (or one with a TTL or heartbeat). No daemon, no boot, no runner prewarm, no session record.
  3. open --claim-only: the current open with no app, but without the boot, open -a Simulator and runner prewarm.

Option 1 fits our use best. The claim lasts exactly as long as the mutation, and nothing leaks.

Current workaround

We read the claim file right before each simctl call. That narrows the window but does not close it.

Related: #2161 (workspace-scoped device pinning).

主要語言
TypeScript
星號
5.3k
分支
377
平均合併
14 小時 24 分鐘
30 天內合併 PR
675

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

callstack/agent-device 的其他 Issue

查看 callstack/agent-device 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。