`lpad` and `rpad` with a literal length above `i32::MAX` error on a NULL string or fill
維護者通常 1 天內回覆
評估
研究方向
從datafusion/functions/src/unicode/pad.rs開始,比較純量長度快速路徑與陣列路徑的NULL處理。檢查string_literal.slt中現有的案例,以及issue中提到的相關split_part修正。完成條件是:對於字串為NULL或填充字串為NULL的資料列,lpad和rpad在長度字面值過大時回傳NULL;對於相關引數皆非NULL的資料列,仍然報錯。
由索引模型根據 Issue 內容生成。
描述
Describe the bug
lpad(s, n) on a row where s is NULL and n is above i32::MAX errors when n is a literal, and returns NULL when n comes from a column. A NULL fill behaves the same, and so does rpad. The fast path for a scalar length rejects a length above i32::MAX before it looks at any row. The array path skips rows where any argument is NULL before it checks the length, so it errors only on a row whose string and fill are both non-NULL.
To Reproduce
-- Literal length: the fast path
SELECT lpad(s, 2147483648) AS r FROM (VALUES (NULL::text)) AS t(s);
-- Execution error: lpad requested length 2147483648 too large, maximum allowed length is 2147483647
-- The same row with the length from a column: the array path
SELECT lpad(s, n) AS r FROM (VALUES (NULL::text, 2147483648)) AS t(s, n);
-- NULL
-- A NULL fill with a literal length
SELECT lpad(s, 2147483648, f) AS r FROM (VALUES ('a', NULL::text)) AS t(s, f);
-- Execution error: lpad requested length 2147483648 too large, maximum allowed length is 2147483647
-- The same row with the length from a column
SELECT lpad(s, n, f) AS r FROM (VALUES ('a', 2147483648, NULL::text)) AS t(s, n, f);
-- NULL
The same four queries with rpad give the same results.
Expected behavior
All four return NULL, as the array path does. string_literal.slt already expects NULL for a NULL string or fill with a literal length in range, and #27352 made split_part's fast path return NULL in the same situation (#27276).
Could the fast path skip a length above i32::MAX, as it already skips one above MAX_SCALAR_TARGET_LEN, instead of returning the error? The array path would then return the error for the first row whose string and fill are non-NULL, and NULL for the other rows.
Additional context
Property-based tests found this on main at e2dc8b048b: one row of a call with an array of lengths returned NULL, and the same row called with every argument as a scalar returned the error. The reproduction runs on main at e2dc8b048b. The check in the fast path came with #20657 and moved to pad.rs in #26367.
- 主要語言
- Rust
- 星號
- 9.6k
- 分支
- 2.6k
- 平均合併
- 3 天 5 小時
- 30 天內合併 PR
- 352
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
apache/datafusion 的其他 Issue
-
`verify-release-candidate.sh` version check doesn't catch `-dev` versions and is skipped on macOS可能已有人在做 @vinycalves 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
apache/datafusion#27563 · 1 則留言 ·
維護者通常 1 天內回覆
-
`MoveTowardsLeafNodes` placement implies speculative evaluation, but the docs don't say so可能已有人在做 @Inf1mum 於 1 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 75/100
apache/datafusion#27487 · 3 則留言 ·
維護者通常 1 天內回覆
-
Window constructors panic when the expression list is empty可能已有人在做 @abp002 於 4 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
apache/datafusion#27315 · 3 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 76/100
apache/datafusion#27094 · 1 則留言 ·
維護者通常 1 天內回覆
-
Substrait consumer doesn't recognise `shift_left` / `shift_right` from functions_arithmetic.yaml可能已有人在做 @jonasHanhan 於 15 天前認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 76/100
apache/datafusion#27059 ·
維護者通常 1 天內回覆
查看 apache/datafusion 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
tinystream-dev/tinystream#132 ·
-
contract good first issue testing
難度 2/5 1-3 小時 新手友好度 72/100
Emmyt24/nova-launch#2436 ·
維護者通常 1 天內回覆