`ROLLUP`/`CUBE`/`GROUPING SETS`: an element starting with `(` is always read as a sublist (`(SELECT 1)` rejected, `((b))` displayed as `(b)`)
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with parse_group_by_expr in the parser, which calls parse_tuple(true, true) on each ROLLUP, CUBE and GROUPING SETS element, and with the Display code for Rollup and Cube in the AST. Reproduce the three queries from the issue under PostgreSqlDialect, including SELECT a FROM t GROUP BY ROLLUP (a, ((b))). Done means the (SELECT 1) cases parse and the ((b)) case round-trips without losing its nesting.
由索引模型根據 Issue 內容生成。
描述
Each element of ROLLUP, CUBE and GROUPING SETS treats a leading ( as its own sublist delimiter, which breaks parenthesized expressions:
SELECT a FROM t GROUP BY ROLLUP (a, (SELECT 1))
-> sql parser error: Expected: ), found: 1 at Line: 1, Column: 45
SELECT a FROM t GROUP BY CUBE (a, (SELECT 1))
SELECT a FROM t GROUP BY GROUPING SETS (a, (SELECT 1))
-> same error
SELECT a FROM t GROUP BY ROLLUP (a, ((b)))
-> displays as: SELECT a FROM t GROUP BY ROLLUP (a, (b))
-> reparses as ROLLUP (a, b): element [Nested(b)] becomes [b]
PostgreSQL 18 runs SELECT a FROM t GROUP BY ROLLUP (a, (SELECT 1)). Its docs: "The individual elements of a CUBE or ROLLUP clause may be either individual expressions, or sublists of elements in parentheses" (https://www.postgresql.org/docs/current/queries-table-expressions.html#QUERIES-GROUPING-SETS). The second case changes only the AST, since PostgreSQL treats ((b)) and (b) the same.
parse_group_by_expr parses each element with parse_tuple(true, true), which consumes the ( of (SELECT 1) and then reads SELECT as an identifier. Display for Rollup/Cube writes a one-element set without its own parentheses, so [Nested(b)] prints as (b).
Tested with PostgreSqlDialect on main ce12f1f6 (also 0.63.0 and 0.58.0).
Found with a property-based fuzzer (round trip check); I used AI assistance for triage and verified every case above.
- 主要語言
- Rust
- 星號
- 3.5k
- 分支
- 805
- 平均合併
- 2 天 3 小時
- 30 天內合併 PR
- 116
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
apache/datafusion-sqlparser-rs 的其他 Issue
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 76/100
apache/datafusion-sqlparser-rs#2862 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 75/100
apache/datafusion-sqlparser-rs#2861 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 77/100
apache/datafusion-sqlparser-rs#2858 ·
維護者通常 1 天內回覆
-
PostgreSQL
難度 2/5 1-3 小時 新手友好度 82/100
apache/datafusion-sqlparser-rs#2857 ·
維護者通常 1 天內回覆
-
DuckDB Prolific Author
難度 2/5 1-3 小時 新手友好度 70/100
apache/datafusion-sqlparser-rs#2807 ·
維護者通常 1 天內回覆
查看 apache/datafusion-sqlparser-rs 的全部 Issue
相似的 Issue
-
area:schema documentation
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
ElectronicWave/Elemental#252 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
dekobon/big-code-analysis#1887 ·
維護者通常 1 天內回覆
-
Shell中文符号输入异常未關閉bug
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 82/100
維護者通常 1 天內回覆