[Java][FlightSQL] JDBC driver returns pre-1970 dates one day late when a Calendar is supplied
還沒有人認領這個 Issue。
評估
研究方向
先從 DateTimeUtils.getTimestampValue(long) 開始,接著檢查 ArrowFlightJdbcDateVectorAccessor.getDate(Calendar) 和現有的負日期測試。使用日曆偏移重現 1950-06-01 01:00:00 UTC 的情況,並驗證 epoch-day 和時間計算使用相符的日界線。提供日曆時,1970 年之前的日期能夠返回正確的日期,且回歸測試通過,即表示完成。
由索引模型根據 Issue 內容生成。
描述
Describe the bug, including details regarding any error messages, version, and platform.
DateTimeUtils.getTimestampValue(long) splits epoch milliseconds into an epoch day and a time within that day. The old code used / and %:
public static Timestamp getTimestampValue(long millisWithCalendar) {
long milliseconds = millisWithCalendar;
if (milliseconds < 0) {
// LocalTime#ofNanoDay only accepts positive values
milliseconds -= ((milliseconds / MILLIS_PER_DAY) - 1) * MILLIS_PER_DAY;
}
return Timestamp.valueOf(
LocalDateTime.of(
LocalDate.ofEpochDay(millisWithCalendar / MILLIS_PER_DAY),
LocalTime.ofNanoOfDay(TimeUnit.MILLISECONDS.toNanos(milliseconds % MILLIS_PER_DAY))));
}
Both operators round toward zero. For dates before 1970, the code adjusted the negative remainder because LocalTime.ofNanoOfDay rejects it. It did not adjust the epoch day. When the input was negative and not exactly midnight, the day and remainder then referred to different days. The date came back one day late.
For example, -618102000000 ms is 1950-06-01 01:00:00 UTC. Division by 86400000 truncates to -7153, which is 1950-06-02. The remainder is 3600000 ms, or 01:00. The old result was 1950-06-02 01:00:00. Math.floorDiv returns -7154, the correct epoch day for 1950-06-01.
How this happens in JDBC
ArrowFlightJdbcDateVectorAccessor.getDate(Calendar) applies the calendar offset before calling this method. A DATE starts at midnight, but any difference between the supplied calendar zone and the JVM default moves it away from midnight. Passing a Calendar is the documented way to read a date in a specific zone. As a result, every pre-1970 date read this way came back one day late. Any non-zero offset can expose the bug. Historical offsets can include seconds, such as +05:53:28.
The existing negative test used -618105600000, exactly 1950-06-01 00:00:00 UTC. At midnight, truncating division and floor division agree, so that test could not expose the bug.
The fix uses Math.floorDiv and Math.floorMod for both parts and removes the manual adjustment. Positive values behave as before. A test now covers 1950-06-01 01:00:00 UTC.
This affects flight-sql-jdbc-core on main and in 19.0.0. It is platform independent. Issues #732 and #324 cover broader timestamp and time-zone behavior. This report is only about the integer-division bug above.
- 主要語言
- Java
- 星號
- 95
- 分支
- 154
- 平均合併
- 2 天 10 小時
- 30 天內合併 PR
- 11
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
apache/arrow-java 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 74/100
apache/arrow-java#1261 ·
-
難度 2/5 1-3 小時 新手友好度 78/100
apache/arrow-java#1236 ·
-
難度 2/5 1-3 小時 新手友好度 78/100
apache/arrow-java#1230 ·
-
Type: bug
難度 2/5 1-3 小時 新手友好度 85/100
apache/arrow-java#1205 ·
-
Type: bug
難度 2/5 1-3 小時 新手友好度 68/100
apache/arrow-java#1196 · 1 則留言 ·
查看 apache/arrow-java 的全部 Issue
相似的 Issue
-
area-deployment area-integrations triage:bot-seen
難度 2/5 半天 新手友好度 86/100
-
難度 2/5 1-3 小時 新手友好度 75/100
apache/flink-agents#1156 ·
-
area/connectors autoteam community connectors/source/shopify needs-triage team/use type/bug
難度 2/5 1-3 小時 新手友好度 84/100
-
難度 2/5 1-3 小時 新手友好度 70/100
-
難度 1/5 1 小時以內 新手友好度 85/100