bug(aria/combobox): keys pressed back to back are lost; only the last one reaches the popup
維護者通常 1 天內回覆
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 78/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- angular, typescript
研究方向
從 Angular 的 ARIA combobox 實作中的 ComboboxPattern 著手。issue 指出,keyboardEventRelay 在此處被設定,之後會重新分派至 popup control target。追蹤按鍵處理常式和 relay effect,接著為多個連續的 ArrowDown 事件新增或更新單元測試。完成條件是每個事件都依序處理,按三次會移動三個選項。
由索引模型根據 Issue 內容生成。
描述
Is this a regression?
- Yes, this behavior used to work in the previous version
The previous version in which this bug was not present was
No response
Description
While the popup is open, ComboboxPattern relays navigation and typeahead keys to the popup through a signal: the key handler does this.keyboardEventRelay.set(e), and an effect later re-dispatches the event on the popup's control target. If a second key arrives before the effect runs, the signal is overwritten and the first key is never relayed.
Effects:
- Down, Down, Down pressed quickly moves the active option once.
- Typeahead loses characters: with options
item,item-2,item-3, typingitem-3with no delay between keys lands onitem; with 60 ms between keys it lands onitem-3. - Test automation and tools that send keys in a burst (and some assistive technology input) see wrong results. Seen in Chromium through Playwright, and in unit tests.
Related: #33361 (same relay signal, different symptom: a stale event replayed on reopen).
Reproduction
import { Component } from '@angular/core';
import { TestBed } from '@angular/core/testing';
import { Combobox, ComboboxPopup, ComboboxWidget } from '@angular/aria/combobox';
import { Listbox, Option } from '@angular/aria/listbox';
@Component({
imports: [Combobox, ComboboxPopup, ComboboxWidget, Listbox, Option],
template: `
<div ngCombobox #combobox="ngCombobox" tabindex="0">Pick one</div>
<ng-template ngComboboxPopup [combobox]="combobox">
<div ngListbox ngComboboxWidget #listbox="ngListbox" focusMode="activedescendant"
[activeDescendant]="listbox.activeDescendant()">
@for (o of options; track o) {
<div ngOption [value]="o" [label]="o">{{ o }}</div>
}
</div>
</ng-template>
`,
})
class Repro {
options = ['alpha', 'bravo', 'charlie', 'delta'];
}
const key = (el: Element, k: string) =>
el.dispatchEvent(new KeyboardEvent('keydown', { key: k, bubbles: true }));
it('handles each key pressed back to back', async () => {
const fixture = TestBed.createComponent(Repro);
await fixture.whenStable();
const combobox = fixture.nativeElement.querySelector('[ngCombobox]');
combobox.focus();
key(combobox, 'ArrowDown'); // open
await fixture.whenStable();
key(combobox, 'Home');
await fixture.whenStable();
key(combobox, 'ArrowDown');
key(combobox, 'ArrowDown');
key(combobox, 'ArrowDown');
await fixture.whenStable();
const id = combobox.getAttribute('aria-activedescendant');
expect(fixture.nativeElement.querySelector(`[id="${id}"]`).textContent.trim())
.toBe('delta'); // actual: 'bravo'
});
Expected Behavior
Each key event is handled, in order. Three Down presses move three options.
Actual Behavior
Only the last key since the effect last ran is relayed. Three Down presses move one option ("bravo" in place of "delta").
A possible fix: relay each event synchronously from the key handler (or queue them), not through a single-value signal.
Environment
- Angular: 22.2.1
- CDK/Material: @angular/cdk 22.2.3, @angular/aria 22.2.3 (also in 22.3.0-next.2 and
main) - Browser(s): Chromium (Playwright); Vitest with happy-dom
- Operating System (e.g. Windows, macOS, Ubuntu): macOS
- 主要語言
- TypeScript
- 星號
- 25k
- 分支
- 6.8k
- 平均合併
- 1 天 5 小時
- 30 天內合併 PR
- 67
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
angular/components 的其他 Issue
-
bug(aria/combobox): ComboboxPopup throws NG0950 when destroyed before its first change detection可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉area: aria/combobox gemini-triaged
難度 2/5 1-3 小時 新手友好度 78/100
angular/components#33972 ·
維護者通常 1 天內回覆
-
bug(material/sort): hover hint arrow on an unsorted header shows the active sort direction, not the resulting direction after click.可能已有人在做 @lekhmanrus 於 12 天前認領。 未關閉area: material/sort P3
難度 2/5 1-3 小時 新手友好度 70/100
angular/components#33933 ·
維護者通常 1 天內回覆
-
bug(mat-date-picker): month shown twice in date picker可能已有人在做 @PreethiPantangi 於 29 天前認領。 未關閉area: material/datepicker P4
難度 2/5 1-3 小時 新手友好度 72/100
angular/components#33763 · 2 則留言 · 3 個 reaction ·
維護者通常 1 天內回覆
-
Bug in table.scss footer cell height: unset instead of footer row height unset可能已有人在做 @minwookshin 於 16 天前認領。 未關閉area: material/table P4
難度 1/5 1 小時以內 新手友好度 88/100
angular/components#33709 · 1 則留言 ·
維護者通常 1 天內回覆
-
docs-bug(Table): Add example with `rowspan`可能已有人在做 @BHUVANSH855 於 97 天前認領。 未關閉area: material/table docs P4
難度 2/5 1-3 小時 新手友好度 72/100
angular/components#33455 ·
維護者通常 1 天內回覆
查看 angular/components 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 66/100
getsentry/sentry-conventions#732 · 1 則留言 ·
維護者通常 1 天內回覆
-
status:in-linear status:team-assigned team:nodes
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
motiondivision/motion#3955 ·
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 68/100
equinor/prisma-decision-web#919 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 83/100