Provide better story for individual migration results
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 35/100
- Issue 類型
- 缺陷
- 描述清晰度
- 基本清楚
- 活躍度
- 停滯
- 技術堆疊
- angular, cli, typescript
研究方向
首先,使用 issue 中失敗和成功的 migration 範例,透過 ng update 進入點重現回報的輸出。追蹤個別 migration 如何回報結果,並讓最終輸出區分已完成的 update 與應該恢復的中斷 update;驗證這兩種情境都會產生準確的狀態訊息。
由索引模型根據 Issue 內容生成。
描述
This issue impacts 9.0.0-rc.0 and happened while updating https://github.com/johannesjo/super-productivity and https://github.com/SAP/cloud-commerce-spartacus-storefront.
A failed update will show a message saying both the individual migration and the update failed:
× Package install failed, see above.
The update failed. See above.
git HEAD was at 85f08a4d93e684566f751e38e2a2feffe0194cd9 before migrations.
× Migration failed. See above for further details.
The update below did not finish successfully however, and instead just shows the last migration as successful (@devversion confirms this). In this case the migration shows an error that it seems to suggest was actually recovered from, but it fact the intent is that the migration was interrupted and should later be resumed.
> Undecorated classes with DI migration.
As of Angular 9, it is no longer supported to use Angular DI on a class that does not have an Angular decorator.
Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes
This migration uses the Angular compiler internally and therefore projects that no longer build successfully after the update cannot run the migration. Please ensure there are
no AOT compilation errors and rerun the migration.. The following project failed: projects/storefrontlib/tsconfig.lib.json
TypeError: Cannot read property 'module' of undefined
Could not migrate all undecorated classes that use dependency
injection. Some project targets could not be analyzed due to
TypeScript program failures.
Migration can be rerun with: "ng update @angular/core --from 8.0.0 --to 9.0.0 --migrate-only"
√ Migration succeeded.
A completely successful migration will look the same as the migration above though:
kamik@RED-X1C6 MINGW64 /d/sandbox/latest-app (master)
$ ng update @angular/cli @angular/core --next
The installed Angular CLI version is older than the latest published version.
Installing a temporary version to perform the update.
Installing packages for tooling via yarn.
warning @angular-devkit/architect@0.900.0-rc.0: The engine "pnpm" appears to be invalid.
warning @schematics/angular@9.0.0-rc.0: The engine "pnpm" appears to be invalid.
warning @angular-devkit/schematics@9.0.0-rc.0: The engine "pnpm" appears to be invalid.
warning @angular-devkit/core@9.0.0-rc.0: The engine "pnpm" appears to be invalid.
warning @schematics/update@0.900.0-rc.0: The engine "pnpm" appears to be invalid.
warning @angular/cli@9.0.0-rc.0: The engine "pnpm" appears to be invalid.
Installed packages for tooling via yarn.
Using package manager: 'yarn'
Collecting installed dependencies...
Found 35 dependencies.
Fetching dependency metadata from registry...
Updating package.json with dependency @angular/cli @ "9.0.0-rc.0" (was "8.3.17")...
Updating package.json with dependency @angular/core @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/language-service @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/compiler-cli @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/animations @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/platform-browser @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/platform-browser-dynamic @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/common @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/compiler @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/forms @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular/router @ "9.0.0-rc.0" (was "8.2.13")...
Updating package.json with dependency @angular-devkit/build-angular @ "0.900.0-rc.0" (was "0.803.17")...
UPDATE package.json (1636 bytes)
√ Packages installed successfully.
** Executing migrations of package '@angular/cli' **
> Update an Angular CLI project to version 9.
UPDATE angular.json (6359 bytes)
UPDATE package.json (1637 bytes)
UPDATE server.ts (1863 bytes)
√ Packages installed successfully.
√ Migration succeeded.
> Update lazy loading syntax to use dynamic imports.
√ Migration succeeded.
** Executing migrations of package '@angular/core' **
> Static flag migration.
Removes the `static` flag from dynamic queries.
As of Angular 9, the "static" flag defaults to false and is no longer required for your view and content queries.
Read more about this here: https://v9.angular.io/guide/migration-dynamic-flag
√ Migration succeeded.
> Missing @Injectable migration.
In Angular 9, enforcement of @Injectable decorators for DI is a bit stricter.
Read more about this here: https://v9.angular.io/guide/migration-injectable
√ Migration succeeded.
> ModuleWithProviders migration.
In Angular 9, the ModuleWithProviders type without a generic has been deprecated.
This migration adds the generic where it is missing.
Read more about this here: https://v9.angular.io/guide/migration-module-with-providers
√ Migration succeeded.
> NGCC postinstall migration.
Adds an ngcc invocation to npm/yarn's postinstall script.
Read more about this here: https://v9.angular.io/guide/migration-ngcc
UPDATE package.json (1743 bytes)
√ Packages installed successfully.
√ Migration succeeded.
> Renderer to Renderer2 migration.
As of Angular 9, the Renderer class is no longer available.
Renderer2 should be used instead.
Read more about this here: https://v9.angular.io/guide/migration-renderer
√ Migration succeeded.
> Undecorated classes with decorated fields migration.
As of Angular 9, it is no longer supported to have Angular field decorators on a class that does not have an Angular decorator.
Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes
√ Migration succeeded.
> Undecorated classes with DI migration.
As of Angular 9, it is no longer supported to use Angular DI on a class that does not have an Angular decorator.
Read more about this here: https://v9.angular.io/guide/migration-undecorated-classes
√ Migration succeeded.
We should confirm the update finished, was successful, or if it was interrupted midway and should later be continued.
- 主要語言
- TypeScript
- 星號
- 27k
- 分支
- 11.8k
- 平均合併
- 17 小時 25 分鐘
- 30 天內合併 PR
- 183
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
angular/angular-cli 的其他 Issue
-
area: @angular/build gemini-triaged
難度 2/5 1-3 小時 新手友好度 74/100
angular/angular-cli#33955 ·
-
area: @angular/cli gemini-triaged
難度 2/5 1-3 小時 新手友好度 72/100
angular/angular-cli#33055 · 1 則留言 · 3 個 reaction ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34131 · 已指派 1 人 ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34130 · 已指派 1 人 ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34128 · 已指派 1 人 ·
查看 angular/angular-cli 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
safetrustcr/dApp-SafeTrust#426 ·
-
area:workflow bug ready-for-agent
難度 2/5 1-3 小時 新手友好度 75/100
fil-donadoni/tolaria#4409 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
Fission-AI/OpenSpec#1960 ·
-
Add dependabot 未關閉
難度 2/5 1-3 小時 新手友好度 70/100
-
難度 2/5 1-3 小時 新手友好度 75/100
corsairdev/corsair#1764 ·