Remove pluggy: it is only used as an entry-point loader, and the class-based hookspecs break on pluggy 1.7
還沒有人認領這個 Issue。
評估
研究方向
Start by tracing plugincode’s current entry-point loading and dependency declaration, then check how src/scancode/cli.py consumes the loaded plugin classes. Run the existing plugin-loading tests before and after the change; done means plugins load through importlib.metadata, duplicate names keep the first entry, subclass validation remains, and the marker decorators stay importable.
由索引模型根據 Issue 內容生成。
描述
Written by Claude Opus 5.5 via Claude Code for the plugincode and scancode-toolkit maintainers; I prompted it, it did the work, I read it.
This is filed by Ronny Pfannschmidt, a pluggy maintainer. The behaviour plugincode relies on was never part of pluggy's API, and pluggy will not restore it.
pluggy 1.7.0 breaks every plugincode stage at import time (aboutcode-org/scancode-toolkit#5363):
File ".../plugincode/__init__.py", line 182, in __init__
self.manager.add_hookspecs(sys.modules[module_qname])
ValueError: did not find any 'pre_scan' hooks in <module 'plugincode.pre_scan' ...>
scancode-toolkit now caps pluggy < 1.7.0 (aboutcode-org/scancode-toolkit@1891da6acf). A cap is not a fix. The underlying problem is that plugincode does not use pluggy as a hook system at all.
What plugincode actually does with pluggy
@pre_scan_spec,@scan_spec, etc. decorate classes. Hookspecs are functions. On pluggy ≤ 1.6,add_hookspecshappened to accept these classes and created hooks named after them (PreScanPlugin, …) that nothing ever calls. pluggy 1.7 only accepts functions and methods, finds none, and raises.@pre_scan_impl,@scan_impl, etc. also decorate classes.register()looks for marked attributes on the plugin object and finds none, so every plugin registers with zero hook implementations, on 1.6 and 1.7 alike.- No
pm.hook.<name>(...)call exists in plugincode or scancode-toolkit. - What is left is
load_setuptools_entrypoints(group)followed bylist_name_plugin(). In other words: iterateimportlib.metadataentry points,ep.load(), store{ep.name: cls}. scancode-toolkit then instantiates the classes and calls their methods directly (src/scancode/cli.py, around line 741).
A standalone script on pluggy 1.6.0 and 1.7.0 shows the above: the class-decorated "hookspecs" fail on 1.7, and register() of a class succeeds with no hook implementations on both versions.
Request
Drop the pluggy dependency and load plugins with importlib.metadata.entry_points(group=entrypoint) directly:
- Keep
ep.nameas the plugin name. The first name wins and later duplicates are skipped, matchingload_setuptools_entrypoints. - Keep the existing
issubclass(plugin_class, plugin_base_class)validation. - Keep
HookspecMarker/HookimplMarkerexported as no-op decorators, so third-party plugins that apply@pre_scan_implkeep importing. They can be deprecated later.
This removes a dependency and keeps the plugin API unchanged for plugin authors. Once it is released, scancode-toolkit can drop the < 1.7.0 cap (tracked in aboutcode-org/scancode-toolkit, issue to follow).
- 主要語言
- Python
- 星號
- 1
- 分支
- 2
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
aboutcode-org/plugincode 的其他 Issue
-
難度 3/5 1-2 天 新手友好度 35/100
aboutcode-org/plugincode#12 · 2 則留言 ·
-
難度 2/5 1-3 小時 新手友好度 45/100
-
enhancement plugin
難度 5/5 一週以上 新手友好度 30/100
aboutcode-org/plugincode#4 · 6 則留言 · 1 個 reaction ·
查看 aboutcode-org/plugincode 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
-
難度 2/5 1-3 小時 新手友好度 70/100
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 2 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
developmentseed/titiler-cmr#278 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 2 天內回覆