feat(jobs): daily hard-delete retention cleanup (F-D10, 30-day default per D-001)

未關閉
#59 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
5/5
預估耗時
一週以上
新手友好度
25/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
postgresql, rust

研究方向

Start with CoreConfig and the soft delete and blob store interfaces in crates/thrust-core/src/lib.rs and crates/thrust-ports/src/lib.rs; then read the worker cron handler, native server timer, and schedules.rs. The issue is blocked by #35 and #43, so those dependencies need to land first. Done means retention deletes only rows past the configured cutoff, removes their blobs and eligible outbox rows, and passes the specified core, adapter, route, and scheduling tests.

由索引模型根據 Issue 內容生成。

描述

area:app prio:p0 review:fable-2026-10-19

Context

Only work items are soft-deleted today. delete_work_item (crates/thrust-core/src/lib.rs:301-344) reads the injected Clock (:309) and sets work_items.deleted_at (crates/thrust-adapters-postgres/migrations/0001_init.sql:40) through Tx::soft_delete_work_item (crates/thrust-ports/src/lib.rs:147-153; Postgres at crates/thrust-adapters-postgres/src/lib.rs:444-455). Nothing ever removes a row: a search of crates/, scripts/ and docs/src/ for hard_delete, purge or retention finds only the R2 binding probe, and the outbox table (0001_init.sql:54-62) only grows. The only scheduled work is the outbox sweeper. The Worker's single cron, * * * * * (crates/thrust-worker/wrangler.toml:20-21), runs it on every trigger; the handler only logs event.cron() and does not branch on it (crates/thrust-worker/src/lib.rs:193-213). The native server runs it on an optional interval (crates/thrust-server/src/main.rs:93-106). ADR-0072's SCHEDULES table in crates/thrust-core/src/schedules.rs (ADR-0072 lines 38-46) does not exist.

Problem

  • The plan requires this cleanup. F-D10 is P0 with hard delete at 30 days (FEATURES.md:83). D-001 records the 30-day default against Plane's 60 (DEVIATIONS.md:9). Q-0043.2 keeps the daily cadence (QUESTIONS.md:181). ADR-0043 notes that nothing else would purge soft-deleted rows (line 93). The review puts the cleanup in M2 (§3, FR-01), and TRACEABILITY asks for a cron test and a retention test (TRACEABILITY.md:54).
  • Plane at the pin: hard_delete runs daily at 00:00 UTC (apps/api/plane/celery.py:61-63) and reads HARD_DELETE_AFTER_DAYS (settings/common.py:420, default 60). It deletes rows with deleted_at < now - days, first from 18 named models (bgtasks/deletion_task.py:138-180) and then from every model that has a deleted_at field (:182-191). The comparison is strict, so a row deleted exactly N days ago stays.
  • ADR-0046 keeps outbox rows for 90 days and says the retention job is not built (lines 32, 71, 120). Under FR-18 the retained outbox is the P0 audit trail, so this purge also sets the P0 audit retention (Q-0048.1).
  • The purge runs across tenants, so it cannot take a Scope. Attachments have no row: they are blobs under <workspace>/<project>/<item>/ (crates/thrust-core/src/lib.rs:468-470), so purging an item's row would leave its blobs behind.

Proposal

  • Config: CoreConfig (crates/thrust-core/src/lib.rs:29-47) gains hard_delete_after_days: u32 (default 30, D-001) and outbox_retention_days: u32 (default 90), read from THRUST_HARD_DELETE_AFTER_DAYS and THRUST_OUTBOX_RETENTION_DAYS. A negative or unparseable value fails startup, for the reason Plane gives at settings/common.py:423-436.
  • thrust_core::run_retention(app, &SystemScope) takes the SystemScope from #35. With cutoff = clock.now() - days, it deletes rows with deleted_at < cutoff in bounded batches, children before parents, from every soft-deletable table (work_items today; later tables join a registry). For each purged item it also deletes the blobs under the item's prefix (BlobStore::list and delete, crates/thrust-ports/src/lib.rs:200-205). Then it deletes outbox rows that were created more than 90 days ago and have been dispatched (created_at < now - 90 d AND dispatched_at IS NOT NULL); it never purges an undispatched row.
  • What the purge leaves: project_sequences is never touched, so a purged number is never handed out again (ADR-0043 B1). Activity rows are kept, as Plane declares IssueActivity.issue with on_delete=DO_NOTHING (apps/api/plane/db/models/issue.py:416).
  • Scheduling: schedules.rs holds two entries, outbox-sweep (* * * * *) and hard-delete (0 0 * * *).
    • The single Worker from #43 adds "0 0 * * *" to triggers.crons and dispatches on event.cron().
    • The native server adds a daily timer at 00:00 UTC. It runs as a single process (ADR-0070 round 29), so no leader election is needed (ADR-0072 line 56).
    • Each run works through bounded batches inline, within the 15-minute cron wall time (FR-05), instead of enqueuing work as ADR-0072 line 22 says; record that in ADR-0072. A run is idempotent.
  • Test route: POST /internal/retention takes a now override. Like /internal/sweep (crates/thrust-api/src/lib.rs:158-160,275), it needs test routes and the admin token, so the contract suite can drive it on all four targets.
  • F-D10's log cleanups (API, email and webhook logs, versions) join this job once their tables exist.

Acceptance criteria

  • crates/thrust-core/tests/retention.rs passes. It is hermetic: memory adapters, with a settable clock in place of FixedClock (tests/common/mod.rs:33-39). With 30-day retention, in both tenants, items soft-deleted 31 days and 30 days plus 1 s ago are gone; items deleted exactly 30 days ago and 29 days ago, and live items, remain; a later create gets the next sequence number. Control: two mutants added to scripts/mutants.sh, one comparing with <= and one ignoring the cutoff, each make it fail.
  • The outbox follows the same rule: a dispatched row created 91 days ago is gone, while a dispatched row created 89 days ago and an undispatched row created 200 days ago remain. Control: a mutant that purges on age alone makes it fail.
  • A purged item's prefix lists no blobs, and another item's blobs remain.
  • retention_purges_only_rows_past_the_window passes through /internal/retention on all four targets. pg_adapter.rs covers the purge SQL on real Postgres, with the cutoff bound as a typed parameter (execute_typed).
  • In worker_only.rs, next to worker_cron_scheduled_handler_runs_the_sweeper (:110-134), with THRUST_HARD_DELETE_AFTER_DAYS=0: after /__scheduled?cron=*+*+*+*+*, a deleted item is still listed with scope=with_deleted; after /__scheduled?cron=0+0+*+*+*, it is gone. Control: a handler that ignores event.cron() makes it fail.
  • A test asserts that wrangler.toml triggers.crons and SCHEDULES hold the same cron set. Adding a cron to only one of them makes it fail.

References

  • Review: .agents/plans/contrail/reviews/2026-10-19-fable-architecture-review.md (FR-01; §3 M2 row; FR-18 (3))
  • FEATURES F-D10 (FEATURES.md:83); DEVIATIONS D-001 (DEVIATIONS.md:9); TRACEABILITY F-D10 (TRACEABILITY.md:54); Q-0043.2 (QUESTIONS.md:181), Q-0046.2 (:185), Q-0073.2 (:110), Q-0048.1 (:279)
  • ADR-0043 (lines 79, 89, 93), ADR-0072 (lines 22, 38-46, 56, 60-61, 89), ADR-0046 (lines 32, 71, 120), ADR-0070 (round-29 note), ADR-0045
  • crates/thrust-core/src/lib.rs:29-47,301-344,468-470; crates/thrust-ports/src/lib.rs:147-153,200-205; crates/thrust-adapters-postgres/src/lib.rs:108-127,444-455; crates/thrust-adapters-postgres/migrations/0001_init.sql:40,54-62
  • crates/thrust-worker/wrangler.toml:20-21; crates/thrust-worker/src/lib.rs:193-213; crates/thrust-server/src/main.rs:93-106; crates/thrust-api/src/lib.rs:158-160,275; crates/thrust-core/tests/common/mod.rs:33-39; scripts/mutants.sh:30-32
  • Plane oracle (oracle/v1-pin-20261018): apps/api/plane/bgtasks/deletion_task.py:114-193; apps/api/plane/celery.py:61-63; apps/api/plane/settings/common.py:420,423-448; apps/api/plane/db/models/issue.py:416

Blocked by: #35, #43

Finding: FR-01

主要語言
Rust
星號
0
分支
0
平均合併
1 小時 35 分鐘
30 天內合併 PR
67

環境準備

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

aRustyDev/thrust 的其他 Issue

查看 aRustyDev/thrust 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。