feat(compat): the 48-route minimum slice with the auth-client JSON change
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 20/100
- Issue 類型
- 功能
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- react, rust, typescript
研究方向
Start with research/0003-compat-plane-inventory.md §8.1 and §9, then read ADR-0034 and the route inventory in scripts/compat-inventory/p0_slice.py. The work depends on issues #35, #36, #37, #38 and #47, and spans the new compat crate, imported React files, and parity tests. Done means routes S01–S48 and X01–X03 pass fixture comparisons, contract tests and the specified browser journey, with actual effort and ADR tripwires recorded.
由索引模型根據 Issue 內容生成。
描述
Context
Today thrust_api::router() (crates/thrust-api/src/lib.rs:269-293) serves the spike slice only: work items, activity and attachments, with no /auth routes. The tree has neither a compat crate nor a React app. docs/src/architecture/app.md:119-120 says thrust-compat-plane does not exist and there is no web/ directory, although Q-0005.2 (answered in round 15) moves the frontend into this repository. research/0003 §8.1 lists what the stock React UI needs for "sign up, onboard, create workspace, create project, create work item, see it in the list". That is 48 route rows (S01 to S48) on 42 distinct paths, plus X01 to X03 to open the item.
Problem
- At the pin, the slice is estimated at 39.3 pd (26.7 to 66.7) and every P0 row React uses at 207.6 pd (
research/0003§15.6, lines 817 and 819). FR-01 says to build the slice first and bound everything after it by the M2 acceptance list (#46). ADR-0034's round-27 tripwires reopen it if the slice costs more than 66 pd or the re-estimated P0 exceeds 364 pd (adrs/api/0034-internal-api-compat-layer-and-core-openapi.md:68; Q-0009.1,QUESTIONS.md:280). - The auth-client JSON change is the largest lever inside the Q-R2 allowed areas (
research/0003§9 row 1, line 528; ADR-0034:60). Today sign-in is a browser form POST to/auth/sign-in/with a CSRF token fetched as JSON (apps/web/core/components/account/auth-forms/password.tsx:122-125,:150-151at the oracle pin), and the server answers302 ?error_code=. Emulating that costs about 16 pd and 41 of the 545 rows. Q-0009.1 says to make the change before reopening ADR-0034. - Two React behaviours fix shapes. Any 401 sends the app to
/?next_path=(apps/web/core/services/api.service.ts:29-31), so a 401 must mean only "no or expired session"; a role failure must be a 403. An unauthenticatedGET /api/users/me/must return a JSON object with noid(research/0003§9 rows 2 and 3). - In Plane, seven slice handlers dispatch background tasks, so the outbox sits on the slice's write path (§8.1, line 500). The project page fires 13 reads and the workspace wrapper 9 (§1 item 5).
Proposal
- Bring
apps/web, and the@plane/*packages it needs, into this repository at the oracle pinba85d4d3d3(Q-0005.2). Change only the Q-R2 areas. - Auth client: change
auth-forms/{password,unique-code,reset-password}.tsx,hooks/oauth/core.tsx,services/auth.service.tsandpackages/services/.../auth.service.ts. Replace the form-POST-and-302 flow with JSON POSTs to/auth/*handlers built on the #38 auth slice. Responses carry the sameerror_codevalues in a JSON body, soauthErrorHandleris unchanged, and set the session cookie. CSRF is the double-submit from #38. - Create the compat crate (ADR-0034;
thrust-compat-planein ARCHITECTURE §2a). It mounts S01 to S48 and X01 to X03 under/api/and/auth/on the shared router, overthrust-coreuse-cases that take a&Scope(#35) and the user-onlyPrincipal(#36), on the engine #37 decides. Plane-shaped request and response types stay inside the crate (#52), and/api/v1stays free for wire-compatible routes (#47). - Hold the list rows (S17, S47) to the round-trip budget from #39.
- Record actual pd per effort class (
research/0003§8) and re-check both ADR-0034 tripwires at the end.
Acceptance criteria
- Every row S01 to S48 and X01 to X03 has a route. A
parity_test per row compares status and normalised body with a fixture recorded from the pinned oracle (intests/parity/fixtures/). Control: a mutated fixture fails. - Contract tests on all four targets: a slice read with no session gets 401; a member lacking the role gets 403; an unauthenticated
GET /api/users/me/gets a JSON object with noid. -
git diff --stat ba85d4d3d3 -- apps/web packages, run against the imported tree, lists only auth-client and base-URL or service-layer files (Q-R2). - Against
wrangler devwith the Cloudflare set, the stock React app completes sign up, onboarding, workspace, project, work item and list, and the browser network log shows no 404. That journey becomes the first #45 journey. - The closing comment records actual pd against 39.3 pd and says whether either ADR-0034 tripwire fired.
References
- Review: .agents/plans/contrail/reviews/2026-10-19-fable-architecture-review.md (FR-01; §3 M1 row)
research/0003-compat-plane-inventory.md§1, §8, §8.1 (lines 439-507), §8.2, §9 (lines 522-539), §15.6 (lines 794-833)- ADR-0034 (
:60,:68; round-29 note), ADR-0001 (:43, walking skeleton), ADR-0013 (round-29 note), ADR-0050, ADR-0052 - Q-0009.1, Q-R2, Q-0005.1, Q-0005.2, Q-0010.1; FEATURES F-X13, F-A03, F-B01 to F-B03; DEVIATIONS D-013
spikes/0009-compat-plane-inventory.md; slice definitionscripts/compat-inventory/p0_slice.py(off-repo,spikes/README.md:54; #55)- Plane oracle (
oracle/v1-pin-20261018):apps/web/core/components/account/auth-forms/password.tsx:122-125,150-151,apps/web/core/services/api.service.ts:29-31 crates/thrust-api/src/lib.rs:269-293;docs/src/architecture/app.md:115-124- Beads: plane-byd.3
Blocked by: #35, #36, #37, #38, #47
Finding: FR-01
- 主要語言
- Rust
- 星號
- 0
- 分支
- 0
- 平均合併
- 1 小時 35 分鐘
- 30 天內合併 PR
- 67
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
aRustyDev/thrust 的其他 Issue
-
area:process prio:p1 type:security
難度 4/5 3-5 天 新手友好度 48/100
維護者通常 1 天內回覆
-
area:process bug prio:p1
難度 4/5 3-5 天 新手友好度 38/100
維護者通常 1 天內回覆
-
area:process prio:p1
難度 4/5 3-5 天 新手友好度 55/100
維護者通常 1 天內回覆
-
area:process prio:p1
難度 4/5 1-2 天 新手友好度 55/100
維護者通常 1 天內回覆
-
area:process prio:p1
難度 4/5 3-5 天 新手友好度 56/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 72/100
-
難度 2/5 1-3 小時 新手友好度 78/100
CakeRepository/agentshangout#995 ·
-
area:frontend kind:bug priority:p3 ready
難度 2/5 1-3 小時 新手友好度 88/100
維護者通常 1 天內回覆