fix(mcp): active view metadata disagrees with the view list recommendation
維護者通常 2 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
The report identifies bn_binary_view_list, bn_binary_view_get_active, and the view-selection reply as the affected entry points; it says their implementation ships inside the proprietary application. Start by tracing the public MCP tool declarations and any shared view metadata serialization in the repository. Done means the same unchanged active view has consistent recommendation metadata across all three replies, or the replies document distinct semantics without contradictory booleans.
由索引模型根據 Issue 內容生成。
描述
Summary
For the same active Mach-O view with no intervening state change, bn_binary_view_list reports recommended: true, while bn_binary_view_get_active reports recommended: false. Clients therefore receive conflicting metadata for one view. The inconsistency also appears in the view-selection reply.
Steps to reproduce
- Save the C source below as
fixture.c, compile it, and openfixturein Binary Ninja. Enable and start the built-in GUI MCP server, then connect an MCP client and runtools/list.
#include <stdio.h>
volatile int fixture_global = 7;
__attribute__((noinline, used)) int fixture_leaf(int value) { puts("FIXTURE_LEAF"); return value + fixture_global; }
__attribute__((noinline, used)) int fixture_branch(int value) { return value > 3 ? fixture_leaf(value) : fixture_leaf(-value); }
int main(int argc, char **argv) { return fixture_branch(argc); }
clang -arch arm64 -O0 -g -fno-inline fixture.c -o fixture
-
Call
bn_binary_view_list, select the returned Mach-O view withbn_binary_view_set_active, and wait untilbn_analysis_statusreportsIdleState. Use the returned handle unchanged; handle values are session-scoped. -
Call
bn_binary_view_listand immediately callbn_binary_view_get_active, with no intervening tool call or GUI action. Comparerecommendedfor the same returned Mach-O view handle. Repeat the pair if desired. -
Inspect the
binaryViewobject returned by the view-selection call as well.
Expected behavior
The guide says to use the recommended field from the view list when choosing a view. When another tool returns the same named property on that same view, it should agree, or the contract should explicitly describe a different meaning or an unavailable value. The stable and default-branch guides describe no alternate meaning for the active-view property.
Actual behavior
Two consecutive list/get-active pairs reproduced the mismatch after analysis was idle. The following projection omits opaque handles; the handle and open-item identity matched across each pair.
| tool | viewType | created | active | available | recommended |
|---|---|---|---|---|---|
bn_binary_view_list |
Mach-O | true | true | true | true |
bn_binary_view_get_active |
Mach-O | true | true | true | false |
The get-active result carried recommended: false in both its JSON text and structuredContent.binaryView. The view-selection result also carried recommended: false. No view creation, analysis mutation, file switch, or GUI action occurred between each list/get-active pair. View selection and inspection still worked; no analysis failure was observed.
Evidence
- Expected source: The guide's “Handles” section directs clients to the list's
recommendedproperty; installed active-view tools return a same-named property on the same view object. Versioned guide links appear under Runtime or environment. - Failure source: Direct consecutive raw HTTP replies from the view-list and get-active tools, plus the earlier view-selection reply; relevant fields are projected above.
- Evidence provenance: observed
- Local verification: reproduced
- Reproduction completeness: complete
Restoration check
For one unchanged active view, compare the same view's recommendation across list, get-active, and set-active responses. The replies should agree on the recommendation, or explicitly represent and document any different semantics without presenting a contradictory boolean as the same metadata.
Runtime or environment
- Binary Ninja Version: Free 6.0.10905-Stable; bundle version
6.0.10905_free; built-in GUI HTTP MCP serverbinaryninja_ui_mcpversion0.1.0. - Edition: Free. OS: macOS 27.2; CPU architecture: arm64. Target: thin arm64 Mach-O built with the command above. Analysis status was
IdleStatebefore the observations. - The official stable release metadata matched the installed build. A fresh profile enabled
ui.mcp.enabled; no user plugins or existing databases were involved. The target was analyzed, never executed, and no database was saved. - The stable MCP guide and the current default-branch MCP guide were compared. Their relevant calling conventions agree. The implementation ships inside the proprietary application, so public default-branch source inspection does not verify its runtime behavior.
- The issue template requests development-build testing. That was not performed: Free cannot switch to the development channel. Personal/Commercial editions, development builds, Windows, and Linux are untested.
Triage assessment
- Impact level: P2
- Assessment status: supported
- Impact basis: The same view exposes contradictory selection metadata to MCP clients. The observed failure is bounded to metadata; view selection and function inspection succeeded.
- Workaround status: available
- Workaround basis: Use the list tool's recommendation as the guide instructs. That tool returned a usable Mach-O view and selecting it allowed successful inspection in this reproduction.
- 主要語言
- C++
- 星號
- 1.3k
- 分支
- 304
- 平均合併
- 2 天 20 小時
- 30 天內合併 PR
- 10
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
Vector35/binaryninja-api 的其他 Issue
-
難度 1/5 1 小時以內 新手友好度 84/100
Vector35/binaryninja-api#8715 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
Vector35/binaryninja-api#8714 ·
維護者通常 2 天內回覆
-
難度 1/5 1 小時以內 新手友好度 85/100
Vector35/binaryninja-api#8713 ·
維護者通常 2 天內回覆
-
難度 1/5 1-3 小時 新手友好度 78/100
Vector35/binaryninja-api#8689 ·
維護者通常 2 天內回覆
-
Component: Python API
難度 2/5 1-3 小時 新手友好度 70/100
Vector35/binaryninja-api#8649 ·
維護者通常 2 天內回覆
查看 Vector35/binaryninja-api 的全部 Issue
相似的 Issue
-
Bug Core VIF
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 80/100
ESPresense/ESPresense#2680 · 2 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1 小時以內 新手友好度 75/100
stew675/llama-cpp-rdna-boosts#348 ·
維護者通常 1 天內回覆
-
Documentation: Add comprehensive newcomer onboarding guide, project structure, and local usage to README可能已有人在做 @Ash-Blanc 今天認領。 未關閉area/other status/bot-triaged status/need-triage
難度 2/5 半天 新手友好度 85/100
-
bug
難度 1/5 1 小時以內 新手友好度 85/100
維護者通常 1 天內回覆