Finding constants in disassembly often doesn't find any

未關閉
#8,695 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 2 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
55/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
cpp

研究方向

Start by tracing BinaryView::FindAllConstant and how it matches disassembly tokens against their values; compare that behavior with InstructionTextToken sizes for the listed architectures. The issue does not name source files or tests, so locate the implementation and relevant coverage before choosing a fix. Done means numeric constants visible in disassembly can be found for the reproduction architectures.

由索引模型根據 Issue 內容生成。

描述

Effort: Low Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 6.1.11009-dev Ultimate, d194d34
  • OS: macOS 27.0.1
  • CPU Architecture: arm64

Bug Description:
BinaryView::FindAllConstant can only find constants whose tokens report have a non-zero size. Many architectures don't populate the size for immediates within GetInstructionText.

Steps To Reproduce:

  1. Open an aarch64, armv7, thumb2, or MIPS binary.
  2. Switch to disassembly.
  3. Use the Find dialog with "Constant (Disassembly)" mode to search for a numeric constant that is visible within a function body.

Expected Behavior:
The constant that is clearly visible in the disassembly will be found.

Additional Information:
I'm not clear if the bug here is that BinaryView::FindAllConstant requires a token to have a non-zero size in order to match its value, or if the bug is that architectures aren't populating the size field for these tokens.

I can't find any documentation that indicates it is required for architectures to populate it, and the shape of the InstructionTextToken API in C++ has no way to require it for specific token types. That makes me lean towards BinaryView::FindAllConstant being at fault.

主要語言
C++
星號
1.3k
分支
304
平均合併
2 天 20 小時
30 天內合併 PR
10

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。