Binary Ninja applies the type of a data variable of a function type to a tail call to the variable, but not to a call
維護者通常 2 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 1-2 天
- 新手友好度
- 48/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- python
研究方向
Start by reviewing the medium level IL call and tail call behavior in the Binary Ninja analysis or type propagation code; the issue does not identify a source file or test. Reproduce with the supplied Python script on the arm64e /bin/ls slice and compare the call's one argument with the tail call's five. Done when the call uses the variable's function type, passes five arguments, and returns int64_t, with a regression test covering the case.
由索引模型根據 Issue 內容生成。
描述
The following issue was identified, triaged and written by Claude Opus 5.5, I have read through it to make sure the information is coherent and useful.
Version and Platform (required):
- Binary Ninja Version: 6.1.10957-dev (build 2899315201)
- Edition: Ultimate
- OS: macOS
- OS Version: 26.6.2 (25G83)
- CPU Architecture: Apple M2 Ultra
Bug Description:
In the steps below, a call (bl) and a tail call (b) both branch to 0x10000c010 in __data. A user data variable at that address has a function type with five parameters, and no function starts there. Binary Ninja applies the variable's type to the tail call, and the tail call passes five arguments. Binary Ninja does not apply the type to the call. In the medium level IL, the call passes one argument, x0_9. The call's destination has the type int64_t (*)(…), a pointer to the variable's function type.
Steps To Reproduce:
- Open
/bin/lsfrom macOS 26.6.2 (SHA-25624752389e1d97c9555dd153b644902fadd460dfbe1a166251876c67bbacb0810), and choose the arm64e slice. - Wait for analysis to finish.
- Run the following script in the Python console. The script defines a user data variable in
__data, with a function type that has five parameters. The script then rewrites one call to the stub of_strlenasbl <variable>, and the first instruction of the stub asb <variable>. The script writes to the binary view, not to the file on disk.
import struct
# A variable of a function type of five parameters, in `__data`. No function starts at its address.
target = bv.get_section_by_name("__data").start + 0x10
bv.define_user_data_var(target, bv.parse_type_string("int64_t (int64_t a, int64_t b, int64_t c, int64_t d, int64_t e)")[0])
print("variable:", hex(target), bv.get_data_var_at(target).type)
# The stub of `_strlen`, and the call to the stub at the lowest address.
stub = next(f for f in bv.functions if f.name == "_strlen" and f.start in bv.get_section_by_name("__auth_stubs"))
call = min((r for r in bv.get_code_refs(stub.start) if r.function.start != stub.start), key=lambda r: r.address)
# Rewrite the call as `bl <variable>`, and the stub's first instruction as `b <variable>`.
def branch(pc, destination, link):
return struct.pack("<I", (0x94000000 if link else 0x14000000) | (((destination - pc) >> 2) & 0x3FFFFFF))
bv.write(call.address, branch(call.address, target, True))
bv.write(stub.start, branch(stub.start, target, False))
bv.update_analysis_and_wait()
def call_at(function, address):
calls = ("MLIL_CALL", "MLIL_TAILCALL")
return next(i for i in function.mlil.instructions if i.address == address and i.operation.name.startswith(calls))
tail_call = call_at(stub, stub.start)
print("tail call in", stub.name, "@", hex(stub.start), ":", tail_call)
call_ins = call_at(call.function, call.address)
print("call in", call.function.name, "@", hex(call.address), ":", call_ins)
print("type of the call's destination:", call_ins.dest.expr_type)
- The script prints:
variable: 0x10000c010 int64_t(int64_t a, int64_t b, int64_t c, int64_t d, int64_t e)
tail call in _strlen @ 0x1000046d4 : return 0x10000c010(__s, b, c, d, e) __tailcall
call in sub_100001a78 @ 0x100001e48 : x0_10 = 0x10000c010(x0_9)
type of the call's destination: int64_t (*)(int64_t a, int64_t b, int64_t c, int64_t d, int64_t e)
The tail call passes five arguments, and the call passes one. The high level IL of sub_100001a78 reads void* x0_10 = (&data_10000c010)(a).
Expected Behavior:
Binary Ninja applies the type of the variable at the call's destination to the call, as it does to the tail call. The call in sub_100001a78 then passes five arguments and returns an int64_t.
Screenshots/Video Recording:
Not applicable. The script prints the medium level IL of both instructions.
Binary:
/bin/ls from macOS 26.6.2 (SHA-256 above). The steps use a binary that ships with macOS.
Additional Information:
- The section that contains the variable does not change the result. With the variable in
__constof__DATA_CONSTat0x1000084d0, in__bssat0x10000c1d0, or at the extern_strlenin.externat0x100018240, the tail call passes five arguments and the call passes one. - With the variable at the extern
_strlen, Binary Ninja does not apply the type to a call that it inlines from the stub either. Settargetto the address of the extern_strlenin.extern,0x100018240. Leave out the write ofbl <variable>, keep the write ofb <variable>at the stub, and setstub.inline_during_analysis = Truebeforebv.update_analysis_and_wait(). The inlined call insub_100001a78at0x100001e48readsx0_10 = 0x100018240()and does not pass any arguments. The tail call in_strlenstill passes five arguments. - After
call.function.reanalyze(), the call still readsx0_10 = 0x10000c010(x0_9).
- 主要語言
- C++
- 星號
- 1.3k
- 分支
- 304
- 平均合併
- 2 天 20 小時
- 30 天內合併 PR
- 10
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
Vector35/binaryninja-api 的其他 Issue
-
難度 1/5 1 小時以內 新手友好度 84/100
Vector35/binaryninja-api#8715 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
Vector35/binaryninja-api#8714 ·
維護者通常 2 天內回覆
-
難度 1/5 1 小時以內 新手友好度 85/100
Vector35/binaryninja-api#8713 ·
維護者通常 2 天內回覆
-
難度 1/5 1-3 小時 新手友好度 78/100
Vector35/binaryninja-api#8689 ·
維護者通常 2 天內回覆
-
Component: Python API
難度 2/5 1-3 小時 新手友好度 70/100
Vector35/binaryninja-api#8649 ·
維護者通常 2 天內回覆
查看 Vector35/binaryninja-api 的全部 Issue
相似的 Issue
-
Bug Core VIF
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 80/100
ESPresense/ESPresense#2680 · 2 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1 小時以內 新手友好度 75/100
stew675/llama-cpp-rdna-boosts#348 ·
維護者通常 1 天內回覆
-
Documentation: Add comprehensive newcomer onboarding guide, project structure, and local usage to README可能已有人在做 @Ash-Blanc 今天認領。 未關閉area/other status/bot-triaged status/need-triage
難度 2/5 半天 新手友好度 85/100
-
bug
難度 1/5 1 小時以內 新手友好度 85/100
維護者通常 1 天內回覆