[ppc64] Incorrect decompilation as a result of incorrect instruction width

未關閉
#8,671 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 2 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
68/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
cpp

研究方向

Start in arch/powerpc/il.cpp at the cmpw lifting code linked in the issue (around lines 766–772), then inspect how the comparison width is represented in the generated IL. Use the attached reproducer and compare its HLIL result with the expected 0xa. Done means the 32-bit comparison produces the correct condition and the decompilation selects 0xa.

由索引模型根據 Issue 內容生成。

描述

Arch: PowerPC Effort: Trivial Impact: Medium

Version and Platform (required):

  • Binary Ninja Version: 6.1.10926-dev Ultimate, 479fee2a
  • OS: macos
  • OS Version: 27.0.1
  • CPU Architecture: arm64

Bug Description:

10010158     0  38600001   li      r3, 0x1
1001015c     0  786307c6   sldi    r3, r3, 0x20  {0x100000000}      ; r3 = 0x0000_0001_0000_0000
10010160     0  38800001   li      r4, 0x1                          ; r4 = 1
10010164     0  7f832000   cmpw    cr7, r3, r4                      ; 32-bit signed compare of the low words
10010168     0  4fdcf382   cror    cr7eq, cr7lt, cr7eq              ; cr7.eq = cr7.lt | cr7.eq   (i.e. "<=")
1001016c     0  38e0000a   li      r7, 0xa
10010170     0  39000014   li      r8, 0x14
10010174     0  7c67479e   isel    r3, r7, r8, 0x1e  {0x0}  {0xa}  {0x14}   ; r3 = cr7.eq ? r7 : r8
10010178     0  4e800020   blr

This is incorrectly folded to the following by HLIL:

10010174        return 0x14

The expected result is 0xa, not 0x14.

Steps To Reproduce:
Open this binary ppc64_cmpw_cror.zip and let it analyze.

Additional Information:
I think this is due to cmpw being lifted to a 64-bit subtraction despite the operands only being 32-bits in size:

0 @ 10010158     0  (LLIL_SET_REG.q r3 = (LLIL_CONST.q 1))
1 @ 1001015c     0  (LLIL_SET_REG.q r3 = (LLIL_LSL.q (LLIL_REG.q r3) << (LLIL_CONST.q 0x20)))
2 @ 10010160     0  (LLIL_SET_REG.q r4 = (LLIL_CONST.q 1))
3 @ 10010164     0  (LLIL_SUB.q sub.q{cr7_signed}((LLIL_REG.d r3.d), (LLIL_REG.d r4.d)))

You can see that the lifter uses the address size for the size of the subtraction, despite the instruction being a 32-bit comparison:
https://github.com/Vector35/binaryninja-api/blob/dev/arch/powerpc/il.cpp#L766-L772

主要語言
C++
星號
1.3k
分支
304
平均合併
2 天 20 小時
30 天內合併 PR
10

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

Vector35/binaryninja-api 的其他 Issue

查看 Vector35/binaryninja-api 的全部 Issue

相似的 Issue

更多 C++ Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。