[Bug]: local/dsh-plugin — /loopforge and loopforge_status always throw "workingDirectory" without inject

未關閉 適合新手
#963 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
2/5
預估耗時
1-3 小時
新手友好度
75/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
javascript, node.js
領域
backend, tooling

研究方向

從 local/dsh-plugin/index.js 開始,追蹤 cwdOf() 以及它在 handle() 和 tool execute() 中的呼叫位置。閱讀 DSH workingDirectory 服務 API,確認它如何解析 Agent 的目錄,接著檢查外掛程式的 inject 宣告。當 /loopforge 和 loopforge_status 都能正常運作且不再出現 workingDirectory 注入錯誤,並且報告確認新專案會回傳 {"found": false}、/loopforge start 會建立 workflow-state.json 時,即告完成。

由索引模型根據 Issue 內容生成。

描述

Component / host

Local — DeepSeek Harness (local/dsh-plugin). The bug-report form has no option for this host yet — another item worth adding, see "Related observations".

Edition

Local Portable

LoopForge version

commit dd56585276d8ecb6e0d6865f55e255194d75f85a — local/dsh-plugin = @tencent/[email protected]

What happened?

The Host bundle installs and activates (application: applied, row @tencent/loopforge-dsh resolves), but both surfaces it registers fail on every call with:

Error: cannot get property "workingDirectory" without inject
  • the loopforge_status agent tool returns that error instead of {"found": false}
  • /loopforge ... goes through the same cwdOf(), so it fails the same way

So the plugin is unusable on DSH 0.2.2-rc.3, even on a project where the Portable skill is installed.

Reproduction
  1. Install the Portable skill into a project (see "Related observations" #1 for why npx -y loopforge-cli@latest cannot do this today):

    node <repo>/local/bin/loopforge.mjs skills install dsh --project-root <project>
    
  2. Install the bundle into a DSH profile:

    dsh plugin --profile <profile> add -w <repo>/local/dsh-plugin
    
  3. Restart DSH, then call the loopforge_status tool from the agent, or type /loopforge status.

  4. Observe Error: cannot get property "workingDirectory" without inject instead of a status result.

Cause

index.js reads workingDirectory as a context property:

const service = agent?.ctx?.workingDirectory
  ?? agent?.ctx?.get?.('workingDirectory')
  ?? owner?.ctx?.workingDirectory
  ?? owner?.ctx?.get?.('workingDirectory')

but declares only:

export const inject = ['commands', 'tools']

In Cordis, reading an un-injected service property throws rather than returning undefined, so the DSH_PROJECT_ROOT / process.cwd() fallbacks are never reached.

Separately, the Agent contract in DSH is { readonly id: SessionId }; workingDirectory.get(session) takes a Session, which the plugin does not have here. workingDirectory.ensure(agent) is the documented way to get a session's directory from an Agent.

Suggested fix
  1. Declare the service:

    export const inject = ['commands', 'tools', 'workingDirectory']
    
  2. Resolve the directory through the service API:

    async function cwdOf(ctx, owner) {
      const agent = owner?.agent ?? owner
      const service = ctx.workingDirectory
      if (agent && typeof service?.ensure === 'function') {
        try { return resolve(await service.ensure(agent)) } catch {}
      }
      return resolve(process.env.DSH_PROJECT_ROOT ?? service?.defaultDirectory ?? process.cwd())
    }
    
  3. await the two call sites — handle() and the tool's execute().

Verified with this patch on DSH 0.2.2-rc.3 (macOS arm64, Node 24.19.0, Python 3.13.3): the tool returns {"found": false} on a fresh project, and /loopforge start <request> creates artifacts/<slug>/workflow-state.json through the skill's scripts/workflow_state.py.

Diagnostics
DSH             0.2.2-rc.3 (desktop runtime), profile-managed
OS              macOS 15 arm64
node            v24.19.0
python3         3.13.3
bundle          @tencent/loopforge-dsh 0.1.0 (link: install from local dir)
error           Error: cannot get property "workingDirectory" without inject
Related
  • #112 / #120 — feature requests for a DSH host plugin, closed 2026-11-10. This bug is in the plugin that
    landed afterwards (local/dsh-plugin), so it is not a re-report of those.
  • Searched dsh and loopforge-dsh in existing issues: nothing covers this injection failure.
Related observations
  1. npm release lags the docs. npx -y loopforge-cli@latest skills install dsh fails with
    argument host: invalid choice: 'dsh' (choose from codebuddy, codex, cursor, claude) on
    [email protected] (published 2026-09-16), while docs/local/usage.md and
    local/dsh-plugin/README.md both document that exact command. local/src/devflow_cli/targets/dsh.py
    is already in the repo. Either cut a release or mark the DSH rows as "from source until the next release".
  2. Bundle assumes a project-local skill. SKILL_ROOT = '.dsh/skills/devflow' is hardcoded relative to
    the project, but DSH also scans the user root $DSH_HOME/skills. With the skill installed globally,
    /loopforge reports "Skill is not installed in this project". A project-first,
    $DSH_HOME/skills/devflow fallback would support both layouts. (The skill's Python also requires a
    sibling manifest.json in whatever skills root it lives in — DSH ignores that file, so it is safe to
    place there.)
  3. /devflow is not provided by this bundle. local/dsh-plugin/README.md lists /devflow <request>
    under "restart DSH and use", but the bundle registers only /loopforge; DSH surfaces skills through the
    skill tool/catalog rather than as slash commands. Splitting that list into "provided by this bundle" vs
    "provided by the skill install" would avoid the impression that both commands come from the plugin.
  4. Issue template. .github/ISSUE_TEMPLATE/bug_report.yml has no "Local — DeepSeek Harness" option
    under Component / host, although DSH is a documented supported host.
主要語言
Go
星號
711
分支
114
平均合併
1 天 10 小時
30 天內合併 PR
116

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

Tencent/LoopForge 的其他 Issue

查看 Tencent/LoopForge 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。