oracle-gaps: support oracles in a package other than the one they own (--source outside --package)

未關閉
#64 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

@KyleAMathews 已經在處理了。

開始於 2026年11月13日。

  • #70 來自 @KyleAMathews —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
28/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
javascript, node.js, vite

研究方向

Start in oracle-gaps/args.mjs near line 251, where --source is required to sit inside --package, and in oracle-gaps/check.mjs around lines 254, 396 and 600, where vite and vitest are resolved from --package. Decide how the package boundary is defined for a separate oracle package, and resolve Vitest from the oracle config directory. Done means a layout with oracles in tests/realtime-oracles importing packages/realtime/src runs the gap check, with keys and paths stable across OSes.

由索引模型根據 Issue 內容生成。

描述

Reported from an adopter's first session (a pnpm 10 workspace, Vitest 4.1, Node 26), at c58b0c2. Not yet reproduced here.

Problem. --source must be inside --package (oracle-gaps/args.mjs:251), and the CLI resolves vite and vitest from --package (oracle-gaps/check.mjs:254, :396, :600). Some workspaces keep their oracles in a separate package. For example, tests/realtime-oracles has its own Vitest 4.1 and imports packages/realtime/src. Neither choice of --package works there:

  • the oracle package doesn't contain the source;
  • the repo root has no Vitest.

Proposal.

  • Add a separate --root, or allow --source outside --package, still within one workspace.
  • Resolve Vitest from the directory of the oracle config.

Constraints. P6 says ownership stops at the package boundary, so define the boundary explicitly for this layout. Keys and paths must stay stable across OSes (see the Windows work in #58).

This issue was written by Isaac.

主要語言
JavaScript
星號
5
分支
1
平均合併
8 小時 31 分鐘
30 天內合併 PR
60

環境準備

這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TanStack/oracles 的其他 Issue

查看 TanStack/oracles 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。