On-demand collections drop rows for not(isUndefined(column)): the Electric and PowerSync compilers translate isUndefined to IS NULL

未關閉
#2,443 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
postgresql, sqlite, typescript
領域
database

研究方向

Begin at packages/db/src/query/compiler/evaluators.ts (isUndefined is === undefined) and compare the negation mapping in packages/electric-db-collection/src/sql-compiler.ts (L196-L214, L351) and packages/powersync-db-collection/src/sqlite-compiler.ts (L222-L243); the mapping is pinned in packages/electric-db-collection/tests/sql-compiler.test.ts L477-L484. Run the issue's repro first, then decide which side changes — the payload leaves that open. Done: not(isUndefined(note)) returns row 2 in both sync modes on both collections, with compiler tests updated.

由索引模型根據 Issue 內容生成。

描述

  • I've validated the bug against the latest version of DB packages

Describe the bug

The same live query returns different rows on an eager and on an on-demand collection when it contains not(isUndefined(column)). The on-demand collection never receives the rows whose column is NULL. This happens with both @tanstack/electric-db-collection and @tanstack/powersync-db-collection.

Cause: the live query engine and the SQL compilers give isUndefined different meanings.

  • In memory, isUndefined(v) is v === undefined, and isNull(v) is v === null. A NULL column reaches the query as null, so isUndefined(row.note) is false for it and not(isUndefined(row.note)) is true.
  • The compilers turn isUndefined into IS NULL: Electric (not(isUndefined(x)) becomes x IS NOT NULL, L196-L214), and PowerSync. The Electric mapping is pinned by a unit test, so it looks intentional.

The optimizer pushes the predicate into loadSubset, so the source is asked for "note" IS NOT NULL and the NULL rows are never loaded, although the query itself says they match.

Only negated forms lose rows. A positive isUndefined(col) makes the source send extra rows, which the query then filters out. isNull is consistent in both modes.

To Reproduce

Electric (Postgres 16 + electricsql/electric:1.6.0):

docker-compose.yml

services:
  postgres:
    image: postgres:16
    command: ["-c", "wal_level=logical"]
    environment:
      POSTGRES_PASSWORD: password
      POSTGRES_DB: repro
    ports: ["54399:5432"]
    healthcheck:
      test: ["CMD-SHELL", "pg_isready -U postgres -d repro"]
      interval: 1s
      retries: 30
  electric:
    image: electricsql/electric:1.6.0
    environment:
      DATABASE_URL: postgresql://postgres:password@postgres:5432/repro?sslmode=disable
      ELECTRIC_INSECURE: "true"
    ports: ["3199:3000"]
    depends_on:
      postgres:
        condition: service_healthy

repro.ts (docker compose up -d --wait && bun add @tanstack/[email protected] @tanstack/[email protected] pg && bun repro.ts)

import { createCollection, createLiveQueryCollection, isNull, isUndefined, not } from "@tanstack/db";
import { electricCollectionOptions } from "@tanstack/electric-db-collection";
import pg from "pg";

const pool = new pg.Pool({ connectionString: "postgresql://postgres:password@localhost:54399/repro" });
await pool.query(`DROP TABLE IF EXISTS notes`);
await pool.query(`CREATE TABLE notes (id integer PRIMARY KEY, note text)`);
await pool.query(`INSERT INTO notes VALUES (1, 'has a note'), (2, NULL)`);

type Note = { id: number; note: string | null };
const notes = (id: string, syncMode: "eager" | "on-demand") =>
  createCollection(
    electricCollectionOptions({
      id,
      getKey: (row: Note) => row.id,
      shapeOptions: { url: "http://localhost:3199/v1/shape", params: { table: "notes" } },
      syncMode,
    }),
  );

const predicates = {
  "isUndefined(note)": (note: any) => isUndefined(note),
  "not(isUndefined(note))": (note: any) => not(isUndefined(note)),
  "isNull(note)": (note: any) => isNull(note),
  "not(isNull(note))": (note: any) => not(isNull(note)),
};

for (const [name, predicate] of Object.entries(predicates)) {
  const ids: Record<string, Array<number>> = {};
  for (const syncMode of ["eager", "on-demand"] as const) {
    const query = createLiveQueryCollection({
      startSync: true,
      query: (q) =>
        q
          .from({ n: notes(`notes-${syncMode}-${name}`, syncMode) })
          .where(({ n }) => predicate(n.note))
          .select(({ n }) => ({ id: n.id })),
    });
    await query.preload();
    await new Promise((resolve) => setTimeout(resolve, 1500));
    ids[syncMode] = query.toArray.map((row) => row.id).sort();
  }
  const same = JSON.stringify(ids.eager) === JSON.stringify(ids["on-demand"]);
  console.log(`${name.padEnd(24)} eager: ${JSON.stringify(ids.eager).padEnd(6)} on-demand: ${JSON.stringify(ids["on-demand"]).padEnd(6)} ${same ? "" : "<-- DIFFERENT"}`);
}
await pool.end();
process.exit(0);

Output:

isUndefined(note)        eager: []     on-demand: []
not(isUndefined(note))   eager: [1,2]  on-demand: [1]    <-- DIFFERENT
isNull(note)             eager: [2]    on-demand: [2]
not(isNull(note))        eager: [1]    on-demand: [1]
PowerSync (no service needed, a local SQLite file)

bun add @tanstack/[email protected] @tanstack/[email protected] @powersync/[email protected] @powersync/[email protected] && node repro-powersync.ts

import { randomUUID } from "node:crypto";
import { tmpdir } from "node:os";
import { PowerSyncDatabase, Schema, Table, column } from "@powersync/node";
import { createCollection, createLiveQueryCollection, isNull, isUndefined, not } from "@tanstack/db";
import { powerSyncCollectionOptions } from "@tanstack/powersync-db-collection";

const APP_SCHEMA = new Schema({ notes: new Table({ note: column.text }) });
const db = new PowerSyncDatabase({
  database: { dbFilename: `repro-${randomUUID()}.sqlite`, dbLocation: tmpdir(), implementation: { type: "node:sqlite" } },
  schema: APP_SCHEMA,
});
await db.disconnectAndClear();
await db.execute(`INSERT INTO notes (id, note) VALUES ('1', 'has a note'), ('2', NULL)`);

const predicates = {
  "isUndefined(note)": (note: any) => isUndefined(note),
  "not(isUndefined(note))": (note: any) => not(isUndefined(note)),
  "isNull(note)": (note: any) => isNull(note),
  "not(isNull(note))": (note: any) => not(isNull(note)),
};

for (const [name, predicate] of Object.entries(predicates)) {
  const ids: Record<string, Array<string>> = {};
  for (const syncMode of ["eager", "on-demand"] as const) {
    const collection = createCollection(
      powerSyncCollectionOptions({ database: db, table: APP_SCHEMA.props.notes, syncMode }),
    );
    const query = createLiveQueryCollection({
      startSync: true,
      query: (q) =>
        q
          .from({ n: collection })
          .where(({ n }) => predicate(n.note))
          .select(({ n }) => ({ id: n.id })),
    });
    await query.preload();
    await new Promise((resolve) => setTimeout(resolve, 500));
    ids[syncMode] = query.toArray.map((row) => row.id).sort();
  }
  const same = JSON.stringify(ids.eager) === JSON.stringify(ids["on-demand"]);
  console.log(`${name.padEnd(24)} eager: ${JSON.stringify(ids.eager).padEnd(10)} on-demand: ${JSON.stringify(ids["on-demand"]).padEnd(10)} ${same ? "" : "<-- DIFFERENT"}`);
}
await db.close();
process.exit(0);
isUndefined(note)        eager: []         on-demand: []
not(isUndefined(note))   eager: ["1","2"]  on-demand: ["1"]      <-- DIFFERENT
isNull(note)             eager: ["2"]      on-demand: ["2"]
not(isNull(note))        eager: ["1"]      on-demand: ["1"]

Expected behavior

A live query returns the same rows whatever the collection's syncMode. Here not(isUndefined(note)) should include row 2 on the on-demand collection, as it does on the eager one.

Additional context

  • Versions: @tanstack/db, @tanstack/electric-db-collection and @tanstack/powersync-db-collection 1.0.0-rc.1.5 (the latest published; the code above is the same on main at 21c52a0), @electric-sql/client 1.5.28, @powersync/node 0.21.0, Node 24.14, Bun 1.4.
  • I did not find an existing issue for this. #574 and #685 are about isUndefined in left-join filters, which is a different case.
  • Which side should change is a design question, so I haven't picked one. Compiling isUndefined(column) to a constant FALSE would be wrong for a collection whose schema turns NULL into undefined (then IS NULL is correct). Making the evaluator treat null as undefined would change left-join behaviour. What does not depend on the schema is keeping predicates that contain isUndefined out of loadSubset's where, so the source loads a superset, but I haven't tried that in the optimizer.
  • Happy to send a PR once there is a preferred direction.
主要語言
TypeScript
星號
4k
分支
286
平均合併
1 天 1 小時
30 天內合併 PR
104

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

TanStack/db 的其他 Issue

查看 TanStack/db 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。