Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

persistedCollectionOptions without a schema can't be passed to createCollection (follow-up to #1452)

未關閉
  • 哪裡不對？
#2,255 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
68/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript
領域
developer-experience, testing

研究方向

Start with the persistedCollectionOptions type definitions and the existing type tests in persisted.test-d.ts; the issue says the test "preserves sync-present utility typing" passes never explicitly. Add coverage for the inferred no-schema form used with createCollection, including the guide's Query Collection pattern. Done means the inferred form type-checks without spelling out never, and the type tests pass.

由索引模型根據 Issue 內容生成。

描述

Describe the bug

Wrapping a synced source that has no schema with persistedCollectionOptions fails to type-check when the schema type argument is left to inference. The result can't be passed to createCollection. That includes the Query Collection example in the SQLite persistence guide, as written.

Versions: @tanstack/db 0.15.2, @tanstack/browser-db-sqlite-persistence 0.2.37, TypeScript 7.0.2 (also reproduces on 5.9), strict mode. persisted.ts, types.ts and the collection source are unchanged on main at d2935d0.

To reproduce

import { createCollection, type CollectionConfig } from '@tanstack/db'
import {
  createBrowserWASQLitePersistence,
  persistedCollectionOptions,
  type BrowserWASQLiteDatabase,
} from '@tanstack/browser-db-sqlite-persistence'

type Todo = { id: string; title: string; completed: boolean }
declare const database: BrowserWASQLiteDatabase
const persistence = createBrowserWASQLitePersistence({ database })

const source: CollectionConfig<Todo, string> = {
  id: 'rows',
  getKey: (row) => row.id,
  sync: { sync: ({ markReady }) => markReady() },
}

// Fails with TS2769: No overload matches this call.
//   Types of property 'schema' are incompatible.
//   Type 'StandardSchemaV1<unknown, unknown> | undefined' is not assignable to type 'undefined'.
createCollection(
  persistedCollectionOptions({ ...source, persistence, schemaVersion: 1 }),
)

// Compiles:
createCollection(
  persistedCollectionOptions<Todo, string, never>({ ...source, persistence, schemaVersion: 1 }),
)

The guide's example (persistedCollectionOptions<Todo, string>({ ...queryCollectionOptions<Todo, string>({...}), persistence, schemaVersion: 1 })) fails the same way, with Type 'Todo' is not assignable to type 'undefined' on schema.

Expected behavior

A source without a schema should compose with createCollection without spelling out never, as the guide shows.

Notes

When the schema type isn't given, the sync-wrapped overload infers StandardSchemaV1<unknown, unknown> for it, and createCollection's no-schema overload rejects the result. #1866 fixed the schema case from #1452, but the no-schema case still fails. The type test in persisted.test-d.ts ("preserves sync-present utility typing") passes never explicitly, so the inferred form and the guide's example aren't covered. Adding them to the type tests, or passing never in the guide, would close the gap.

I found this while composing the Convex collection from #2230 with SQLite persistence. That PR is not the cause. It type-checks and runs once never and the adapter's utils type are passed explicitly.

主要語言
TypeScript
星號
4k
分支
277
平均合併
1 天 2 小時
30 天內合併 PR
213

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

TanStack/db 的其他 Issue

查看 TanStack/db 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。