Suggestion to inform users that default_root behaviour has changed.
還沒有人認領這個 Issue。
評估
研究方向
Start in command_base.py and inspect how default_root and the per-command settings new_file_default_root, rename_file_default_root, and copy_file_default_root are read. Confirm the intended fallback when a per-command key is absent, while preserving explicitly configured per-command roots. Done means existing default_root configurations continue to work and individual roots can still be customized.
由索引模型根據 Issue 內容生成。
描述
Hi Scott,
I just figured out that default_root: project_root no longer works, and that as of 1.5.1 you need to set up individual settings for default_root in for each of the new, move, copy commands:
new_file_default_root
rename_file_default_root
copy_file_default_root
Here in command_base.py, could I suggest that you check for existence of the above keys in settings, and if not, then use the original default_root settings? This would allow the current installations to continue to work as is but allow fine tuning of roots if needed.
My Python has pretty much gone by the wayside as I haven't touched it since my 2 week stint last year, but something like this (excuse the Ruby-like code). I can't remember if self.settings.get returns nil or blank string, but something along these lines.
def _get_default_root(self):
root_setting_value = self.get_default_root_setting()
root_setting = self.settings.get(root_setting_value) || self.settings.get(DEFAULT_ROOT_SETTING)
if root_setting == DEFAULT_ROOT_SETTING:
return self.settings.get(DEFAULT_ROOT_SETTING)
return root_setting
Keep up the great work! I use ANF every single day I code!
Brian
- 主要語言
- Python
- 星號
- 833
- 分支
- 96
- 平均合併
- 1 分鐘
- 30 天內合併 PR
- 5
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
SublimeText/AdvancedNewFile 的其他 Issue
-
enhancement
難度 4/5 3-5 天 新手友好度 35/100
SublimeText/AdvancedNewFile#196 · 1 個 reaction ·
-
enhancement
難度 4/5 3-5 天 新手友好度 45/100
SublimeText/AdvancedNewFile#195 ·
-
難度 3/5 1-2 天 新手友好度 35/100
SublimeText/AdvancedNewFile#193 ·
-
enhancement
難度 4/5 3-5 天 新手友好度 25/100
SublimeText/AdvancedNewFile#183 · 2 則留言 ·
-
難度 3/5 1-2 天 新手友好度 42/100
SublimeText/AdvancedNewFile#180 ·
查看 SublimeText/AdvancedNewFile 的全部 Issue
相似的 Issue
-
bug needs-triage priority:medium
難度 2/5 1-3 小時 新手友好度 86/100
yeongseon/azure-functions-logging-python#583 ·
維護者通常 1 天內回覆
-
documentation needs-triage priority:medium
難度 2/5 1-3 小時 新手友好度 85/100
yeongseon/azure-functions-validation-python#546 ·
維護者通常 1 天內回覆
-
PHP workflow streaming requests buffer the full SSE response可能已有人在做 @Winoren 今天認領。 未關閉review: medium
難度 2/5 1-3 小時 新手友好度 84/100
langgenius/dify#44270 · 1 則留言 · 1 個 reaction ·
維護者通常 1 天內回覆
-
P4: low
難度 2/5 1-3 小時 新手友好度 82/100
jeffknupp/association#523 ·
-
bug help wanted
難度 2/5 1-3 小時 新手友好度 65/100
DarkStarSystems/pcons#229 ·
維護者通常 1 天內回覆