Gem `vex` checks the `gem env gemdir` copy instead of the `Gem.path` copy Ruby loads, so it attests `not_affected` while an unpatched `--user-install` / `GEM_PATH` copy runs
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start with crates/socket-patch-core/src/crawlers/ruby_crawler.rs:236-263 and inspect how gem_env_gems_dirs orders gemdir and gempath. Then read crates/socket-patch-cli/src/commands/vex.rs:556 and the gem rule in vex_consumed.rs. Reproduce the user-install or GEM_PATH case, and consider the issue complete when manifest-basis VEX results reflect the copy RubyGems and Bundler load, including the reverse-direction case.
由索引模型根據 Issue 內容生成。
描述
[agent] Found by the scheduled Bundler (RubyGems) bug-hunt routine (ledger #316).
Summary
When one gem@version is installed in more than one gem home, vex (agent / manifest basis, with or without -g) verifies only the first copy the ruby crawler lists. That's always the gem env gemdir home (the Ruby install's gem dir, or GEM_HOME). RubyGems and Bundler load the copy from the first Gem.path entry instead. Gem.path lists the user gem dir (gem install --user-install) and every GEM_PATH entry before GEM_HOME. So when the loaded copy is unpatched and the gemdir copy is patched, vex writes not_affected for code that is actually vulnerable at runtime. In the reverse case (loaded copy patched, gemdir copy not), it refuses to attest a patched install.
apply / get / rollback are fine. They fan out to every copy (#222), so right after get -g both copies are patched. The bug appears as soon as the loaded copy is reinstalled: gem install --user-install <gem> again, gem pristine --user-install, or a reinstall into a GEM_PATH home.
Impact
A false OpenVEX not_affected statement (inline_mitigations_already_exist) for a package whose loaded code is unpatched. This is the "VEX attestation for a patch that isn't actually applied" class. It hits both vex -g and plain vex in a Bundler project that uses system gems (no BUNDLE_PATH), because bundle exec also loads the user-dir copy.
Repro (Linux; a local mock of the patch API serves one patch for [email protected] that appends # SOCKET-PATCHED to lib/colorize.rb)
gem install colorize -v 0.8.1 --no-document # system gem home (gem env gemdir)
gem install --user-install colorize -v 0.8.1 --no-document # ~/.local/share/gem/ruby/X (first in Gem.path)
SP="socket-patch --api-url http://127.0.0.1:18999 --api-token fake --org org"
$SP get -g 11111111-2222-4333-8444-555555555555 --yes # patches BOTH copies (2 "Patched packages" lines)
gem install --user-install colorize -v 0.8.1 --no-document # user reinstalls -> the copy Ruby loads is pristine again
ruby -e 'require "colorize"; f=$LOADED_FEATURES.grep(/colorize.rb/)[0]; puts f, File.read(f)[/SOCKET-PATCHED/] ? "PATCHED" : "UNPATCHED"'
# /root/.local/share/gem/ruby/3.3.0/gems/colorize-0.8.1/lib/colorize.rb
# UNPATCHED
$SP vex -g --product pkg:gem/[email protected] --output vex.json
# Using ruby gem paths at: /opt/rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems
# Wrote OpenVEX document with 1 statement (exit 0)
grep -o '"status": "[a-z_]*"' vex.json
# "status": "not_affected"
The same thing happens with:
- an explicit
GEM_HOME=/tmp/gh GEM_PATH=/tmp/gp(Ruby loads/tmp/gp/...,vex -gchecks/tmp/gh/...); - a plain Bundler project (
gem "colorize", "0.8.1", noBUNDLE_PATH) withget <uuid> --mode agentand thenvex.bundle execloads the user-dir copy, andvexstill saysnot_affected.
Reverse direction: when only the loaded user copy is patched, vex -g says omitting … (not_applied) and exits 1.
Expected vs actual
- Expected:
vexonly attests what's applied to the code that runs.crates/socket-patch-cli/src/commands/vex_consumed.rsalready states the gem rule for hosted-basis purls: "bundler loads whicheverGem.pathhome it hits first: ALL must verify". #222 also says the single-representative consumers pick "the copy bundler actually loads". - Actual: for manifest-basis purls,
vexhashes only the crawler's first copy, and for gem homes that's always thegemdircopy, which isn't the oneGem.pathresolves first.
OS × version (probe run below, plus local Linux)
| OS | Ruby / RubyGems / Bundler | Gem.path[0] (loaded) |
vex -g after user-copy reinstall |
|---|---|---|---|
| Linux (sandbox) | 3.3.6 / 3.5.22 / 4.0.17 | ~/.local/share/gem/ruby/3.3.0 |
not_affected (also via GEM_PATH and plain vex) |
| ubuntu-latest | 2.7.8 / 3.1.6 / 2.4.22 | ~/.gem/ruby/2.7.0 |
not_affected |
| ubuntu-latest | 3.3.10 / 3.5.22 / 2.5.22 | ~/.local/share/gem/ruby/3.3.0 |
not_affected |
| ubuntu-latest | 3.4.9 / 3.6.9 / 2.6.9 | ~/.local/share/gem/ruby/3.4.0 |
not_affected |
| macos-latest (arm64) | 2.7.8 / 3.1.6 / 2.4.22 | ~/.gem/ruby/2.7.0 |
not_affected |
| macos-latest (arm64) | 3.3.10 / 3.5.22 / 2.5.22 | ~/.local/share/gem/ruby/3.3.0 |
not_affected |
| macos-latest (arm64) | 3.4.9 / 3.6.9 / 2.6.9 | ~/.local/share/gem/ruby/3.4.0 |
not_affected |
| windows-latest | 2.7 / 3.3 / 3.4 | user gem dir | not reached: global discovery itself is broken on Windows (#421) |
First bad version
This isn't a v5 regression. gem_env_gems_dirs already put gemdir first in v4.0.0 and v3.3.0 (checked in the source only).
Suspect code
crates/socket-patch-core/src/crawlers/ruby_crawler.rs:236-263(gem_env_gems_dirs) pushesgem env gemdirfirst and then appendsgem env gempath(which is already inGem.pathorder and starts with the user dir /GEM_PATH). Usinggempathorder alone (it always containsgemdir) would match RubyGems.crates/socket-patch-cli/src/commands/vex.rs:556(collapse_to_first) verifies manifest-basis gem purls against one copy only. The hosted path invex_consumed.rsalready requires every gem copy to verify.
Probe run (macOS/Windows/Linux × Ruby 2.7/3.3/3.4): https://github.com/SocketDev/socket-patch/actions/runs/36816092864
- 主要語言
- Rust
- 星號
- 8
- 分支
- 0
- 平均合併
- 18 小時 4 分鐘
- 30 天內合併 PR
- 70
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
SocketDev/socket-patch 的其他 Issue
-
agent:triaged bug bughunt pm:composer priority:p2
難度 2/5 1-3 小時 新手友好度 90/100
SocketDev/socket-patch#515 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:npm priority:p1
難度 2/5 1-3 小時 新手友好度 82/100
SocketDev/socket-patch#464 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:npm priority:p1
難度 2/5 1-3 小時 新手友好度 82/100
SocketDev/socket-patch#433 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:uv priority:p1
難度 2/5 1-3 小時 新手友好度 78/100
SocketDev/socket-patch#408 · 1 則留言 ·
維護者通常 1 天內回覆
-
agent:triaged bug bughunt pm:yarn-berry priority:p1
難度 2/5 1-3 小時 新手友好度 82/100
SocketDev/socket-patch#370 · 2 則留言 ·
維護者通常 1 天內回覆
查看 SocketDev/socket-patch 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 86/100
dani-garcia/vaultwarden#7801 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 90/100
boxlite-ai/boxlite#1814 ·
維護者通常 1 天內回覆
-
tech-debt
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 88/100
xingkongliang/skills-manager#516 ·
維護者通常 5 天內回覆