[Bug] RT-Thread DM365 SPI divides by an unchecked zero clock rate
維護者通常 1 天內回覆
評估
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 新手友好度
- 68/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- c
- 領域
- embedded-iot
研究方向
閱讀 bsp/dm365/drivers/spi-davinci.c 中 davinci_spi_get_prescale() 和 davinci_spi_setup_transfer() 附近的程式碼，接著追蹤 components/drivers/spi/dev_spi_core.c 中的設定呼叫。新增速率為零的設定案例，並在任何傳輸發生前涵蓋支援的速度限制。完成條件是：設定變更後若 max_hz == 0，須在除法前拒絕該設定；有效速率則仍可成功設定。
由索引模型根據 Issue 內容生成。
描述
RT-Thread Version
v5.3.0
Affected area
Other / Not sure
Hardware/BSP vendor
Not applicable / Other
Architecture
Not applicable / Other
Board and hardware details
DM365 SPI
Develop Toolchain
Other
Describe the bug
RT-Thread DM365 SPI divides by an unchecked zero clock rate
Affected version
RT-Thread v5.3.0.
Describe the bug
davinci_spi_get_prescale() divides by the requested SPI frequency without rejecting zero. rt_spi_configure() copies max_hz into the device configuration and asks the bus to apply it.
An unchanged configuration returns before that call. A request that changes another field, such as data width 9, with max_hz == 0 does not. rt_spi_bus_configure() calls the driver only when this device currently owns the bus.
davinci_spi_setup_transfer() accepts data widths 2 through 16, copies cfg->max_hz, and calls the prescaler:
#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
ret = DIV_ROUND_UP(clk_get_rate(dspi->clk), max_speed_hz);
The prescaler clamps the result only after that division. A zero frequency is not turned into a default speed on this path.
Locations:
bsp/dm365/drivers/spi-davinci.c:35
bsp/dm365/drivers/spi-davinci.c:267
bsp/dm365/drivers/spi-davinci.c:272
bsp/dm365/drivers/spi-davinci.c:298
bsp/dm365/drivers/spi-davinci.c:313
bsp/dm365/drivers/spi-davinci.c:333
bsp/dm365/drivers/spi-davinci.c:788
components/drivers/spi/dev_spi_core.c:211
components/drivers/spi/dev_spi_core.c:277
components/drivers/spi/dev_spi_core.c:288
Threat model
The boundary is a caller of rt_spi_configure(device, cfg). This report does not treat a network peer or a byte on the SPI bus as the attacker. The value that reaches the division is cfg->max_hz. The caller also supplies cfg->mode and cfg->data_width. The clock rate returned for the controller is not caller input.
max_hz is a rt_uint32_t. Zero is the unsafe value. The core returns before calling the driver when mode, data width, and max_hz are all unchanged, so a request that only repeats the current configuration does not divide. A request that changes another field, such as setting data_width to 9 while leaving max_hz at 0, does reach the driver. data_width must also be 2 through 16 or the driver returns before the division. rt_spi_bus_configure() calls the driver only when this device currently owns the bus.
There is no shell command in this path. The entry is whatever product code can submit an SPI configuration: a trusted driver caller, or an untrusted service that forwards a frequency into rt_spi_configure().
Steps to reproduce
I have not reproduced this on DM365 hardware. The reduced check keeps the round-up macro and a positive clock.
#include <stdint.h>
#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d))
static int prescale(uint32_t max_hz)
{
return DIV_ROUND_UP(48000000u, max_hz);
}
int main(void)
{
return prescale(0);
}
Compile it with an undefined-behavior sanitizer, for example:
clang -fsanitize=undefined -g -O1 repro.c -o repro && ./repro
Returning an error when max_hz == 0, before the division, avoids the report. Positive rates such as 500 kHz complete the division.
Relevant log output
runtime error: division by zero
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
Impact
A caller that can submit an SPI configuration for a DM365 SPI device, with a supported data width and a zero max_hz, reaches a division by zero in the driver when that device owns the bus. The reduced check shows the arithmetic fault. It does not show the processor exception on DM365 hardware, and this API is not by itself a network input.
Suggested fix
Reject zero before calling the prescaler, and keep a zero check inside the helper. If zero is intended to mean a default speed, resolve it to an explicit frequency first. Test a changed configuration whose max_hz is zero, plus the supported speed limits, before any transfer.
Other additional context
No response
- 主要語言
- C
- 星號
- 12.3k
- 分支
- 5.5k
- 平均合併
- 4 天 9 小時
- 30 天內合併 PR
- 37
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
RT-Thread/rt-thread 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 67/100
RT-Thread/rt-thread#11951 · 1 則留言 ·
維護者通常 1 天內回覆
-
bug
難度 2/5 1-3 小時 新手友好度 72/100
RT-Thread/rt-thread#11949 · 1 則留言 ·
維護者通常 1 天內回覆
-
[Bug] RT-Thread AB32 ADC uses an unchecked channel as a register index可能已有人在做 @usualtreee 於 3 天前認領。 未關閉bug Component component: drivers
難度 2/5 1-3 小時 新手友好度 72/100
RT-Thread/rt-thread#11948 · 1 則留言 ·
維護者通常 1 天內回覆
-
[Bug] [libc] timer_gettime 拆秒前将总纳秒截断为 uint32_t，剩余时间查询错误可能已有人在做 @Yunlk 於 10 天前認領。 未關閉in progress
難度 2/5 1-3 小時 新手友好度 68/100
RT-Thread/rt-thread#11924 · 7 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
-
[Bug] dfs_v2 tmpfs: ftruncate(fd, 0) frees the file buffer but reports success — use-after-free read/write and double free from a legal POSIX call可能已有人在做 @remukisama 於 14 天前認領。 未關閉in progress
難度 2/5 1-3 小時 新手友好度 78/100
RT-Thread/rt-thread#11902 · 4 則留言 · 已指派 1 人 ·
維護者通常 1 天內回覆
查看 RT-Thread/rt-thread 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 70/100
meshcore-dev/MeshCore#3760 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
ly05010419/MacNativeGames#1697 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 70/100
colbymchenry/codegraph#3228 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
aminya/project_options#303 ·
-
難度 2/5 1-3 小時 新手友好度 90/100
維護者通常 1 天內回覆