deps: replace vendored refresh_rate 1.0.2 with upstream 2.0.1
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 42/100
研究方向
Start by verifying the refresh_rate publisher transfer and reviewing the native diff from 1.0.2 to 2.0.1, especially the Linux, Windows, and macOS changes. Then inspect pubspec.yaml, third_party/refresh_rate/, third_party/README.md, and lib/core/motion/display_refresh_service.dart; finish by checking CI on Linux, Windows, and macOS and confirming the dependency override and vendored copy are removed.
由索引模型根據 Issue 內容生成。
描述
Summary
third_party/refresh_rate is a vendored copy of refresh_rate 1.0.2 kept only for two build fixes. Upstream 2.0.1 appears to fix both natively, so the fork can likely be dropped in favour of refresh_rate: ^2.0.1.
Why the fork exists vs. 2.0.1
| Reason for the fork | In 2.0.1 |
|---|---|
Linux -Werror: uninitialized rates[0] |
Linux plugin rewritten on generated Pigeon GObject bindings; the hand-rolled rates array is gone |
macOS SPM: Package.swift pointed at ../Classes, outside the package root (#555) |
Package.swift uses path: "Sources/refresh_rate" inside the package |
App compatibility
Only lib/core/motion/display_refresh_service.dart uses the package.
RefreshRate.enable()now returnsFuture<RateRequestResult>; we call it unawaited (wrap inunawaited(...)if the lint is on).showHz()andinfo.{currentRate,maxRate,isVariableRefreshRate}are source-compatible.DisplayRefreshService.currentHz/maxHzhave no other callers.
Behaviour changes: on Linux maxRate is 0.0 (was max across monitors) and unknown values no longer fall back to 60 Hz. info is populated asynchronously, so the first debug log may show 0 Hz.
Tasks
- Verify the package publisher:
repositorymoved fromqoder-official/refresh_ratetoafewgoodcoders/refresh_ratewhile the Android package is stillin.qoder.refresh_rate. Confirm it is a legitimate transfer and skim the native diff 1.0.2 → 2.0.1 (Windows and macOS changed too). -
pubspec.yaml:refresh_rate: ^2.0.1, remove therefresh_rateentry fromdependency_overrides. - Delete
third_party/refresh_rate/and updatethird_party/README.mdif it references it. - CI green on Linux (
-Werror), Windows and macOS. - Follow-up, separate PR: reconsider
flutter.config.enable-swift-package-manager: false. It disables SPM for all plugins, not just this one.
Fallback
If the Linux -Werror build or Windows/macOS breaks on upstream 2.0.1, keep the fork and re-vendor 2.0.1 with only the needed patch.
Found during the dependency review.
- 主要語言
- Dart
- 星號
- 23
- 分支
- 1
- 平均合併
- 31 分鐘
- 30 天內合併 PR
- 570
環境準備
在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
QueryaHub/Querya-Desktop 的其他 Issue
-
enhancement ui
難度 2/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1689 ·
維護者通常 1 天內回覆
-
ui(dialogs): make destructive query and DML preview dialogs adaptive and prevent table name overflow未關閉bug frontend
難度 2/5 1-3 小時 新手友好度 82/100
QueryaHub/Querya-Desktop#1642 ·
維護者通常 1 天內回覆
-
bug error-handling settings
難度 1/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1637 ·
維護者通常 1 天內回覆
-
enhancement
難度 1/5 1 小時以內 新手友好度 88/100
QueryaHub/Querya-Desktop#1636 ·
維護者通常 1 天內回覆
-
enhancement marketplace
難度 2/5 1-3 小時 新手友好度 78/100
QueryaHub/Querya-Desktop#1635 ·
維護者通常 1 天內回覆
查看 QueryaHub/Querya-Desktop 的全部 Issue
相似的 Issue
-
type:bug
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 2 天內回覆
-
Standalone dash flashes as its own RSVP step (e.g. Russian dialogue)可能已有人在做 @bezig01 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
daniel-pimenta-cc/ledor#53 ·
-
難度 2/5 1-3 小時 新手友好度 62/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 75/100
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 84/100