Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

fix(redis): explorer views share one socket, so SELECT + command is not atomic; folder delete can hit another DB

未關閉
  • 哪裡不對？
#1,569 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
35/100
Issue 類型
缺陷
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
dart, redis
領域
backend, database

研究方向

Start with lib/core/database/redis_service.dart and lib/core/database/redis_connection.dart to trace socket sharing and database selection, then read lib/features/redis/redis_keys_view.dart and redis_cli_workspace.dart for the affected operations. Reproduce the interleaving described in the issue and inspect the existing Redis connection tests. Done means database selection and commands cannot interfere across views or the CLI, with regression coverage for both reported cases.

由索引模型根據 Issue 內容生成。

描述

backend bug connections P1 stability

Problem

RedisService.acquire keys sockets by connectionId::role (lib/core/database/redis_service.dart:26). Every Redis explorer for a connection, for any database index, uses the same explorer socket. Views select the database with a separate command before working:

await widget.connection.selectDatabase(widget.database); // SELECT n
await widget.connection.delMany(keys);                    // DEL ... (several round trips)

SELECT is socket state, and the pair is not atomic. Anything else that runs on the socket between the two awaits changes the database the next command hits.

1. Folder delete can delete keys in another database (data loss)

RedisKeysView._deleteFolder (lib/features/redis/redis_keys_view.dart:218-225) selects the DB once, then delMany (lib/core/database/redis_connection.dart:749-761) sends sequential DEL chunks of 200, awaiting each.

Steps: open db0, load a folder with more than 200 keys, Delete folder, then while it runs click db3 in the tree. The workspace replaces the explorer (ValueKey('redis_<id>_db_3'), workspace_panel.dart:363). The old view is disposed but its delMany loop keeps going (no cancellation). The new view sends SELECT 3 + SCAN on the same socket, and the remaining DEL chunks run in db3, deleting any keys there with the same names.

2. The CLI runs commands in a database other than the one it shows

RedisCliWorkspace tracks _currentDb only when the user types SELECT (redis_cli_workspace.dart:487-490) and sends every other command as is (:512). The key editor and keys view in the same explorer re-select widget.database before each operation. After SELECT 3 in the CLI, opening any key moves the socket back to db0. The CLI prompt still says db3, but the next DEL / FLUSHDB runs in db0.

3. delMany itself
  • DEL frees large values synchronously and blocks the Redis event loop. UNLINK (Redis >= 4.0) is not used anywhere in the codebase.
  • Chunks are sent one after another although the class already pipelines in typesAndTtls.
  • On a failure midway the UI does not know which keys are gone: _keys is not updated and the error hides the partial delete.

Fix

  • Make "select DB + command(s)" atomic: either one socket per (connectionId, role, db) (no SELECT switching at all), or a per-socket async lock with runInDb(db, () async {...}) that issues SELECT inside the lock. One socket per DB is the simpler model; the CLI then gets its own socket and SELECT there only moves the CLI.
  • delMany: UNLINK with fallback to DEL on ERR unknown command, pipeline the chunks, stop when the owner is disposed (cancel token), return the count/keys actually removed and reload the list on partial failure.
  • Add UNLINK to RedisConnectionTestFake (redis_connection.dart:817).
  • Tests: interleaved SELECT from a second user of the socket during delMany; CLI SELECT 3 followed by an editor action.
主要語言
Dart
星號
23
分支
1
平均合併
31 分鐘
30 天內合併 PR
570

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

QueryaHub/Querya-Desktop 的其他 Issue

查看 QueryaHub/Querya-Desktop 的全部 Issue

相似的 Issue

更多 Dart Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。