fix(extensions): a failed upgrade deletes the working extension; local and marketplace installs differ

已關閉
#1,562 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
45/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
dart, flutter
領域
desktop, devtools

研究方向

Start with lib/core/extensions/local_extension_installer.dart around lines 125–172 and compare its archive extraction and rollback with HttpMarketplaceRepository.install. Trace validateDriverPackage, ensureDriverExecutables, and common-root stripping to identify how both install paths handle files. Done means both use one path that stages and validates the new extension, swaps it in safely, restores the old version on failure, and removes files absent from the new version.

由索引模型根據 Issue 內容生成。

描述

bug marketplace P2 stability

Problem

LocalExtensionInstaller.installFromArchive deletes the existing extensions/<id>/ before extracting (lib/core/extensions/local_extension_installer.dart:125-128). If validateDriverPackage / ensureDriverExecutables / extraction then fails, the rollback deletes the new folder too (:163-172), so a failed upgrade destroys the working extension.

The marketplace path (HttpMarketplaceRepository.install) goes the other way: it never cleans the old folder, so files removed in the new version stay on disk and versions get mixed. The two paths also differ in common-root stripping.

Expected

  • Extract into a temp sibling directory, validate there, then swap (rename old to backup, rename new, delete backup; restore backup on failure).
  • Use the same code path for local and marketplace installs.
主要語言
Dart
星號
23
分支
1
平均合併
57 分鐘
30 天內合併 PR
475

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

QueryaHub/Querya-Desktop 的其他 Issue

查看 QueryaHub/Querya-Desktop 的全部 Issue

相似的 Issue

更多 Dart Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。