Set-PSReadLineOption BellStyle should have an option for an actual ASCII 7 bell
還沒有人認領這個 Issue。
評估
研究方向
Start by locating Set-PSReadLineOption BellStyle and the existing Audible, Visual, and None handling. Review the linked Windows Terminal bell-style documentation alongside the current behavior. Done should include a selectable style that emits an ASCII 0x07 bell and a clear decision about the proposed default change.
由索引模型根據 Issue 內容生成。
描述
Prerequisites
- Write a descriptive title.
Description of the new feature/enhancement
Hello,
I just realized this today but, even in the latest PSReadLine 2.3.6 when I configure the "Bell notification style" in Windows Terminal to, for example, ["window", "taskbar"] (briefly flash the console screen + taskbar icon) instead of audible (make the irritating pcspeaker noise) PSReadLine does not honor this setting - it still makes a sharp blip-like sound. I'm guessing PSReadLine does not emit an actual ASCII 0x7 BELL but rather implements its own sound playback.
This is very bad because:
- For the user it is unexpected behavior for a program emitting a BELL to not adhere to the terminals configured treatment of BELL signals
- PSReadLines only BELL configuration options are "Audible" (default), "Visual" and "None" but the hosting terminal application can have more abilities to indicate a BELL
- PSReadLine in practice really only has "Audible" and "None" as BellStyles because, at least on my machine, "Visual" does absolutely nothing making it equivalent to "None"
- Whatever custom BELL implementation PSReadLine has, it's got to be more lines of code than
putchar(7);arguably making it a code smell and unnecessary bloat?
Proposed technical implementation details (optional)
I propose to add a BellStyle option that just makes PSReadLine, well, emit an actual 0x07 BELL. Also, I would very much like for this BellStyle (call it -BellStyle ASCIIBell or whatever) to be the new default BellStyle. Users who unironically prefer the eardrum-shattering, high-pitched blip of the current implementation can always change it back to Audible.
EDIT: Link to Windows Terminal BELL style configuration docs: https://learn.microsoft.com/en-us/windows/terminal/customize-settings/profile-advanced#bell-notification-style
- 主要語言
- C#
- 星號
- 4.4k
- 分支
- 342
- PR 合併指標
- 30 天內沒有已合併 PR
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
PowerShell/PSReadLine 的其他 Issue
-
Get-PSReadLineOption emits the ListView window-size warning, so prompt modules trigger it on every shell start可能已有人在做 @thc1006 於 40 天前認領。 未關閉Needs-Triage :mag:
難度 2/5 1-3 小時 新手友好度 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
難度 2/5 1-3 小時 新手友好度 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
難度 2/5 1-3 小時 新手友好度 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
難度 2/5 1-3 小時 新手友好度 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
難度 1/5 1 小時以內 新手友好度 68/100
PowerShell/PSReadLine#3470 · 3 個 reaction ·
查看 PowerShell/PSReadLine 的全部 Issue
相似的 Issue
-
VideoViewer: rotated (portrait phone) videos shown sideways when system decimal separator is a comma未關閉
難度 2/5 1-3 小時 新手友好度 78/100
-
難度 2/5 1-3 小時 新手友好度 68/100
Volodymyr-Petrunin/Bankomaten#45 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
AvaloniaUI/Avalonia#22420 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 90/100
dotnet/SqlClient#4823 · 1 則留言 ·
維護者通常 2 天內回覆
-
type/automation type/tech-debt
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆