Remove household_options from the country metadata

已關閉
  • 哪裡不對？
#4,209 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 2 天內回覆

已經有一個關聯 PR 被合併了。

  • #4210 來自 @anth-volk —— 已合併

評估

難度
3/5
預估耗時
1-2 天
新手友好度
35/100
Issue 類型
重構
描述清晰度
描述清楚
活躍度
停滯
技術堆疊
python
領域
api

研究方向

Start with policyengine_api/country.py, policyengine_api/household_years.py, and policyengine_api/spm.py, then inspect the tests for build_household_options and the metadata response. Remove the listed household-specific options and their tests; done means /{country}/metadata no longer includes household_options, while the follow-up change handles the shared country years. Pull request #4210 is already open for this issue.

由索引模型根據 Issue 內容生成。

描述

Problem

#4159 added household_options.time_period to the /{country}/metadata response: a list of years for household calculations, separate from economy_options.time_period. No client reads it.

The maintainer decided on 4–5 November 2026 that household and society-wide calculations share one list of years per country. A separate household list is therefore no longer needed.

Change

Remove what #4159 added:

  • household_options in the /{country}/metadata response, built by build_household_options in policyengine_api/country.py;
  • policyengine_api/household_years.py;
  • certified_spm_forecast_years in policyengine_api/spm.py, which only build_household_options used;
  • their tests.

A follow-up change defines each country's years once and uses them for economy_options.time_period.

主要語言
Python
星號
18
分支
33
平均合併
2 天 17 小時
30 天內合併 PR
108

環境準備

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

PolicyEngine/policyengine-api 的其他 Issue

查看 PolicyEngine/policyengine-api 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。