Hand config consumers a read-only view of mirth.properties
維護者通常 2 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start at ConfigurationController.getPropertiesConfiguration() (from #405) and wrap the live PropertiesConfiguration with ConfigurationUtils.unmodifiableConfiguration so callers get ImmutableConfiguration. Update declared types and call sites in Mirth, MirthWebServer, servlet filters, and WebStartServlet, including SSL connector construction. Drop the no-op updatePropertiesConfiguration(mirthProperties) in Mirth.startup(). Add boot plus TLS coverage and check tls-manager plugin overrides; done when consumers cannot mutate config while startup writes still show through the view.
由索引模型根據 Issue 內容生成。
描述
ConfigurationController.getPropertiesConfiguration() (added in #405) returns the controller's live, mutable PropertiesConfiguration. Every consumer today (Mirth, MirthWebServer, WebStartServlet) only reads it, so it's safe, but nothing enforces that. A future consumer that mutates it would corrupt the authoritative config the whole server reads.
Enforcing read-only means returning an ImmutableConfiguration (via ConfigurationUtils.unmodifiableConfiguration). That changes the declared type through Mirth, MirthWebServer, the servlet filters, and WebStartServlet, and runs through the SSL connector construction, so it needs its own boot + TLS test and a check of the tls-manager plugin overrides on that path. The controller keeps writing the backing config during startup (keystore password generation, password re-encryption); consumers see those writes through the view but can't make their own.
Also drop the now-dead self-copy in Mirth.startup() (updatePropertiesConfiguration(mirthProperties)), a no-op once the consumer holds the controller's own object.
Context: #405.
- 主要語言
- Java
- 星號
- 227
- 分支
- 81
- 平均合併
- 3 天 6 小時
- 30 天內合併 PR
- 15
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
OpenIntegrationEngine/engine 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#485 ·
維護者通常 2 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 62/100
OpenIntegrationEngine/engine#478 · 1 則留言 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#355 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#347 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#313 ·
維護者通常 2 天內回覆
查看 OpenIntegrationEngine/engine 的全部 Issue
相似的 Issue
-
bug follow-up lane:backlog
難度 2/5 1-3 小時 新手友好度 82/100
Sanne/incus-spawn#1576 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 69/100
checkstyle/checkstyle#22069 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 86/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 67/100
it-at-m/eNoVa-Editor#79 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆