Database Connectors: faulty CustomDriver registration logic
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Start at CustomDriver.java around the DriverManager deregister path (the linked line ~130) and how delegate is used in connect. Reproduce with an Oracle JDBC driver loaded as a Resource rather than server-lib/custom-lib, after the PR #340 behavior. Decide whether deregister must be skipped or isolated for drivers whose deregister hook runs global cleanup (OracleDriver’s TimeoutInterruptHandler.stopTimer / Clock static init). Done means Oracle Database Reader channels can start more than once without NoClassDefFoundError on oracle.net.nt.Clock, without forcing the jar into server-lib.
由索引模型根據 Issue 內容生成。
描述
From testing the fix submitted with PR #340 (more context in this Discord thread), it seems like there might be a problem with logic in CustomDriver initialisation, specifically when used with Oracle JDBC driver.
See this line: CustomDriver.java:130
Intendedly, in order to prevent default first-match driver selection behavior of DriverManager, CustomDriver attempts to deregister the configured driver from DriverManager and use it directly through the delegate property.
However, in the case of OracleDriver (and perhaps others), the deregister function it provides when registering with DriverManager contains globally destructive cleanup code which prevents the class from being used again after deregistering.
Specifically, from the ojdbc17-23.26.2.0.0.jar, when this deregister function of OracleDriver.java gets called as part of CustomDriver init:
private static void deregister() {
unRegisterMBeans();
AbstractTrueCacheConnectionPools.destroyAllPools();
OracleTimeoutThreadPerVM.stopWatchdog();
ThreadedCachingBlockSource.stopBlockReleaserThread();
TimeoutInterruptHandler.stopTimer();
if (threadPool != null) {
threadPool.shutdownNow();
}
HAManager.shutdownAll();
OracleDataSource.cleanup();
TxnFailoverManagerImpl.cleanup();
TcpMultiplexer.stop();
}
The TimeoutInterruptHandler.stopTimer(); call causes the static init block of oracle.net.nt.Clock to fail on future attempts to use the OracleDriver class:
package oracle.net.nt;
public class Clock {
...
static {
if (cachedCurrentTimeMillisTaskStarted.compareAndSet(false, true)) {
TimeoutInterruptHandler.scheduleAtFixedRate(cacheCurrentTimeMillis, 0L, ACCURACY_IN_MILLIS);
}
}
}
Resulting in the following error when attempting to Start a deployed channel with Database Reader source of Oracle type (imported as Resource not part of custom-lib directory):
[2026-07-15 21:02:42.385] ERROR (com.mirth.connect.server.channel.ErrorTaskHandler:26): com.mirth.connect.donkey.server.StartException: Failed to start channel test db connection 2 (5e6adfe6-4200-4543-bfb1-01dcd7c33969).
at com.mirth.connect.donkey.server.channel.Channel.start(Channel.java:792)
at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.doDeploy(DonkeyEngineController.java:2031)
at com.mirth.connect.server.controllers.DonkeyEngineController$DeployTask.execute(DonkeyEngineController.java:1835)
at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:67)
at com.mirth.connect.server.channel.ChannelTask.call(ChannelTask.java:16)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NoClassDefFoundError: Could not initialize class oracle.net.nt.Clock
at oracle.net.nt.NetStatImpl.incrementBytesSent(NetStatImpl.java:80)
at oracle.net.nt.TimeoutSocketChannel.logWrite(TimeoutSocketChannel.java:887)
at oracle.net.nt.TimeoutSocketChannel.doBlockedWrite(TimeoutSocketChannel.java:833)
at oracle.net.nt.TimeoutSocketChannel.write(TimeoutSocketChannel.java:772)
at oracle.net.nt.SSLSocketChannel.writeToSocket(SSLSocketChannel.java:931)
at oracle.net.nt.SSLSocketChannel.shutdown(SSLSocketChannel.java:443)
at oracle.net.nt.SSLSocketChannel.disconnect(SSLSocketChannel.java:991)
at oracle.net.nt.TcpNTAdapter.disconnect(TcpNTAdapter.java:636)
at oracle.net.ns.NSProtocolNIO.establishConnectionAfterRefusePacket(NSProtocolNIO.java:584)
at oracle.net.ns.NSProtocolNIO.handleConnectPacketResponse(NSProtocolNIO.java:482)
at oracle.net.ns.NSProtocolNIO.negotiateConnection(NSProtocolNIO.java:287)
at oracle.net.ns.NSProtocol.connect(NSProtocol.java:369)
at oracle.jdbc.driver.T4CConnection.connectNetworkSessionProtocol(T4CConnection.java:3978)
at oracle.jdbc.driver.T4CConnection.logon(T4CConnection.java:1187)
at oracle.jdbc.driver.PhysicalConnection.connect(PhysicalConnection.java:1236)
at oracle.jdbc.driver.T4CDriverExtension.getConnection(T4CDriverExtension.java:107)
at oracle.jdbc.driver.OracleDriver.connect(OracleDriver.java:817)
at oracle.jdbc.driver.OracleDriver.connect(OracleDriver.java:720)
at com.mirth.connect.connectors.jdbc.CustomDriver.connect(CustomDriver.java:153)
at com.mirth.connect.connectors.jdbc.CustomDriver.connect(CustomDriver.java:148)
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.initSelectConnection(DatabaseReceiverQuery.java:338)
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.initConnection(DatabaseReceiverQuery.java:101)
at com.mirth.connect.connectors.jdbc.DatabaseReceiverQuery.start(DatabaseReceiverQuery.java:87)
at com.mirth.connect.connectors.jdbc.DatabaseReceiver.onStart(DatabaseReceiver.java:115)
at com.mirth.connect.donkey.server.channel.SourceConnector.start(SourceConnector.java:106)
at com.mirth.connect.donkey.server.channel.PollConnector.start(PollConnector.java:31)
at com.mirth.connect.donkey.server.channel.Channel.start(Channel.java:768)
... 8 more
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.IllegalStateException: Timer already cancelled. [in thread "Channel DeployTask Thread on (5e6adfe6-4200-4543-bfb1-01dcd7c33969) < pool-8-thread-1"]
at java.base/java.util.Timer.sched(Unknown Source)
at java.base/java.util.Timer.scheduleAtFixedRate(Unknown Source)
at oracle.net.nt.TimeoutInterruptHandler.scheduleAtFixedRate(TimeoutInterruptHandler.java:303)
at oracle.net.nt.Clock.<clinit>(Clock.java:58)
at oracle.net.nt.NetStatImpl.incrementBytesSent(NetStatImpl.java:80)
at oracle.net.nt.TimeoutSocketChannel.logWrite(TimeoutSocketChannel.java:887)
at oracle.net.nt.TimeoutSocketChannel.doBlockedWrite(TimeoutSocketChannel.java:833)
at oracle.net.nt.TimeoutSocketChannel.write(TimeoutSocketChannel.java:772)
at oracle.net.nt.SSLSocketChannel.writeToSocket(SSLSocketChannel.java:931)
at oracle.net.nt.SSLSocketChannel.wrapHandshakeMessage(SSLSocketChannel.java:699)
at oracle.net.nt.SSLSocketChannel.doSSLHandshake(SSLSocketChannel.java:539)
at oracle.net.nt.SSLSocketChannel.write(SSLSocketChannel.java:199)
at oracle.net.ns.NIOPacket.writeToSocketChannel(NIOPacket.java:378)
at oracle.net.ns.NIOConnectPacket.writeToSocketChannel(NIOConnectPacket.java:291)
at oracle.net.ns.NSProtocolNIO.negotiateConnection(NSProtocolNIO.java:214)
... 24 more
Note that the channel could only be deployed once the fix from PR #340 is in place. Without it, channel deploy fails as documented in #338.
The simple workaround for this is to keep the driver libraries within server-lib. However, this defeats the stated purpose of CustomDriver to allow multiple different versions of the same Driver class to be used.
Is this a fundamental flaw in CustomDriver's expectation to be able to trigger driver deregistering, or could there be some straightforward way to accomodate such drivers with terminal cleanup functions?
- 主要語言
- Java
- 星號
- 227
- 分支
- 81
- 平均合併
- 3 天 6 小時
- 30 天內合併 PR
- 15
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
OpenIntegrationEngine/engine 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#485 ·
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 62/100
OpenIntegrationEngine/engine#478 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#355 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#347 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
OpenIntegrationEngine/engine#313 ·
維護者通常 1 天內回覆
查看 OpenIntegrationEngine/engine 的全部 Issue
相似的 Issue
-
[Bug] Lock owned by another client (e.g. Text app) cannot be unlocked from the app可能已有人在做 @falkloewert 今天認領。 未關閉
難度 2/5 1-3 小時 新手友好度 72/100
維護者通常 1 天內回覆
-
bug grammar sev-0
難度 1/5 1 小時以內 新手友好度 86/100
-
難度 2/5 1-3 小時 新手友好度 76/100
-
難度 2/5 1-3 小時 新手友好度 74/100
oracle/graalvm-reachability-metadata#11026 ·
維護者通常 1 天內回覆
-
bug
難度 1/5 1 小時以內 新手友好度 88/100
維護者通常 1 天內回覆