Android jsi: console timers map is shared by every runtime thread without a lock
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
研究方向
Read NativeScript/runtime/android/jsi/modules/console/Console.h and Console.cpp, tracing createConsole(), the console.time and console.timeEnd callbacks, and onDisposeRuntime(). Reproduce the race with the worker stress test described for #93, using HWASan if available. Done when creating and disposing runtimes during timer calls no longer races on the shared map; the issue lists a mutex or per-runtime state as possible approaches.
由索引模型根據 Issue 內容生成。
描述
Summary
On jsi, Console::s_rtToConsoleTimersMap (NativeScript/runtime/android/jsi/modules/console/Console.{h,cpp}) is a single, process-wide std::map that every runtime reads and writes from its own thread with no lock:
- insert:
createConsole()→s_rtToConsoleTimersMap.emplace(rt.identity(), ...), when each runtime starts; - find: the
console.time/console.timeEndcallbacks; - erase:
onDisposeRuntime(), when each runtime is disposed.
When workers start or stop while another runtime is using the map, one thread rebalances the tree while another walks it. That is a data race and can corrupt the heap or crash.
How it was found
The worker stress test used for #93 (12 workers at a time, created and terminated after 20–300 ms, with JS and Java GC forced throughout). HWASan was turned on locally; it is off by default. On jsi, this map crashed every stress run.
Expected
Creating or disposing one runtime can't corrupt another runtime's console timers. Possible fixes:
- guard the map with a mutex;
console.timeis not a hot path; - or make the timers per-runtime state owned by the
Consoleinstance or the runtime.
Environment
- Branch:
android-react-nativeat 64c7fed0 - Emulator: Android API 36, arm64, debug build of
platforms/android/test-appwith HWASan enabled locally - Binding layer: jsi
- 主要語言
- C++
- 星號
- 27
- 分支
- 4
- 平均合併
- 16 小時 48 分鐘
- 30 天內合併 PR
- 4
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
NativeScript/runtimes 的其他 Issue
-
bug
難度 4/5 3-5 天 新手友好度 48/100
NativeScript/runtimes#100 ·
維護者通常 1 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 45/100
NativeScript/runtimes#99 ·
維護者通常 1 天內回覆
-
bug
難度 4/5 1-2 天 新手友好度 55/100
NativeScript/runtimes#98 ·
維護者通常 1 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 48/100
NativeScript/runtimes#94 ·
維護者通常 1 天內回覆
-
bug
難度 4/5 3-5 天 新手友好度 48/100
NativeScript/runtimes#93 ·
維護者通常 1 天內回覆
查看 NativeScript/runtimes 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 72/100
elf-alchemist/elfbsp#113 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 75/100
patrick-hudson/put.gd-desktop#979 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
Dao-AILab/flash-attention#3097 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 85/100
Niko1221/Strata#4779 · 2 則留言 ·
維護者通常 3 天內回覆
-
tech-debt
難度 2/5 1-3 小時 新手友好度 82/100
prestonbrown/helixscreen#1990 ·
維護者通常 1 天內回覆