ArgConverter::SetValue: invalid pointer for a JS number or boolean in an object slot, and a leaked adapter for a plain object from an unowned method
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 新手友好度
- 45/100
- Issue 類型
- 缺陷
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- cpp, ios, javascript, objective-c
- 領域
- mobile-dev
研究方向
Start at ArgConverter::SetValue and its caller, then read ArgConverter::RetainOwnedResult and the boxing path in Interop::SetFFIParams; compare with the owned-return handling added in #569. Reproduce the table cases with a native caller and add the four tests from the issue, running them under AddressSanitizer. Done when object-typed slots always hold a valid NSNumber, NSString or nil and the WeakRef test clears after the autorelease pool drains.
由索引模型根據 Issue 內容生成。
描述
Summary
ArgConverter::SetValue writes the result of a JS-implemented method, getter or block into the native return slot. For some combinations of JS value and native return type it writes nothing, or writes something that is not a valid value of that type, and native code then reads it.
| JS result | Native return type | What is written |
|---|---|---|
| number | object (id, a class, instancetype) |
nothing: the slot keeps whatever it held |
true |
object | the integer 1, which native code treats as an object pointer |
false |
object | 0, which reads as nil |
| string | instancetype |
nothing |
A string returned for an id or class-typed result is converted to an NSString, and null/undefined zero the slot; those are fine.
const X = NSObject.extend({
description() { return 42; }, // NSString* expected: the slot is not written
});
The caller then messages a garbage pointer, or 0x1. This is a mistake in the JS implementation, but the runtime should fail predictably and not hand native code an arbitrary pointer.
A plain JS object from a method that doesn't own its return leaks its adapter
A related gap in the same function. For a plain JS object (or an array, function or Date) returned where an object is expected, SetValue creates a DictionaryAdapter with alloc/init and writes it at +1. A CFAutorelease(adapter) next to it is commented out.
That +1 is right when the method owns its return (the copy, mutableCopy and new families, initializers), and since #569 those are balanced. For any other method the native caller doesn't own the result and never releases it, so the adapter is never freed and its Persistent keeps the JS object alive:
const X = NSObject.extend({ makeThing() { return {}; } }, {
exposedMethods: { makeThing: { returns: NSObject } },
});
// a native caller of -makeThing: the adapter and the object it wraps are never freed
Seen with a WeakRef on the returned object, which never clears after a native performSelector: call.
The fix is to hand the adapter over at +0 (autoreleased) when the method doesn't own its return. SetValue already reports whether it wrote an object the caller doesn't own; it would need to distinguish "wrote a +1 object" from "wrote nothing" so the caller can autorelease in the unowned case.
Suggested fix
In ArgConverter::SetValue, for object return types:
- box a JS number or boolean as an
NSNumber, as argument marshalling already does for a number passed to an object parameter (Interop::SetFFIParams), or write nil if boxing is not wanted there; - convert a string for
instancetypeas forid, or write nil; - in every other case that has no conversion, zero the slot.
The function has a TODO about reusing Interop::SetFFIParams; sharing that logic would fix all of these at once.
Whatever is boxed is returned at +0, so it also has to go through the owned-result retain added in #569 (ArgConverter::RetainOwnedResult), which today only recognises wrapped objects and strings.
Tests to add
- A JS method declared to return an object that returns a number,
true, andfalse: a native caller gets anNSNumber(or nil), never an invalid pointer. Run under AddressSanitizer. - A JS initializer (
instancetype) that returns a string: the native caller gets nil or anNSString, not an unwritten slot. - The same through an owned-return method (
copyWithZone:), checking the count of the boxed result. - A JS method that doesn't own its return, returning a fresh plain object to a native caller: a
WeakRefon the object clears once the caller's autorelease pool drains.
Found while reviewing #569; not reproduced in a spec yet, because in Debug builds some of these paths assert first.
- 主要語言
- JavaScript
- 星號
- 154
- 分支
- 46
- 平均合併
- 4 天 2 小時
- 30 天內合併 PR
- 30
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
NativeScript/ios 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
NativeScript/ios#577 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 12/100
NativeScript/ios#571 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 45/100
NativeScript/ios#528 · 1 則留言 ·
維護者通常 1 天內回覆
-
interop.FunctionReference function passed as a block, then as a function pointer, asserts可能已有人在做 @edusperoni 於 39 天前認領。 未關閉
難度 4/5 3-5 天 新手友好度 22/100
NativeScript/ios#503 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 38/100
NativeScript/ios#459 · 1 則留言 ·
維護者通常 1 天內回覆
相似的 Issue
-
難度 1/5 1-3 小時 新手友好度 88/100
mattabate/life-distributable#231 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
-
難度 2/5 1-3 小時 新手友好度 68/100
sfbrigade/pocket-gardens#60 ·
維護者通常 5 天內回覆
-
The print preview leaves writing space short by the margins of hidden headers, footers and solutions未關閉
難度 2/5 1-3 小時 新手友好度 78/100
PreTeXtBook/pretext#3329 ·
維護者通常 1 天內回覆
-
bug good first issue
難度 2/5 1-3 小時 新手友好度 84/100
devarshishimpi/codra#178 ·
維護者通常 1 天內回覆