Hacktoberfest 2026:維護者為十月標記出來的 issue,仍然開放、適合新手。 瀏覽 Hacktoberfest issue

[Bug]: manual nodes are persisted only by the desktop app, so a headless nvpair-tui node loses them on every restart

未關閉
#58 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 5 天內回覆

@sylvesterkaczmarek 已經在處理了。

開始於 2026年9月10日。

  • #60 來自 @sylvesterkaczmarek —— 未關閉

評估

難度
4/5
預估耗時
3-5 天
新手友好度
65/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
go, typescript
領域
backend, desktop

研究方向

從 services/nvpair-ui-broker/manualnodes.go 和 services/nvpair-tui/ui/manualnodes.go 開始,接著將它們與 desktop/src/electron/service-bridge/manual-nodes-store.ts 以及 supervisor 的 replay 行為進行比較。使用文件中記載的 systemctl 命令重現重新啟動,並檢查 node-settings README 以確認每位使用者的資料路徑。對於 TUI、desktop 和 service-mode 前端,手動節點在 ready 後能夠持久化並 replay,即表示完成。

由索引模型根據 Issue 內容生成。

描述

PAIR version or commit

Debian package nvpair 0.1.1-463 (amd64). nvpair-ui-broker --version reports 0.40.2.

Affected component

Discovery or pairing

Environment
OS:            Ubuntu 26.04 LTS, x86_64
Front end:     nvpair-tui only (started by a `systemd --user` unit inside tmux, linger enabled).
               The Electron desktop app is not installed on these nodes.
GPU / driver:  consumer NVIDIA GPUs, driver 595.91.07
Engine:        Ollama 0.33.3, adopted by PAIR as the node engine
Cluster size:  5 nodes joined to one cluster, split across two routed subnets
Steps to reproduce
  1. On a node whose only front end is nvpair-tui, open the Manual tab, press a, enter a peer address, press Enter.
  2. Confirm the entry is listed as OLLAMA yes / NODE yes, and that the peer appears in Proxies -> Ollama upstreams.
  3. Restart the front end and its broker: systemctl --user restart nvpair-tui.
  4. Open the Manual tab again.
Expected behavior

The manual node list survives a restart on any supported front end.

This matters because on a cluster split across routed subnets, manual nodes are the only way to
pair peers at all (mDNS does not cross subnets, and #1 additionally prevents reflectors from
relaying the records). Losing the list on every restart makes such a cluster impractical to
operate without the desktop app.

Actual behavior

After the restart the Manual tab shows No manual nodes. and the peer is gone from
Ollama upstreams. Nothing was written to disk: configs/manual-nodes.json never appears
in the per-user data dir, and the configs/ directory is not created.

Reading the source, the durable list appears to be implemented only in the Electron app:

  • desktop/src/electron/service-bridge/manual-nodes-store.ts reads and writes
    <userData>/configs/manual-nodes.json with entries { id, address, name }.
  • desktop/src/electron/service-bridge/modular-supervisor.ts notes that
    "PAIR UI owns the durable list (manual-nodes.json) and replays it once".
  • services/nvpair-ui-broker/manualnodes.go performs no file I/O, and
    services/nvpair-tui/ui/manualnodes.go neither reads nor writes that file.
  • services/nvpair-manual-nodes is stateless by design — its README documents
    node/add, node/remove, nodes/list and no state or config-path flag.

So the replay is desktop-only, even though services/nvpair-node-settings/README.md already
describes manual-nodes.json as living in the per-user data dir, "same directory as
settings.json" — which reads as if the file is meant to be a per-node artifact rather than a
private detail of the desktop app.

Suggested fix

Move ownership of the durable list, and the one-shot replay after ready, into
nvpair-ui-broker. The broker already supervises nvpair-manual-nodes over JSON-RPC and
already has node/add available, so every front end — desktop, TUI, and any future
service mode (cf. #49, #32) — would inherit persistence without its own copy of the logic.

Sanitized logs

Manual tab, immediately after adding the entry:

 ID                    ADDRESS                       OLLAMA    NODE
 manual:peer-a.…       peer-a.example.internal       yes       yes

Per-user data dir at the same moment (no configs/ directory is created):

$ ls "$HOME/.config/Nvidia Corporation/Personal AI Router/configs/"
ls: cannot access '.../configs/': No such file or directory

After systemctl --user restart nvpair-tui:

No manual nodes. Press a to add one by address.
a add node • r remove node • tab next • shift+tab prev • ? help • q quit
$ ls "$HOME/.config/Nvidia Corporation/Personal AI Router/configs/"
ls: cannot access '.../configs/': No such file or directory
Related
  • #1 — mDNS answers sent from an ephemeral source port, so reflectors never relay node records
    across subnets. Together with this issue, a routed multi-subnet cluster cannot be kept paired
    from a headless node.
  • #49 — Build a service version on Linux.
  • #32 — Run a services-only PAIR node as a container or Kubernetes pod.
Confirmations
  • I searched existing issues for duplicates.
  • This is not a security vulnerability.
  • I agree to follow the Code of Conduct.
主要語言
Go
星號
1.6k
分支
266
平均合併
3 天 6 小時
30 天內合併 PR
22

環境準備

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

NVIDIA/Personal-AI-Router 的其他 Issue

查看 NVIDIA/Personal-AI-Router 的全部 Issue

相似的 Issue

更多 Go Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。