Remote file access: parallel ranged downloads — downloadTo(...) with parallelism(K), ~3× on modern hosts
維護者通常 1 天內回覆
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 38/100
- Issue 類型
- 功能
- 描述清晰度
- 基本清楚
- 活躍度
- 活躍
- 技術堆疊
- java
研究方向
Start by reviewing the existing ranged openStream() and downloadTo flow from #146 and #147, then inspect the builder's credential lifecycle before settling how sibling connections are created. Use FakeWsmanServer and WinRMLiveTest for the concurrent-range, quota, cleanup, and checksum cases. Done means the stated acceptance criteria pass and files.md/file-transfers.md document the threshold and quota behavior.
由索引模型根據 Issue 內容生成。
描述
Follow-up of #147 (
downloadFile), building on the byte-range reads of #146. Related: #175 (raw bytes instead of base64), which raises the per-connection rate and composes with this.
Context
A remote file read through the command shell is capped per output stream: the WinRM service reads a command's stdout pipe itself, at most 32 KiB per read and about 60 reads per second. With base64 that gives about 1.45 MB/s of file data per connection, whatever the network or the client (see the Performance section of files.md).
Each command gets its own pipe, so several commands in parallel, each reading one byte range on its own connection, add up. Measured with a 40 MiB random file split into K ranges, one WinRMClient per range (file(p).offset(o).length(l).openStream()), reassembled result verified by SHA-256 (all OK):
| Host | K=1 | K=2 | K=4 | K=8 |
|---|---|---|---|---|
| Windows Server 2022, PS 5.1 | 1.46 MB/s | 2.95 (2.0×) | 4.92 (3.4×) | 4.78 (no gain) |
| Windows Server 2019, PS 5.1 | 1.43 | 2.67 (1.9×) | 4.57 (3.2×) | 4.64 (no gain) |
| Windows Server 2008 R2, PS 2.0 | 1.46 | 2.82 (1.9×) | 3.73 (2.6×) | fails: MaxShellsPerUser = 5 (WSManFault 2150859173) |
- Near-linear up to K=2, then a second ceiling around 4.6–4.9 MB/s per host from K=4 on (per-connection rate drops to ~0.6 MB/s at K=8). Its cause is not identified yet (host CPU on a 4-vCPU VM, NTLM sealing in the WinRM service, network?). The client is not it (it takes in 24–31 MB/s against a local fake server).
- Opening, authenticating and creating a shell for all K connections took 0.2–0.9 s in total.
- Windows 2008 R2's default
MaxShellsPerUseris 5, and the caller's own client already holds one: at most 4 extra connections there. ItsMaxConcurrentOperationsPerUser(15) did not trigger at K=4.
Proposal
client.file("D:\\logs\\huge.log")
.parallelism(4) // default 1 = today's single stream
.downloadTo(Path.of("huge.log"));
- One setup call on the caller's client: the file size and the remote SHA-256 (the digest #147 already probes).
- Split into K ranges; each worker opens its own connection (same host, credentials and settings as the caller's client), reads its range with the existing ranged
openStream(), and writes it at its position in the temporary destination file (FileChannel.write(buffer, position)), so no reordering buffer is needed. - Once all ranges are in, the #147 flow unchanged: digest the whole temporary file, compare,
fsync,ATOMIC_MOVE. A file modified during the transfer shows up as a digest mismatch.
Rules:
- Only above a size threshold (e.g. 8 MiB): below it, the extra connections cost more than they save.
- Graceful degradation: when opening a worker connection is refused by a quota (2150859173 concurrent shells, 2150859174 concurrent operations), continue with the workers already open instead of failing — and never retry past the quota in a tight loop.
- Recommended value 4 (the measured sweet spot); document that more does not help and that 2008 R2 allows at most 4 extra.
- Memory bounded by one buffer per worker; the temporary file is deleted on any failure (as in #147).
openStream()stays single-stream (parallel streaming would need a reordering buffer — out of scope).
Design question to settle first
A WinRMClient is a serial channel and cannot open further connections today: the password is consumed by build(). Options:
- the builder keeps the credentials (it already needs them for re-authentication?) so the client can open sibling connections internally — security review needed for how long the
char[]lives and how it is wiped onclose(); - or the caller passes the extra clients/a factory (
parallelism(Supplier<WinRMClient>, 4)) — no credential retention, clumsier API.
Tests & docs
FakeWsmanServer: several concurrent connections, ranges reassembled byte-exact, a quota refusal on the 3rd connection → download completes with 2 workers, a worker failure midway → no destination file and no temporary file left.WinRMLiveTest: parallel download of a ≥ 40 MiB file on a real host, SHA-256 verified.files.md/file-transfers.md: the scaling table above (re-measured), the threshold, the quota limits.
Acceptance criteria
downloadTowithparallelism(4)is ≥ 2.5× faster thanparallelism(1)on a 40 MiB file on a modern host, byte-exact.- On Windows 2008 R2 with default quotas,
parallelism(8)degrades to what the quota allows instead of failing. mvn verify sitegreen.
🤖 Generated with Claude Code
- 主要語言
- Java
- 星號
- 15
- 分支
- 4
- 平均合併
- 11 小時 58 分鐘
- 30 天內合併 PR
- 20
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南,環境需要你自己搭建:先看它的 README,通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
MetricsHub/winrm-java 的其他 Issue
-
bug documentation
難度 2/5 1-3 小時 新手友好度 88/100
MetricsHub/winrm-java#202 ·
維護者通常 1 天內回覆
-
bug
難度 3/5 1-2 天 新手友好度 78/100
MetricsHub/winrm-java#199 ·
維護者通常 1 天內回覆
-
enhancement
難度 5/5 一週以上 新手友好度 30/100
MetricsHub/winrm-java#194 ·
維護者通常 1 天內回覆
查看 MetricsHub/winrm-java 的全部 Issue
相似的 Issue
-
area/plugin good first issue
難度 2/5 1-3 小時 新手友好度 88/100
kestra-io/plugin-kestra#200 ·
維護者通常 1 天內回覆
-
bug untriaged
難度 1/5 1 小時以內 新手友好度 92/100
opensearch-project/search-relevance#618 ·
維護者通常 3 天內回覆
-
難度 2/5 1-3 小時 新手友好度 72/100
apache/rocketmq-dashboard#6716 ·
維護者通常 3 天內回覆
-
DefaultRedisList.get(int) does not reject an index equal to the list size可能已有人在做 @ryujungkyun 今天認領。 未關閉status: waiting-for-triage
難度 1/5 1 小時以內 新手友好度 68/100
spring-projects/spring-data-redis#3471 ·
維護者通常 5 天內回覆
-
in: build type: dependency-upgrade
難度 1/5 1 小時以內 新手友好度 62/100
spring-projects/spring-ldap#1791 ·
維護者通常 1 天內回覆