Swap Params codeAction breaks code
還沒有人認領這個 Issue。
評估
研究方向
首先，使用報告中的位置引數範例，在儲存時觸發程式碼動作的 NeoVim 中重現此問題。接著檢查第 462 行附近的 script/core/code-action.lua，並追蹤 Swap Params 編輯；程式碼動作執行後範例維持不變即表示完成。
由索引模型根據 Issue 內容生成。
描述
How are you using the lua-language-server?
NeoVim
Which OS are you using?
MacOS
What is the issue affecting?
Formatting
Expected Behaviour
Write lua code in neovim with codeActions triggered on buffer save. The lua code looks like the following:
vim.api.nvim_create_autocmd('BufWritePre', {})
and save, it will remain unchanged.
Actual Behaviour
It changes the code to the following:
vim.api.nvim_create_autocmd({}, 'BufWritePre')
Reproduction steps
- Install lua-language-server
- Setup lua lsp in neovim (can expand if needed)
- Add the following autocmd to run codeactions on save
vim.api.nvim_create_autocmd('BufWritePre', {
group = vim.api.nvim_create_augroup('auto-format', { clear = false }),
buffer = ev.buf,
callback = function(evt)
local params = vim.lsp.util.make_range_params()
params.context = { }
local result = vim.lsp.buf_request_sync(evt.buf, "textDocument/codeAction", params)
for _, res in pairs(result or {}) do
for _, r in pairs(res.result or {}) do
if r.edit then
local enc = client.offset_encoding or "utf-16"
vim.lsp.util.apply_workspace_edit(r.edit, enc)
end
end
end
vim.lsp.buf.format({ bufnr = ev.buf, id = client.id, timeout_ms = 1000, async = false })
end,
})
- Write some lua code and save that lua code with the cursor still on the same line.
Additional Notes
I was editing my neovim config and the lsp kept switching params like the following:
vim.api.nvim_create_autocmd('BufWritePre', {})
And after my PreWrite autocmd calls codeActions
vim.api.nvim_create_autocmd({}, 'BufWritePre')
which immediately breaks the code because the params are position sensitive.
It only does this if the cursor is on the line of the method call which I suppose makes sense since the code action is called with a range. My full autocmd works like this:
vim.api.nvim_create_autocmd('BufWritePre', {
group = vim.api.nvim_create_augroup('auto-format', { clear = false }),
buffer = ev.buf,
callback = function(evt)
local params = vim.lsp.util.make_range_params()
params.context = { }
local result = vim.lsp.buf_request_sync(evt.buf, "textDocument/codeAction", params)
for _, res in pairs(result or {}) do
for _, r in pairs(res.result or {}) do
if r.edit then
local enc = client.offset_encoding or "utf-16"
vim.lsp.util.apply_workspace_edit(r.edit, enc)
end
end
end
vim.lsp.buf.format({ bufnr = ev.buf, id = client.id, timeout_ms = 1000, async = false })
end,
})
I narrowed it down to this code action here https://github.com/LuaLS/lua-language-server/blob/b5e57c36a9a27b89eb283861fb8946fa787e37d8/script/core/code-action.lua#L462
Maybe I am holding it wrong and it is not supposed to be used in this way but I don't have a problem with other LSPs.
Log File
No log entry was added during this behaviour.
- 主要語言
- Lua
- 星號
- 4.4k
- 分支
- 446
- 平均合併
- 8 天 9 小時
- 30 天內合併 PR
- 1
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
LuaLS/lua-language-server 的其他 Issue
-
enhancement
難度 2/5 1-3 小時 新手友好度 62/100
LuaLS/lua-language-server#1776 ·
-
難度 4/5 3-5 天 新手友好度 35/100
LuaLS/lua-language-server#3470 ·
-
難度 3/5 1-2 天 新手友好度 68/100
LuaLS/lua-language-server#3469 ·
-
難度 3/5 1-2 天 新手友好度 68/100
LuaLS/lua-language-server#3468 ·
-
難度 3/5 1-2 天 新手友好度 65/100
LuaLS/lua-language-server#3463 · 5 則留言 ·
查看 LuaLS/lua-language-server 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 70/100
維護者通常 3 天內回覆
-
Campaign WC
難度 2/5 1-3 小時 新手友好度 60/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 74/100
public-transport/transitous#2569 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 82/100
-
core: a monitored method's raise rewrites every ? of its message, a resumed runtime's text included可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉severity: low
難度 2/5 1-3 小時 新手友好度 78/100
luainkernel/lunatik#1861 ·
維護者通常 1 天內回覆