Port the symmetry programs from Fortran to C++ (drop the Fortran toolchain)
還沒有人認領這個 Issue。
評估
- 難度
- 5/5
- 預估耗時
- 一週以上
- 新手友好度
- 35/100
- Issue 類型
- 重構
- 描述清晰度
- 描述清楚
- 活躍度
- 活躍
- 技術堆疊
- cmake, cpp, fortran
- 領域
- backend, build-system
研究方向
Start by reading the 17 files under src/apps/symmetry and identify the program entry points and callers described in the issue. Translate the routines into C++ under src/tdat, preserving algorithms, tolerances and output conventions, then compare results against the Fortran programs using the listed molecule, MO diagram and space group cases. Done means outputs agree within tolerance, callers use the library, and the Fortran sources and toolchain references are removed.
由索引模型根據 Issue 內容生成。
描述
src/apps/symmetry is the only Fortran left in ECCE: 17 files, about 7,100 lines (autosym from NWChem, the symmetry-operation and molecule generators symops, genmol, genmollat, gensym, dosymops, cleansym, the space-group tables spgen.f90 and spnames.f90). They build separate programs that the Builder, the calculation editor, the MO diagram and the reaction tools call through temporary files.
Why port
- No Fortran compiler in any build. macOS links libgfortran and libquadmath statically, and the Windows client needs a Fortran-capable MinGW toolchain; this is the last awkward toolchain dependency for the native clients.
- In-process calls instead of a program start and temporary files per call (the MO diagram calls symmetry often).
- One language to debug; the symmetry traps found in the MO work (#132) sit in this code.
Method
- Translate function by function into C++ under
src/tdat(no wx), no redesign: same algorithms, tolerances and output conventions. - Differential test against the existing Fortran programs, kept as the reference during the port: every test and teaching molecule, the MO diagram goldens, and all 230 space groups in several settings. Point group, operations and symmetrized coordinates must agree within tolerance.
- Switch callers to the library; delete the Fortran and the Fortran toolchain (CMake, packaging, CI images) only after the outputs agree.
Outside libraries (spglib, libmsym) are not used: their tolerance behaviour differs from autosym's, which the MO diagram and the Builder's symmetrize depend on.
When: after the 9.3 queue, or earlier if a Windows or macOS client build is blocked by gfortran.
- 主要語言
- C
- 星號
- 10
- 分支
- 8
- 平均合併
- 57 分鐘
- 30 天內合併 PR
- 2
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
FriendsofECCE/ECCE 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 63/100
FriendsofECCE/ECCE#519 ·
-
bug
難度 1/5 1 小時以內 新手友好度 70/100
FriendsofECCE/ECCE#515 ·
-
bug
難度 2/5 1-3 小時 新手友好度 73/100
FriendsofECCE/ECCE#503 ·
-
難度 2/5 1-3 小時 新手友好度 70/100
FriendsofECCE/ECCE#336 · 1 則留言 ·
-
難度 4/5 1-2 天 新手友好度 57/100
FriendsofECCE/ECCE#523 ·
查看 FriendsofECCE/ECCE 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
難度 1/5 1 小時以內 新手友好度 95/100
containers/crun#2415 ·
維護者通常 1 天內回覆
-
Bluetooth: Controller: memcpy() with NULL source in HCI extended and periodic reports可能已有人在做 關聯的 PR 仍在進行中或已合併。 未關閉
難度 2/5 1-3 小時 新手友好度 78/100
zephyrproject-rtos/zephyr#123423 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
KalicoCrew/kalico#1034 ·
維護者通常 1 天內回覆