Local evaluation buckets percentage splits with the server key, so results differ from Flagsmith
還沒有人認領這個 Issue。
評估
研究方向
從 lib/flagsmith.rb 中的 Client#get_identity_model 開始，尤其留意 issue 中連結的複合鍵建構方式，並追蹤環境 API 金鑰如何在本機評估中變得可用。將產生的金鑰與重現案例中預期的 client_key_account_two 比較。更新針對本機 Percentage Splits 評估的測試並執行；SDK 與 dashboard 的 split 結果一致即表示完成。
由索引模型根據 Issue 內容生成。
描述
In local evaluation mode, the client builds the identity's composite key from the environment_key it was configured with:
Local evaluation requires a server-side key, so environment_key is always ser.…. The composite key ends up as ser.<env key>_<identifier>, and that's what PERCENTAGE_SPLIT conditions hash, together with the segment ID.
Flagsmith itself appears to hash splits with the environment's client-side key, the api_key field of the environment document, giving <env key>_<identifier>. The two keys produce different percentages, so the SDK puts a different set of identities in every partial percentage split than the Flagsmith dashboard shows for the same identity and traits.
We found this when an identity that the dashboard showed in a 5% split segment evaluated as outside it in our app. Hashing <env key>_<identifier> gave 1.36 (in the percentage-based segment). Hashing ser.<env key>_<identifier>, what the SDK uses, gave 5.23 (outside the segment).
Reproduction
require "flagsmith"
document = {
id: 1,
api_key: "client_key",
project: {
id: 1, name: "Project", hide_disabled_flags: false,
organisation: {id: 1, name: "Org", feature_analytics: false, stop_serving_flags: false, persist_trait_data: true},
segments: [{
id: 1, name: "60% rollout",
rules: [{type: "ALL", rules: [], conditions: [{operator: "PERCENTAGE_SPLIT", value: "60", property_: "$.identity.key"}]}],
feature_states: [{django_id: 2, featurestate_uuid: "segment-state", enabled: true, feature_state_value: nil,
feature: {id: 1, name: "rollout", type: "STANDARD"}, multivariate_feature_state_values: []}]
}]
},
feature_states: [{django_id: 1, featurestate_uuid: "default-state", enabled: false, feature_state_value: nil,
feature: {id: 1, name: "rollout", type: "STANDARD"}, multivariate_feature_state_values: []}],
identity_overrides: []
}
environment = Flagsmith::Engine::Environment.build(document)
handler = Object.new
handler.define_singleton_method(:environment) { environment }
client = Flagsmith::Client.new(
environment_key: "ser.server_key",
offline_mode: true,
offline_handler: handler,
enable_local_evaluation: true
)
client.get_identity_flags("account_two").is_feature_enabled("rollout")
# => false. Hashing "client_key_account_two" gives 57.05, which is inside the 60% split;
# the SDK hashes "ser.server_key_account_two", which gives 62.53.
Expected
The SDK should match the dashboard and the other evaluation paths by building the composite key from environment.api_key.
Affected versions
4.1.1 and 4.3.0 (latest on RubyGems). It's also present in v5.0.0 and on main. In v5, Mappers::Identity.build_environment_context sets key: identity.composite_key, so the correct fallback in Segments::Evaluator.get_enriched_context, which builds "#{context[:environment][:key]}_#{identifier}" from the environment's api_key, never runs.
Suggested fix
In Client#get_identity_model, pass environment_api_key: environment.api_key instead of environment_key. We're running that change as a monkeypatch.
- 主要語言
- Ruby
- 星號
- 12
- 分支
- 7
- 平均合併
- 2 小時 19 分鐘
- 30 天內合併 PR
- 2
環境準備
這個專案沒有提供開發容器、Dockerfile 或貢獻指南，環境需要你自己搭建：先看它的 README，通用步驟見我們的新手貢獻指南。
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
Flagsmith/flagsmith-ruby-client 的其他 Issue
-
難度 4/5 3-5 天 新手友好度 55/100
-
難度 4/5 3-5 天 新手友好度 48/100
-
難度 3/5 1-2 天 新手友好度 15/100
-
Local evaluation silently drops identity overrides on large environments可能已有人在做 @marc-merino 於 16 天前認領。 未關閉
難度 4/5 3-5 天 新手友好度 55/100
-
難度 4/5 3-5 天 新手友好度 42/100
查看 Flagsmith/flagsmith-ruby-client 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 74/100
維護者通常 1 天內回覆
-
[Bug] Chatwoot v4.19.0 – Super Admin returns 500 due to missing superadmin.scss Vite manifest entry未關閉Bug
難度 2/5 1-3 小時 新手友好度 76/100
維護者通常 2 天內回覆
-
PRM baseline System 1 and 2 fans run continuously in unoccupied hours (low priority)可能已有人在做 @anchapin 於 1 天前認領。 未關閉
難度 2/5 1-3 小時 新手友好度 70/100
NatLabRockies/openstudio-standards#2167 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 76/100
18F/identity-idp#13734 · 1 則留言 ·
維護者通常 1 天內回覆
-
Ubuntu 26.04: gems linking OpenSSL statically (e.g. rugged) fail to build – libjitterentropy3-dev missing可能已有人在做 @BattleAurora 於 1 天前認領。 未關閉Area: Ruby bug report needs triage OS: Ubuntu
難度 2/5 1-3 小時 新手友好度 68/100
actions/runner-images#15068 · 2 則留言 ·
維護者通常 3 天內回覆