Support build tags

未關閉
#82 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
30/100
Issue 類型
功能
描述清晰度
基本清楚
活躍度
活躍
技術堆疊
go

研究方向

The fallback happens when GOFLAGS is non-empty or a .go file falls outside the active build context. Start by finding where GOFLAGS is checked and where the build-context fallback messages are produced, then trace how go list is invoked. The done condition is a fixture with foo_integration_test.go behind //go:build integration: with the tag declared in diffci.json, a change to foo.go selects the package under both tag sets, and without the declaration it still falls back. Because the design is still open, confirm the -mod=readonly question before coding.

由索引模型根據 Issue 內容生成。

描述

adapter enhancement help wanted

Part of #76.

Any non-empty GOFLAGS falls back:

Go custom build flags or incomplete build context require full validation

Files behind a tag that isn't active also fall back (Go files outside the active build context require full validation: …). Repositories with //go:build integration test files hit this constantly.

Proposal

  • Accept GOFLAGS when it contains only -tags=... (and maybe -mod=readonly). Pass the same flags to go list and put them in executionEnv, so the go test command uses the build context that was analysed.
  • Let diffci.json declare extra tag sets (for example "go": { "tags": [[], ["integration"]] }). Run go list once per set, merge the packages, and emit one command group per set.

Must fall back (blocker)

  • Any other GOFLAGS entry (-ldflags, -gcflags, -overlay, ...).
  • A .go file that none of the analysed tag sets or platforms includes.

Done when

  • A fixture with foo_integration_test.go behind //go:build integration shows that, with the tag declared, a change to foo.go selects the package under both tag sets, and without the declaration it still falls back.
主要語言
TypeScript
星號
0
分支
4
平均合併
18 小時 41 分鐘
30 天內合併 PR
48

環境準備

在 Codespaces 中開啟

在瀏覽器裡用你自己的 GitHub 帳號啟動這個專案的開發容器。

  • 沒有 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 閱讀貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

DiffCI/core 的其他 Issue

查看 DiffCI/core 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。